SensorData::getUpdatedAtHumanAttribute() - Code Metrics - Inspection of "Update date/times formatting throughout site" - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#116)

unknown

created 2017-11-15 04:17 UTC

SensorData::getUpdatedAtHumanAttribute() A

↳ Parent: SensorData

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	7
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	7
loc	7
ccs	0
cts	4
cp	0
rs	9.4285
cc	2
eloc	5
nc	2
nop	0
crap	6

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Spatie\Activitylog\Traits\LogsActivity;
use Illuminate\Support\Facades\Auth;

class SensorData extends Model 
{
    //use LogsActivity;

    protected $table = 'sensor_data';

    /**
     * Update the updated_at and created_at timestamps?
     *
     * @var array
     */
    public $timestamps = true;

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = array('sensor_id', 'value');

    /**
     * The attributes that are visible.
     *
     * @var array
     */
    protected $visible = array('id', 'sensor_id', 'value', 'created_at', 'updated_at');
    
    /**
     * The attributes to log in the Activity Log
     *
     * @var array
     */
    protected static $logAttributes = array('id', 'sensor_id', 'value', 'created_at', 'updated_at');
    
    /**
     * Only log those that have actually changed after the update.
     *
     * @var array
     */
    protected static $logOnlyDirty = true;

    /**
     * Get the device associated with the sensor.
     */
    public function sensor()
    {
        return $this->belongsTo('App\Sensor');
    }
    
    /**
     * Accessor: Get the sensor data's last update time in seconds/minutes/hours since update or converted to user
     * friendly readable format.
     * If the time is less then a day old then display time since it last updated
     * If the time is greater then a day old then display the time in the format of Month day, year 12hour:mins am/pm
     * and using the user's preferred timezone
     *
     *
     * @return string
     */
    public function getUpdatedAtHumanAttribute()
    {
        if ($this->updated_at->diffInDays() > 0)
            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        else
            return $this->updated_at->diffForHumans();
    }
    
    /**
     * Accessor: Get the sensor data's creation time in seconds/minutes/hours since update or converted to user
     * friendly readable format.
     * If the time is less then a day old then display time since creation
     * If the time is greater then a day old then display the time in the format of Month day, year 12hour:mins am/pm
     * and using the user's preferred timezone
     *
     *
     * @return string
     */
    public function getCreatedAtHumanAttribute()
    {
        if ($this->created_at->diffInDays() > 0)
            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        else
            return $this->created_at->diffForHumans();
    }
}

1		<?php
2
3		namespace App;
4
5		use Illuminate\Database\Eloquent\Model;
6		use Spatie\Activitylog\Traits\LogsActivity;
7		use Illuminate\Support\Facades\Auth;
8
9		class SensorData extends Model
10		{
11		//use LogsActivity;
12
13		protected $table = 'sensor_data';
14
15		/**
16		* Update the updated_at and created_at timestamps?
17		*
18		* @var array
19		*/
20		public $timestamps = true;
21
22		/**
23		* The attributes that are mass assignable.
24		*
25		* @var array
26		*/
27		protected $fillable = array('sensor_id', 'value');
28
29		/**
30		* The attributes that are visible.
31		*
32		* @var array
33		*/
34		protected $visible = array('id', 'sensor_id', 'value', 'created_at', 'updated_at');
35
36		/**
37		* The attributes to log in the Activity Log
38		*
39		* @var array
40		*/
41		protected static $logAttributes = array('id', 'sensor_id', 'value', 'created_at', 'updated_at');
42
43		/**
44		* Only log those that have actually changed after the update.
45		*
46		* @var array
47		*/
48		protected static $logOnlyDirty = true;
49
50		/**
51		* Get the device associated with the sensor.
52		*/
53		public function sensor()
54		{
55		return $this->belongsTo('App\Sensor');
56		}
57
58		/**
59		* Accessor: Get the sensor data's last update time in seconds/minutes/hours since update or converted to user
60		* friendly readable format.
61		* If the time is less then a day old then display time since it last updated
62		* If the time is greater then a day old then display the time in the format of Month day, year 12hour:mins am/pm
63		* and using the user's preferred timezone
64		*
65		*
66		* @return string
67		*/
68	View Code Duplication	public function getUpdatedAtHumanAttribute()
69		{
70		if ($this->updated_at->diffInDays() > 0)
71		return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
		0 ignored issues – show Bug introduced 2017-11-15 04:19 UTC by Report Bug Copy Issue Report Accessing `timezone` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
72		else
73		return $this->updated_at->diffForHumans();
74		}
75
76		/**
77		* Accessor: Get the sensor data's creation time in seconds/minutes/hours since update or converted to user
78		* friendly readable format.
79		* If the time is less then a day old then display time since creation
80		* If the time is greater then a day old then display the time in the format of Month day, year 12hour:mins am/pm
81		* and using the user's preferred timezone
82		*
83		*
84		* @return string
85		*/
86	View Code Duplication	public function getCreatedAtHumanAttribute()
87		{
88		if ($this->created_at->diffInDays() > 0)
89		return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
		0 ignored issues – show Bug introduced 2017-11-15 04:19 UTC by Report Bug Copy Issue Report Accessing `timezone` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
90		else
91		return $this->created_at->diffForHumans();
92		}
93		}

uidaho / smartsettia

Pull Request — master (#116)

SensorData::getUpdatedAtHumanAttribute() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like