App\Sensor

Complexity

Total Complexity

12

Size/Duplication

Total Lines	163
Duplicated Lines	8.59 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	1

10 Methods

Rating	Name	Duplication	Size	Complexity
A	device()	0	4	1
A	data()	0	4	1
A	getLatestDataAttribute()	0	6	1
A	getLastHourMinutelyAvgDataAttribute()	0	8	1
A	getLastDayHourlyAvgDataAttribute()	0	8	1
A	getLastWeekDailyAvgDataAttribute()	0	8	1
A	getLastMonthDailyAvgDataAttribute()	0	8	1
A	getLastYearMonthlyAvgDataAttribute()	0	8	1
A	getUpdatedAtHumanAttribute()	7	7	2
A	getCreatedAtHumanAttribute()	7	7	2

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Spatie\Activitylog\Traits\LogsActivity;
use Illuminate\Support\Facades\Auth;

class Sensor extends Model 
{
    use LogsActivity;

    protected $table = 'sensors';

    /**
     * Update the updated_at and created_at timestamps?
     *
     * @var array
     */
    public $timestamps = false;

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = array('device_id', 'name', 'type');

    /**
     * The attributes that are visible.
     *
     * @var array
     */
    protected $visible = array('id', 'device_id', 'name', 'type');

    /**
     * The attributes to log in the Activity Log
     *
     * @var array
     */
    protected static $logAttributes = array('id', 'device_id', 'name', 'type');

    /**
     * Only log those that have actually changed after the update.
     *
     * @var array
     */
    protected static $logOnlyDirty = true;

    /**
     * Get the device associated with the sensor.
     */
    public function device()
    {
        return $this->belongsTo('App\Device');
    }

    /**
     * Get the sensor data associated with the sensor.
     */
    public function data()
    {
        return $this->hasMany('App\SensorData');
    }
    
    /**
     * Get the latest sensor data entry associated with the sensor.
     */
    public function getLatestDataAttribute()
    {
        return SensorData::whereRaw('id = (SELECT MAX(id)
                                                    FROM sensor_data
                                                    WHERE sensor_id = ?)', [$this->id])->first() ?? (object)[];
    }
    
    /**
     * Get the last hour's sensor data averaged by the minute for the sensor.
     */
    public function getLastHourMinutelyAvgDataAttribute()
    {
        return $this->hasMany('App\SensorData')
            ->selectRaw("DATE_FORMAT(created_at, '%Y-%m-%d %H:%i') AS date, AVG(value) AS value")
            ->whereRaw("created_at > DATE_SUB(NOW(), INTERVAL 1 HOUR)")
            ->groupBy("date")
            ->get();
    }
    
    /**
     * Get the last day's sensor data averaged hourly for the sensor.
     */
    public function getLastDayHourlyAvgDataAttribute()
    {
        return $this->hasMany('App\SensorData')
            ->selectRaw("DATE_FORMAT(created_at, '%Y-%m-%d %H') AS date, AVG(value) AS value")
            ->whereRaw("created_at > DATE_SUB(NOW(), INTERVAL 1 DAY)")
            ->groupBy("date")
            ->get();
    }
    
    /**
     * Get the last weeks's sensor data averaged daily for the sensor.
     */
    public function getLastWeekDailyAvgDataAttribute()
    {
        return $this->hasMany('App\SensorData')
            ->selectRaw("DATE_FORMAT(created_at, '%Y-%m-%d') AS date, AVG(value) AS value")
            ->whereRaw("created_at > DATE_SUB(NOW(), INTERVAL 7 DAY)")
            ->groupBy("date")
            ->get();
    }
    
    /**
     * Get the last months's sensor data averaged daily for the sensor.
     */
    public function getLastMonthDailyAvgDataAttribute()
    {
        return $this->hasMany('App\SensorData')
            ->selectRaw("DATE_FORMAT(created_at, '%Y-%m-%d') AS date, AVG(value) AS value")
            ->whereRaw("created_at > DATE_SUB(NOW(), INTERVAL 30 DAY)")
            ->groupBy("date")
            ->get();
    }
    
    /**
     * Get the last year's sensor data averaged monthly for the sensor.
     */
    public function getLastYearMonthlyAvgDataAttribute()
    {
        return $this->hasMany('App\SensorData')
            ->selectRaw("DATE_FORMAT(created_at, '%Y-%m') AS date, AVG(value) AS value")
            ->whereRaw("created_at > DATE_SUB(NOW(), INTERVAL 1 YEAR)")
            ->groupBy("date")
            ->get();
    }
    
    /**
     * Accessor: Get the sensor's last update time in seconds/minutes/hours since update or converted to user
     * friendly readable format.
     * If the time is less then a day old then display time since it last updated
     * If the time is greater then a day old then display the time in the format of Month day, year 12hour:mins am/pm
     * and using the user's preferred timezone
     *
     *
     * @return string
     */
    public function getUpdatedAtHumanAttribute()
    {
        if ($this->updated_at->diffInDays() > 0)
            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');

Accessing timezone on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        else
            return $this->updated_at->diffForHumans();
    }
    
    /**
     * Accessor: Get the sensor's creation time in seconds/minutes/hours since update or converted to user
     * friendly readable format.
     * If the time is less then a day old then display time since creation
     * If the time is greater then a day old then display the time in the format of Month day, year 12hour:mins am/pm
     * and using the user's preferred timezone
     *
     *
     * @return string
     */
    public function getCreatedAtHumanAttribute()
    {
        if ($this->created_at->diffInDays() > 0)
            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');

Accessing timezone on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        else
            return $this->created_at->diffForHumans();
    }
}