uidaho / smartsettia

app/Http/Requests/EditDevice.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Http\Requests;
 
 use Illuminate\Foundation\Http\FormRequest;
-use App\Http\Requests\Request;
 use Illuminate\Support\Facades\Auth;
 
 class EditDevice extends FormRequest

Spacing +4 added lines, -4 removed lines

@@ -46,19 +46,19 @@
     {
         $validator = parent::getValidatorInstance();
     
-        $validator->sometimes('site_id', 'bail|integer|digits_between:1,10|exists:sites,id', function ($input) {
+        $validator->sometimes('site_id', 'bail|integer|digits_between:1,10|exists:sites,id', function($input) {
             return !$input->new_site_name && $input->site_id;
         });
     
-        $validator->sometimes('location_id', 'bail|integer|digits_between:1,10|exists:locations,id', function ($input) {
+        $validator->sometimes('location_id', 'bail|integer|digits_between:1,10|exists:locations,id', function($input) {
             return !$input->new_location_name && $input->location_id;
         });
     
-        $validator->sometimes('new_site_name', 'bail|min:2|max:190|name|unique:sites,name', function ($input) {
+        $validator->sometimes('new_site_name', 'bail|min:2|max:190|name|unique:sites,name', function($input) {
             return !$input->site_id && $input->name;
         });
     
-        $validator->sometimes('new_location_name', 'bail|min:2|max:190|name|unique:locations,name', function ($input) {
+        $validator->sometimes('new_location_name', 'bail|min:2|max:190|name|unique:locations,name', function($input) {
             return !$input->location_id && $input->name;
         });
         

app/Device.php

Doc Comments +1 added lines, -1 removed lines

@@ -330,7 +330,7 @@
      * Get the page number of the device for the dashboard device table pagination
      *
      * @param int $limit
-     * @return int
+     * @return double
      */
     public function dashPageNum($limit)
     {

Spacing +8 added lines, -8 removed lines

@@ -29,7 +29,7 @@ 
      *
      * @var array
      */
-    protected $hidden = ['token'];
+    protected $hidden = [ 'token' ];
     
     /**
      * The attributes that are mass assignable.
@@ -48,7 +48,7 @@ 
      *
      * @var array
      */
-    protected static $ignoreChangedAttributes = ['updated_at', 'last_network_update_at'];
+    protected static $ignoreChangedAttributes = [ 'updated_at', 'last_network_update_at' ];
     
     /**
      * The attributes to log in the Activity Log
@@ -89,7 +89,7 @@ 
      */
     public function getSiteAttribute()
     {
-        return $this->location->site ?? (object)[];
+        return $this->location->site ?? (object) [ ];
     }
     
     /**
@@ -119,7 +119,7 @@ 
      */
     public function getOpenTimeHumanAttribute()
     {
-        $time = new Carbon($this->attributes['open_time'], 'UTC');
+        $time = new Carbon($this->attributes[ 'open_time' ], 'UTC');
         $time = $time->setTimezone(Auth::user()->timezone);
         
         return $time->format('h:i a');
@@ -152,7 +152,7 @@ 
      */
     public function getCloseTimeHumanAttribute()
     {
-        $time = new Carbon($this->attributes['close_time'], 'UTC');
+        $time = new Carbon($this->attributes[ 'close_time' ], 'UTC');
         $time = $time->setTimezone(Auth::user()->timezone);
         
         return $time->format('h:i a');
@@ -177,7 +177,7 @@ 
         else
             $time = new Carbon($value, 'UTC');
         
-        $this->attributes['open_time'] = $time->format('H:i:s');
+        $this->attributes[ 'open_time' ] = $time->format('H:i:s');
     }
     
     /**
@@ -199,7 +199,7 @@ 
         else
             $time = new Carbon($value, 'UTC');
         
-        $this->attributes['close_time'] = $time->format('H:i:s');
+        $this->attributes[ 'close_time' ] = $time->format('H:i:s');
     }
     
     /**
@@ -371,7 +371,7 @@ 
         $isClosed = $this->cover_status === 'closed';
         $isLocked = $this->cover_status === 'locked';
             
-        switch ($this['cover_command'])
+        switch ($this[ 'cover_command' ])
         {
             case 'open':
                 if ($isOpen)

Braces +47 added lines, -38 removed lines

@@ -103,8 +103,9 @@ 
         $time = new Carbon($value, 'UTC');
         
         //If the user is logged in then use there preferred timezone
-        if (Auth::check())
-            $time = $time->setTimezone(Auth::user()->timezone);
+        if (Auth::check()) {
+                    $time = $time->setTimezone(Auth::user()->timezone);
+        }
 
         return $time->format('H:i');
     }
@@ -136,8 +137,9 @@ 
         $time = new Carbon($value, 'UTC');
     
         //If the user is logged in then use there preferred timezone
-        if (Auth::check())
-            $time = $time->setTimezone(Auth::user()->timezone);
+        if (Auth::check()) {
+                    $time = $time->setTimezone(Auth::user()->timezone);
+        }
         
         return $time->format('H:i');
     }
@@ -171,9 +173,9 @@ 
         {
             $time = new Carbon($value, Auth::user()->timezone);
             $time = $time->setTimezone('UTC');
+        } else {
+                    $time = new Carbon($value, 'UTC');
         }
-        else
-            $time = new Carbon($value, 'UTC');
         
         $this->attributes['open_time'] = $time->format('H:i:s');
     }
@@ -193,9 +195,9 @@ 
         {
             $time = new Carbon($value, Auth::user()->timezone);
             $time = $time->setTimezone('UTC');
+        } else {
+                    $time = new Carbon($value, 'UTC');
         }
-        else
-            $time = new Carbon($value, 'UTC');
         
         $this->attributes['close_time'] = $time->format('H:i:s');
     }
@@ -211,10 +213,11 @@ 
      */
     public function getLastNetworkUpdateAtHumanAttribute()
     {
-        if ($this->last_network_update_at->diffInDays() > 0)
-            return $this->last_network_update_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->last_network_update_at->diffForHumans();
+        if ($this->last_network_update_at->diffInDays() > 0) {
+                    return $this->last_network_update_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->last_network_update_at->diffForHumans();
+        }
     }
     
     /**
@@ -229,10 +232,11 @@ 
      */
     public function getUpdatedAtHumanAttribute()
     {
-        if ($this->updated_at->diffInDays() > 0)
-            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->updated_at->diffForHumans();
+        if ($this->updated_at->diffInDays() > 0) {
+                    return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->updated_at->diffForHumans();
+        }
     }
     
     /**
@@ -246,10 +250,11 @@ 
      */
     public function getCreatedAtHumanAttribute()
     {
-        if ($this->created_at->diffInDays() > 0)
-            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->created_at->diffForHumans();
+        if ($this->created_at->diffInDays() > 0) {
+                    return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->created_at->diffForHumans();
+        }
     }
     
     /**
@@ -360,10 +365,11 @@ 
         $time_now = Carbon::now($timezone);
     
         //Check if the current time is during the open schedule or not
-        if ($time_now->gt($open_time) && $time_now->lt($close_time))
-            return true;
-        else
-            return false;
+        if ($time_now->gt($open_time) && $time_now->lt($close_time)) {
+                    return true;
+        } else {
+                    return false;
+        }
     }
     
     /**
@@ -380,20 +386,22 @@ 
         switch ($this['cover_command'])
         {
             case 'open':
-                if ($isOpen)
-                    $status = 'open';
-                else if ($isLocked)
-                    $status = 'unlocking';
-                else
-                    $status = 'opening';
+                if ($isOpen) {
+                                    $status = 'open';
+                } else if ($isLocked) {
+                                    $status = 'unlocking';
+                } else {
+                                    $status = 'opening';
+                }
                 break;
             case 'close':
-                if ($isClosed)
-                    $status = 'closed';
-                else if ($isLocked)
-                    $status = 'unlocking';
-                else
-                    $status = 'closing';
+                if ($isClosed) {
+                                    $status = 'closed';
+                } else if ($isLocked) {
+                                    $status = 'unlocking';
+                } else {
+                                    $status = 'closing';
+                }
                 break;
             case 'lock':
                 $status = 'locked';
@@ -402,8 +410,9 @@ 
                 $status = 'error';
         }
     
-        if ($this->cover_status === 'error')
-            $status = 'error';
+        if ($this->cover_status === 'error') {
+                    $status = 'error';
+        }
         
         return $status;
     }

app/User.php

Spacing +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
     public function roleString()
     {
         $role_en = array(0 => "Registered", 1 => "User", 2 => "Manager", 3 => "Admin");
-        return $role_en[ $this->role ] . ' (' . $this->role . ')';
+        return $role_en[ $this->role ].' ('.$this->role.')';
     }
     
     /**

Braces +10 added lines, -8 removed lines

@@ -89,10 +89,11 @@ 
      */
     public function getUpdatedAtHumanAttribute()
     {
-        if ($this->updated_at->diffInDays() > 0)
-            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->updated_at->diffForHumans();
+        if ($this->updated_at->diffInDays() > 0) {
+                    return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->updated_at->diffForHumans();
+        }
     }
     
     /**
@@ -107,9 +108,10 @@ 
      */
     public function getCreatedAtHumanAttribute()
     {
-        if ($this->created_at->diffInDays() > 0)
-            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->created_at->diffForHumans();
+        if ($this->created_at->diffInDays() > 0) {
+                    return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->created_at->diffForHumans();
+        }
     }
 }

Doc Comments +1 added lines, -1 removed lines

@@ -137,7 +137,7 @@
     /**
      * Returns the users role as a string.
      *
-     * @return Users
+     * @return string
      */
     public function roleString()
     {

app/Http/Controllers/DashboardController.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Http\Request;
-use Validator;
 use App\Device;
 use App\Site;
 use App\Location;

Spacing +10 added lines, -10 removed lines

@@ -44,7 +44,7 @@ 
             
             //If the location exists then set the pagination page to be where the device is located
             if ($location != null)
-                $request->merge(['page' => $device->dashPageNum(4)]);
+                $request->merge([ 'page' => $device->dashPageNum(4) ]);
             $site_id = $location->site_id ?? 0;
             $location_id = $location->id ?? 0;
             $device_id = $device->id ?? 0;
@@ -64,14 +64,14 @@ 
             ->get();
         //Get all locations for the selected site with the selected location first
         $locations = Location::select('id', 'name', 'site_id')
-            ->where('site_id', '=', $sites[0]->id ?? 0)
+            ->where('site_id', '=', $sites[ 0 ]->id ?? 0)
             ->orderByRaw("id = ? DESC", $location_id)
             ->orderBy('name', 'ASC')
             ->get();
         //Get all devices for the selected location
         $devices = Device::publicDashData()
             ->leftJoin('deviceimages as image', 'devices.id', '=', 'image.device_id')
-            ->where('location_id', '=', $locations[0]->id ?? 0)
+            ->where('location_id', '=', $locations[ 0 ]->id ?? 0)
             ->orderBy('name', 'ASC')
             ->paginate(4);
     
@@ -84,33 +84,33 @@ 
             //If the original device with the given device id was not found
             //Then assign the the first device in the device list as the active device
             if ($active_device == null)
-                $active_device = $devices[0];
+                $active_device = $devices[ 0 ];
         
             //Add an attribute to each device defining if it is stale
-            $devices->transform(function ($item)
+            $devices->transform(function($item)
             {
                 //Mark the device as stale if the device has missed three updates plus a minute
                 $deviceStaleMins = ceil(($item->update_rate * 3) / 60) + 1;
-                $item['isDeviceStale'] = ($item->last_network_update_at <= Carbon::now()->subMinute($deviceStaleMins)) ? true : false;
+                $item[ 'isDeviceStale' ] = ($item->last_network_update_at <= Carbon::now()->subMinute($deviceStaleMins)) ? true : false;
     
                 //Mark the device image as stale if the device has missed three image updates plus a minute
                 if ($item->image_updated_at != null)
                 {
                     $imageStaleMins = ceil(($item->image_rate * 3) / 60) + 1;
-                    $item['isImageStale'] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
+                    $item[ 'isImageStale' ] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
                 }
                 else
-                    $item['isImageStale'] = false;
+                    $item[ 'isImageStale' ] = false;
                 
                 return $item;
             });
         }
     
         //Store the active site, location, and device in a collection
-        $active_data = collect(['device' => $active_device, 'location' => $locations[0] ?? null, 'site' => $sites[0] ?? null]);
+        $active_data = collect([ 'device' => $active_device, 'location' => $locations[ 0 ] ?? null, 'site' => $sites[ 0 ] ?? null ]);
     
         //Use the device_list.blade.php to generate the device table html
-        $html_device_table = view('dashboard.device_list', ['devices' => $devices, 'active_data' => $active_data])->render();
+        $html_device_table = view('dashboard.device_list', [ 'devices' => $devices, 'active_data' => $active_data ])->render();
         
         if (\Request::ajax())
             return response()->json([ 'active_data' => $active_data, 'devices' => $devices, 'locations' => $locations,

Braces +14 added lines, -12 removed lines

@@ -43,13 +43,13 @@ 
             $location = $device->location ?? null;
             
             //If the location exists then set the pagination page to be where the device is located
-            if ($location != null)
-                $request->merge(['page' => $device->dashPageNum(4)]);
+            if ($location != null) {
+                            $request->merge(['page' => $device->dashPageNum(4)]);
+            }
             $site_id = $location->site_id ?? 0;
             $location_id = $location->id ?? 0;
             $device_id = $device->id ?? 0;
-        }
-        else
+        } else
         {
             //Get the active site, location, and device ids
             $site_id = $request->site_id ?? 0;
@@ -83,8 +83,9 @@ 
         {
             //If the original device with the given device id was not found
             //Then assign the the first device in the device list as the active device
-            if ($active_device == null)
-                $active_device = $devices[0];
+            if ($active_device == null) {
+                            $active_device = $devices[0];
+            }
         
             //Add an attribute to each device defining if it is stale
             $devices->transform(function ($item)
@@ -98,9 +99,9 @@ 
                 {
                     $imageStaleMins = ceil(($item->image_rate * 3) / 60) + 1;
                     $item['isImageStale'] = ($item->image_updated_at <= Carbon::now()->subMinute($imageStaleMins)) ? true : false;
+                } else {
+                                    $item['isImageStale'] = false;
                 }
-                else
-                    $item['isImageStale'] = false;
                 
                 return $item;
             });
@@ -112,12 +113,13 @@ 
         //Use the device_list.blade.php to generate the device table html
         $html_device_table = view('dashboard.device_list', ['devices' => $devices, 'active_data' => $active_data])->render();
         
-        if (\Request::ajax())
-            return response()->json([ 'active_data' => $active_data, 'devices' => $devices, 'locations' => $locations,
+        if (\Request::ajax()) {
+                    return response()->json([ 'active_data' => $active_data, 'devices' => $devices, 'locations' => $locations,
                 'sites' => $sites, 'html_device_table' => $html_device_table ]);
-        else
-            return view('dashboard.index', [ 'active_data' => $active_data, 'devices' => $devices,
+        } else {
+                    return view('dashboard.index', [ 'active_data' => $active_data, 'devices' => $devices,
                 'locations' => $locations, 'sites' => $sites ]);
+        }
     }
     
     /**

app/Sensor.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
     {
         return SensorData::whereRaw('id = (SELECT MAX(id)
                                                     FROM sensor_data
-                                                    WHERE sensor_id = ?)', [$this->id])->first() ?? (object)[];
+                                                    WHERE sensor_id = ?)', [ $this->id ])->first() ?? (object) [ ];
     }
     
     /**

Braces +10 added lines, -8 removed lines

@@ -145,10 +145,11 @@ 
      */
     public function getUpdatedAtHumanAttribute()
     {
-        if ($this->updated_at->diffInDays() > 0)
-            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->updated_at->diffForHumans();
+        if ($this->updated_at->diffInDays() > 0) {
+                    return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->updated_at->diffForHumans();
+        }
     }
     
     /**
@@ -163,9 +164,10 @@ 
      */
     public function getCreatedAtHumanAttribute()
     {
-        if ($this->created_at->diffInDays() > 0)
-            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->created_at->diffForHumans();
+        if ($this->created_at->diffInDays() > 0) {
+                    return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->created_at->diffForHumans();
+        }
     }
 }
\ No newline at end of file

app/Http/Requests/EditLocation.php

Spacing +2 added lines, -2 removed lines

@@ -38,11 +38,11 @@
     {
         $validator = parent::getValidatorInstance();
         
-        $validator->sometimes('site', 'integer|digits_between:1,10|exists:sites,id', function ($input) {
+        $validator->sometimes('site', 'integer|digits_between:1,10|exists:sites,id', function($input) {
             return !$input->new_site_name && $input->site;
         });
         
-        $validator->sometimes('new_site_name', 'bail|min:2|max:190|name|unique:sites,name', function ($input) {
+        $validator->sometimes('new_site_name', 'bail|min:2|max:190|name|unique:sites,name', function($input) {
             return !$input->site;
         });
         

app/DataTables/ActivityLogDataTable.php

Braces +5 added lines, -4 removed lines

@@ -27,10 +27,11 @@
                 return $activity->properties;
             })
             ->editColumn('created_at', function ($activity) {
-                if ($activity->created_at->diffInDays() > 0)
-                    return $activity->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-                else
-                    return $activity->created_at->diffForHumans();
+                if ($activity->created_at->diffInDays() > 0) {
+                                    return $activity->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+                } else {
+                                    return $activity->created_at->diffForHumans();
+                }
             })
             ->rawColumns(['causer_id', 'subject_id', 'properties']);
     }

Spacing +8 added lines, -8 removed lines

@@ -17,30 +17,30 @@ 
     public function dataTable($query)
     {
         return datatables($query)
-            ->editColumn('causer_id', function ($activity) {
+            ->editColumn('causer_id', function($activity) {
                 if ($activity->causer_id) {
-                    return '<a href="' . route($this->getRouteFromType($activity->causer_type), $activity->causer_id) . '">' . $activity->causer->name ?? '' . '</a>';
+                    return '<a href="'.route($this->getRouteFromType($activity->causer_type), $activity->causer_id).'">'.$activity->causer->name ?? ''.'</a>';
                 } else {
                     return '';
                 }
             })
-            ->editColumn('subject_id', function ($activity) {
+            ->editColumn('subject_id', function($activity) {
                 if ($activity->subject_id) {
-                    return '<a href="' . route($this->getRouteFromType($activity->subject_type), $activity->subject_id) . '">' . $activity->subject->name ?? '' . '</a>';
+                    return '<a href="'.route($this->getRouteFromType($activity->subject_type), $activity->subject_id).'">'.$activity->subject->name ?? ''.'</a>';
                 } else {
                     return '';
                 }
             })
-            ->editColumn('properties', function ($activity) {
+            ->editColumn('properties', function($activity) {
                 return $activity->properties;
             })
-            ->editColumn('created_at', function ($activity) {
+            ->editColumn('created_at', function($activity) {
                 if ($activity->created_at->diffInDays() > 0)
                     return $activity->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
                 else
                     return $activity->created_at->diffForHumans();
             })
-            ->rawColumns(['causer_id', 'subject_id', 'properties']);
+            ->rawColumns([ 'causer_id', 'subject_id', 'properties' ]);
     }
     
     public function getRouteFromType($type) {
@@ -137,6 +137,6 @@ 
      */
     protected function filename()
     {
-        return 'activitylog_' . time();
+        return 'activitylog_'.time();
     }
 }

app/DataTables/UsersDataTable.php

Spacing +3 added lines, -3 removed lines

@@ -16,16 +16,16 @@
     {
         return datatables($query)
             ->editColumn('name', function(User $user) {
-                return '<a href="' . route('user.show', $user->id) . '">'. $user->name . '</a>';
+                return '<a href="'.route('user.show', $user->id).'">'.$user->name.'</a>';
             })
 
             ->editColumn('role', function(User $user) {
                 return $user->roleString();
             })
-            ->editColumn('updated_at', function ($user) {
+            ->editColumn('updated_at', function($user) {
                 return $user->updatedAtHuman;
             })
-            ->editColumn('created_at', function ($user) {
+            ->editColumn('created_at', function($user) {
                 return $user->createdAtHuman;
             })
             ->addColumn('action', 'user.action')

app/SensorData.php

Braces +10 added lines, -8 removed lines

@@ -145,10 +145,11 @@ 
      */
     public function getUpdatedAtHumanAttribute()
     {
-        if ($this->updated_at->diffInDays() > 0)
-            return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->updated_at->diffForHumans();
+        if ($this->updated_at->diffInDays() > 0) {
+                    return $this->updated_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->updated_at->diffForHumans();
+        }
     }
     
     /**
@@ -163,9 +164,10 @@ 
      */
     public function getCreatedAtHumanAttribute()
     {
-        if ($this->created_at->diffInDays() > 0)
-            return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
-        else
-            return $this->created_at->diffForHumans();
+        if ($this->created_at->diffInDays() > 0) {
+                    return $this->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');
+        } else {
+                    return $this->created_at->diffForHumans();
+        }
     }
 }
\ No newline at end of file