App\Http\Controllers\UserController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	172
Duplicated Lines	12.21 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	edit()	7	7	1
B	update()	0	29	2
A	remove()	7	7	1

<?php

namespace App\Http\Controllers;

use Validator;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\DataTables\UsersDataTable;
use Illuminate\Support\Facades\Auth;
use Illuminate\Validation\Rule;
use App\User;

class UserController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        $this->middleware('auth');
        // TODO: Setup logging
        // $this->middleware('log')->only('index');

77% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * Display index page and process dataTable ajax request.
     *
     * @param \App\DataTables\UsersDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(UsersDataTable $dataTable)
    {
        return $dataTable->render('user.index');
    }

    /**
     * Show create user page.
     *
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create()
    {
        return view('user.create');
    }

    /**
     * Store a new user.
     *
     * @param  Request  $request
     * @return Response
     */
    public function store(Request $request)
    {
        $validator = Validator::make($request->all(), [
            'name' => 'required|string|max:255',
            'email' => 'required|string|email|max:255|unique:users',
            'password' => 'required|string|min:6|confirmed',
            'role' => 'required|integer|max:3',
            'phone' => 'numeric|phone|nullable',
        ]);

        if ($validator->fails()) {
            return redirect('user/create')->withErrors($validator)->withInput();
        }

        $user = new User;

        $user->name = $request->input('name');

The property name does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->email = $request->input('email');

The property email does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->password = bcrypt($request->input('password'));

The property password does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

It seems like $request->input('password') targeting Illuminate\Http\Concerns\InteractsWithInput::input() can also be of type array; however, bcrypt() does only seem to accept string, maybe add an additional type check?

        $user->role = $request->input('role');

The property role does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->phone = $request->input('phone');

The property phone does not exist on object<App\User>. Since you implemented __set, maybe consider adding a @property annotation.

        $user->save();

        return redirect('user');
    }

    /**
     * Show the given user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show(Request $request, $id)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $user = User::findOrFail($id);
        $user->password = "";

        return view('user.show', ['user' => $user]);
    }

    /**
     * Edit the given user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit(Request $request, $id)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $user = User::findOrFail($id);
        $user->password = "";

        return view('user.edit', ['user' => $user]);
    }

    /**
     * Update the given user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return Response
     */
    public function update(Request $request, $id)
    {
        // TODO: Since HTML forms can't make PUT, PATCH, or DELETE requests, you will need
        // to add a hidden  _method field to spoof these HTTP verbs. The
        // method_field helper can create this field for you:
        // {{ method_field('PUT') }}

64% of this comment could be valid code. Did you maybe forget this after debugging?

        $user = User::findOrFail($id);

        $validator = Validator::make($request->all(), [
            'name' => 'required|string|max:255',
            'email' => 'required|string|email|max:255|unique:users,email,'.$user->id,
            'role' => 'required|integer|max:3',
            'phone' => 'numeric|phone|nullable',
        ]);

        if ($validator->fails()) {
            return redirect('user/'.$id.'/edit')->withErrors($validator)->withInput();
        }

        $user->name = $request->input('name');
        $user->email = $request->input('email');
        $user->role = $request->input('role');
        $user->phone = $request->input('phone');

        $user->save();

        return redirect('user');
    }

    /**
     * Deletes a user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return Response
     */
    public function destroy(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $user = User::findOrFail($id);

        if ($user->trashed()) {
            // if the user was already deleted then permananetly delete it
            User::destroy($id);
        } else {
            // soft delete the user the first time
            $user->delete();
        }

        return redirect('user');
    }
    
    /**
     * Confirms deletion a user.
     *
     * @param  Request  $request
     * @param  string  $id
     * @return Response
     */
    public function remove(Request $request, $id)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $user = User::findOrFail($id);
        $user->password = "";
        
        return view('user.remove', ['user' => $user]);
    }
}