App\Policies\UserPolicy

Complexity

Total Complexity

5

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	before()	0	7	1
A	view()	0	5	1
A	create()	0	5	1
A	update()	0	6	1
A	delete()	0	5	1

<?php

namespace App\Policies;

use App\User;
use Illuminate\Auth\Access\HandlesAuthorization;

class UserPolicy
{
    use HandlesAuthorization;

    /**
     * The before method will be executed before any other methods on the policy,
     * giving you an opportunity to authorize the action before the intended
     * policy method is actually called. This feature is most commonly used for
     * authorizing application administrators to perform any action.
     */
    public function before($user, $ability)

The parameter $user is not used and could be removed.

The parameter $ability is not used and could be removed.

    {
        // TODO: Admins...
        // if ($user->isSuperAdmin()) {

67% of this comment could be valid code. Did you maybe forget this after debugging?

        //     return true;
        // }
    }

    /**
     * Determine whether the user can view the user.
     *
     * @param  \App\User  $user
     * @param  \App\User  $user
     * @return mixed
     */
    public function view(User $user, User $user)

The parameter $user is used multiple times.

The parameter $user is not used and could be removed.

Variable "$user" appears more than once in function declaration

    {
        // TODO: Check if user role is > 0
        return true;
    }

    /**
     * Determine whether the user can create users.
     *
     * @param  \App\User  $user
     * @return mixed
     */
    public function create(User $user)

The parameter $user is not used and could be removed.

    {
        // TODO: Check if user role > 1
        return true;
    }

    /**
     * Determine whether the user can update the user.
     *
     * @param  \App\User  $user
     * @param  \App\User  $user
     * @return mixed
     */
    public function update(User $user, User $user)

The parameter $user is used multiple times.

The parameter $user is not used and could be removed.

Variable "$user" appears more than once in function declaration

    {
        // Users can update themselves
        //return $user->id === $user->id;

50% of this comment could be valid code. Did you maybe forget this after debugging?

        return true;
    }

    /**
     * Determine whether the user can delete the user.
     *
     * @param  \App\User  $user
     * @param  \App\User  $user
     * @return mixed
     */
    public function delete(User $user, User $user)

The parameter $user is used multiple times.

The parameter $user is not used and could be removed.

Variable "$user" appears more than once in function declaration

    {
        // TODO: Check if user role > 1
        return true;
    }
}