ActivityLogDataTable::dataTable() - Code Metrics - Inspection of "Pretty activity log" - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#78)

by Brandon

created 2017-10-15 01:29 UTC

ActivityLogDataTable::dataTable() B

↳ Parent: ActivityLogDataTable

Complexity

Conditions	5
Paths	1

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
dl	0
loc	22
ccs	0
cts	16
cp	0
rs	8.6737
c	2
b	0
f	0
cc	5
eloc	15
nc	1
nop	1
crap	30

<?php

namespace App\DataTables;

use App\User;
use Yajra\DataTables\Services\DataTable;
use Spatie\Activitylog\Models\Activity;

class ActivityLogDataTable extends DataTable
{
    /**
     * Build DataTable class.
     *
     * @return \Yajra\DataTables\DataTableAbstract
     */
    public function dataTable($query)
    {
        return datatables($query)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->editColumn('causer_id', function ($activity) {
                if ($activity->causer_id) {
                    return '<a href="/' . ($activity->causer_type == "App\User" ? 'user' : 'device') . '/' . $activity->causer_id . '">' . $activity->causer->name . '</a>';
                } else {
                    return 'Application';
                }
            })
            ->editColumn('subject_id', function ($activity) {
                if ($activity->subject_id) {
                    return '<a href="/' . ($activity->subject_type == "App\User" ? 'user' : 'device') . '/' . $activity->subject_id . '">' . $activity->subject->name . '</a>';
                } else {
                    return 'None';
                }
            })
            ->editColumn('properties', function ($activity) {
                return $activity->properties;
            })
            ->rawColumns(['causer_id', 'subject_id', 'properties']);
    }

    /**
     * Get query source of dataTable.
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function query()
    {
        $query = Activity::query();
        return $this->applyScopes($query);

    }

    /**
     * Optional method if you want to use html builder.
     *
     * @return \Yajra\DataTables\Html\Builder
     */
    public function html()
    {
        return $this->builder()
            ->columns($this->getColumns())
            ->minifiedAjax()
            ->parameters($this->getBuilderParameters());
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns()
    {
        return [
            'created_at',
            [ 'name' => 'causer_id', 'data' => 'causer_id', 'title' => 'Actor', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'description', 'data' => 'description', 'title' => 'Action', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'subject_id', 'data' => 'subject_id', 'title' => 'Subject', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'properties', 'data' => 'properties', 'title' => 'Changes', 'render' => null, 'searchable' => true, 'orderable' => false, 'exportable' => true, 'printable' => true, 'footer' => '' ]
        ];
    }
    
    /**
     * Get builder parameters.
     *
     * @return array
     */
    protected function getBuilderParameters()
    {
        return [
            'dom'     => 'Bfrtip',
            'order'   => [ [ 0, 'desc' ] ],
            'buttons' => [
                'export',
                'print',
                'reset',
                'reload',
            ],
            'paging' => true,
            'searching' => true,
            'info' => true,
            'searchDelay' => 500,
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'activitylog_' . time();
    }
}


1			<?php
2
3			namespace App\DataTables;
4
5			use App\User;
6			use Yajra\DataTables\Services\DataTable;
7			use Spatie\Activitylog\Models\Activity;
8
9			class ActivityLogDataTable extends DataTable
10			{
11			/**
12			* Build DataTable class.
13			*
14			* @return \Yajra\DataTables\DataTableAbstract
15			*/
16			public function dataTable($query)
17			{
18			return datatables($query)
			1 ignored issue – show Bug introduced 2017-10-15 01:30 UTC by Report Bug Copy Issue Report The method `editColumn` does only exist in `Yajra\DataTables\DataTableAbstract`, but not in `Yajra\DataTables\DataTables`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
19			->editColumn('causer_id', function ($activity) {
20			if ($activity->causer_id) {
21			return '<a href="/' . ($activity->causer_type == "App\User" ? 'user' : 'device') . '/' . $activity->causer_id . '">' . $activity->causer->name . '</a>';
22			} else {
23			return 'Application';
24			}
25			})
26			->editColumn('subject_id', function ($activity) {
27			if ($activity->subject_id) {
28			return '<a href="/' . ($activity->subject_type == "App\User" ? 'user' : 'device') . '/' . $activity->subject_id . '">' . $activity->subject->name . '</a>';
29			} else {
30			return 'None';
31			}
32			})
33			->editColumn('properties', function ($activity) {
34			return $activity->properties;
35			})
36			->rawColumns(['causer_id', 'subject_id', 'properties']);
37			}
38
39			/**
40			* Get query source of dataTable.
41			*
42			* @return \Illuminate\Database\Eloquent\Builder
43			*/
44			public function query()
45			{
46			$query = Activity::query();
47			return $this->applyScopes($query);
			0 ignored issues – show Bug Compatibility introduced 2017-10-09 09:31 UTC by Report Bug Copy Issue Report The expression `$this->applyScopes($query);` of type `Illuminate\Database\Quer...tabase\Eloquent\Builder` adds the type `Illuminate\Database\Query\Builder` to the return on line 47 which is incompatible with the return type documented by `App\DataTables\ActivityLogDataTable::query` of type `Illuminate\Database\Eloquent\Builder`. Loading history...
48			}
49
50			/**
51			* Optional method if you want to use html builder.
52			*
53			* @return \Yajra\DataTables\Html\Builder
54			*/
55			public function html()
56			{
57			return $this->builder()
58			->columns($this->getColumns())
59			->minifiedAjax()
60			->parameters($this->getBuilderParameters());
61			}
62
63			/**
64			* Get columns.
65			*
66			* @return array
67			*/
68			protected function getColumns()
69			{
70			return [
71			'created_at',
72			[ 'name' => 'causer_id', 'data' => 'causer_id', 'title' => 'Actor', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
73			[ 'name' => 'description', 'data' => 'description', 'title' => 'Action', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
74			[ 'name' => 'subject_id', 'data' => 'subject_id', 'title' => 'Subject', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
75			[ 'name' => 'properties', 'data' => 'properties', 'title' => 'Changes', 'render' => null, 'searchable' => true, 'orderable' => false, 'exportable' => true, 'printable' => true, 'footer' => '' ]
76			];
77			}
78
79			/**
80			* Get builder parameters.
81			*
82			* @return array
83			*/
84			protected function getBuilderParameters()
85			{
86			return [
87			'dom' => 'Bfrtip',
88			'order' => [ [ 0, 'desc' ] ],
89			'buttons' => [
90			'export',
91			'print',
92			'reset',
93			'reload',
94			],
95			'paging' => true,
96			'searching' => true,
97			'info' => true,
98			'searchDelay' => 500,
99			];
100			}
101
102			/**
103			* Get filename for export.
104			*
105			* @return string
106			*/
107			protected function filename()
108			{
109			return 'activitylog_' . time();
110			}
111			}
112

uidaho / smartsettia

Pull Request — master (#78)

ActivityLogDataTable::dataTable() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like