AppServiceProvider::boot() - Code Metrics - Inspection of "Minor fixes and changes" - uidaho/smartsettia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#107)

unknown

created 2017-11-09 07:18 UTC

AppServiceProvider::boot() B

↳ Parent: AppServiceProvider

Complexity

Conditions	2
Paths	1

Size

Total Lines	28
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	2.1259

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	28
ccs	13
cts	19
cp	0.6842
rs	8.8571
cc	2
eloc	13
nc	1
nop	0
crap	2.1259

<?php

namespace App\Providers;

use Illuminate\Support\ServiceProvider;
use Illuminate\Support\Facades\Schema;
use Illuminate\Support\Facades\Validator;

class AppServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap any application services.
     *
     * @return void
     */
    public function boot()
    {
        // Fixes incompatibility with MySQL < 5.7.7
        Schema::defaultStringLength(191);

        // Create {{ $view_name }} provider in blade templates
        view()->composer('*', function($view) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $view_name = str_replace('.', '-', $view->getName());
            view()->share('view_name', $view_name);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        });

        Validator::extend('phone', function($attribute, $value, $parameters, $validator) {

            return preg_match('%^(?:(?:\(?(?:00|\+)([1-4]\d\d|[1-9]\d?)\)?)?[\-\.\ \\\/]?)?((?:\(?\d{1,}\)?[\-\.\ \\\/]?){0,})(?:[\-\.\ \\\/]?(?:#|ext\.?|extension|x)[\-\.\ \\\/]?(\d+))?$%i', $value) && strlen($value) >= 10;
        });

        Validator::replacer('phone', function($message, $attribute, $rule, $parameters) {

            return str_replace(':attribute', $attribute, ':attribute is invalid phone number');
        });
    
        //Validator rule for names
        Validator::extend('name', function($attribute, $value, $parameters, $validator) {

            return preg_match('#(^[a-zA-Z0-9])([\w\-\.\' ]*)([\w\-\.\']$)#', $value);
        });
    
        Validator::replacer('name', function($message, $attribute, $rule, $parameters) {

            return str_replace(':attribute', $attribute, ':attribute is invalid you can only use letters, numbers, underscores, dashes, spaces, periods and it must start with a letter or number');
        });
    }

    /**
     * Register any application services.
     *
     * @return void
     */
    public function register()
    {
        //
    }
}


Pull Request — master (#107)

AppServiceProvider::boot() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2
3		namespace App\Providers;
4
5		use Illuminate\Support\ServiceProvider;
6		use Illuminate\Support\Facades\Schema;
7		use Illuminate\Support\Facades\Validator;
8
9		class AppServiceProvider extends ServiceProvider
10		{
11		/**
12		* Bootstrap any application services.
13		*
14		* @return void
15		*/
16	5	public function boot()
17		{
18		// Fixes incompatibility with MySQL < 5.7.7
19	5	Schema::defaultStringLength(191);
20
21		// Create {{ $view_name }} provider in blade templates
22	5	view()->composer('*', function($view) {
		0 ignored issues – show Bug introduced 2017-08-19 20:52 UTC by Report Bug Copy Issue Report The method `composer` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23		$view_name = str_replace('.', '-', $view->getName());
24		view()->share('view_name', $view_name);
		0 ignored issues – show Bug introduced 2017-08-19 20:52 UTC by Report Bug Copy Issue Report The method `share` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
25	5	});
26
27	5	Validator::extend('phone', function($attribute, $value, $parameters, $validator) {
		0 ignored issues – show Unused Code introduced 2017-09-11 05:30 UTC by Report Bug Copy Issue Report The parameter `$parameters` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-09-11 05:30 UTC by Report Bug Copy Issue Report The parameter `$validator` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
28		return preg_match('%^(?:(?:\(?(?:00\|\+)([1-4]\d\d\|[1-9]\d?)\)?)?[\-\.\ \\\/]?)?((?:\(?\d{1,}\)?[\-\.\ \\\/]?){0,})(?:[\-\.\ \\\/]?(?:#\|ext\.?\|extension\|x)[\-\.\ \\\/]?(\d+))?$%i', $value) && strlen($value) >= 10;
29	5	});
30
31	5	Validator::replacer('phone', function($message, $attribute, $rule, $parameters) {
		0 ignored issues – show Unused Code introduced 2017-09-11 05:30 UTC by Report Bug Copy Issue Report The parameter `$rule` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-09-11 05:30 UTC by Report Bug Copy Issue Report The parameter `$parameters` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
32		return str_replace(':attribute', $attribute, ':attribute is invalid phone number');
33	5	});
34
35		//Validator rule for names
36	5	Validator::extend('name', function($attribute, $value, $parameters, $validator) {
		0 ignored issues – show Unused Code introduced 2017-11-09 08:05 UTC by Report Bug Copy Issue Report The parameter `$parameters` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-11-09 08:05 UTC by Report Bug Copy Issue Report The parameter `$validator` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
37		return preg_match('#(^[a-zA-Z0-9])([\w\-\.\' ]*)([\w\-\.\']$)#', $value);
38	5	});
39
40	5	Validator::replacer('name', function($message, $attribute, $rule, $parameters) {
		0 ignored issues – show Unused Code introduced 2017-11-09 08:05 UTC by Report Bug Copy Issue Report The parameter `$rule` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-11-09 08:05 UTC by Report Bug Copy Issue Report The parameter `$parameters` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
41		return str_replace(':attribute', $attribute, ':attribute is invalid you can only use letters, numbers, underscores, dashes, spaces, periods and it must start with a letter or number');
42	5	});
43	5	}
44
45		/**
46		* Register any application services.
47		*
48		* @return void
49		*/
50	5	public function register()
51		{
52		//
53	5	}
54		}
55

uidaho / smartsettia

Pull Request — master (#107)

AppServiceProvider::boot() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like