App\Http\Controllers\SensorDataController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	109
Duplicated Lines	20.18 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	4	1
A	create()	0	4	1
A	store()	12	12	1
A	show()	0	6	1
A	edit()	0	6	1
A	update()	10	10	1
A	destroy()	0	6	1

<?php 

namespace App\Http\Controllers;

use App\SensorData;
use App\DataTables\SensorDataDataTable;
use Illuminate\Http\Request;

class SensorDataController extends Controller 
{
    /**
    * Create a new controller instance.
    *
    * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

    */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
    * Display a listing of the resource.
    *
    * @param SensorDataDataTable $dataTable
    * @return Response
    */
    public function index(SensorDataDataTable $dataTable)
    {
        return $dataTable->render('sensordata.index');
    }

    /**
    * Show the form for creating a new resource.
    *
    * @return Response
    */
    public function create()
    {
        return view('sensordata.create');
    }

    /**
    * Store a newly created resource in storage.
    *
    * @return Response
    */
    public function store()
    {
        request()->validate([
            'sensor_id' => 'required|integer|exists:sensors,id',
            'value' => 'required|string|max:190'
        ]);

        $query = SensorData::create($request->all());

The variable $request does not exist. Did you forget to declare it?

        return redirect()->route('sensordata.show', $query->id)
            ->with('success', 'SensorData created successfully');
    }

    /**
    * Display the specified resource.
    *
    * @param  Request  $request
    * @param  int  $id
    * @return Response
    */
    public function show(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $sensordata = SensorData::findOrFail($id);

        return view('sensordata.show', [ 'sensordata' => $sensordata ]);
    }

    /**
    * Show the form for editing the specified resource.
    *
    * @param  int  $id
    * @return Response
    */
    public function edit(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        $sensordata = SensorData::findOrFail($id);
        
        return view('sensordata.edit', [ 'sensordata' => $sensordata ]);
    }

    /**
    * Update the specified resource in storage.
    *
    * @param  int  $id
    * @return Response
    */
    public function update($id)
    {
        request()->validate([
            'sensor_id' => 'required|integer|exists:sensors,id',
            'value' => 'required|string|max:190'
        ]);
        $query = SensorData::findOrFail($id)->update($request->all());

The variable $request does not exist. Did you forget to declare it?

$query is not used, you could remove the assignment.

        return redirect()->route('sensordata.show', $id)

$id is of type integer, but the function expects a array.

            ->with('success', 'SensorData updated successfully');    
    }

    /**
    * Remove the specified resource from storage.
    *
    * @param  int  $id
    * @return Response
    */
    public function destroy($id)
    {
        SensorData::find($id)->delete();
        return redirect()->route('sensordata.index')
            ->with('success','SensorData deleted successfully');
    }

}