Completed
Pull Request — master (#88)
by Brandon
02:30
created
app/Http/Controllers/ImageController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         if (Storage::disk('private')->exists('deviceimage/'.$device_id)) {
31 31
             $image = Image::make(Storage::disk('private')->get('deviceimage/'.$device_id));
32 32
         } else {
33
-            $image = Image::make(public_path() . '/img/video_not_found.jpg');
33
+            $image = Image::make(public_path().'/img/video_not_found.jpg');
34 34
         }
35 35
         
36 36
         return $image->response();
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      */
46 46
     public function store($device_id, $binaryData)
47 47
     {
48
-        $storagePath = storage_path('app/private/deviceimage/') . $device_id;
48
+        $storagePath = storage_path('app/private/deviceimage/').$device_id;
49 49
         $image = Image::make($binaryData);
50 50
         $image->save($storagePath, 75);
51 51
     }
Please login to merge, or discard this patch.
app/Site.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      *
25 25
      * @var array
26 26
      */
27
-    protected static $ignoreChangedAttributes = ['updated_at'];
27
+    protected static $ignoreChangedAttributes = [ 'updated_at' ];
28 28
     
29 29
     /**
30 30
      * The attributes to log in the Activity Log
Please login to merge, or discard this patch.
app/Location.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      *
25 25
      * @var array
26 26
      */
27
-    protected static $ignoreChangedAttributes = ['updated_at'];
27
+    protected static $ignoreChangedAttributes = [ 'updated_at' ];
28 28
     
29 29
     /**
30 30
      * The attributes to log in the Activity Log
Please login to merge, or discard this patch.
app/Deviceimage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      *
25 25
      * @var array
26 26
      */
27
-    protected static $ignoreChangedAttributes = ['updated_at'];
27
+    protected static $ignoreChangedAttributes = [ 'updated_at' ];
28 28
     
29 29
     /**
30 30
      * The attributes to log in the Activity Log
Please login to merge, or discard this patch.
app/Http/Controllers/DashboardController.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
             //Get the first device that doesn't have a null location_id
36 36
             $device = Device::publicDashData()->where('location_id', '!=', 'null')->orderBy('id', 'ASC')->first();
37 37
         }
38
-        catch(ModelNotFoundException $e)
38
+        catch (ModelNotFoundException $e)
39 39
         {
40 40
             //If no device is found then redirect the user to the home page and display a message about registering a device
41 41
             return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
     
49 49
         $data = $this->dashData($site, $location, $device);
50 50
         
51
-        return view('dashboard.index', [ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
51
+        return view('dashboard.index', [ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
52 52
     }
53 53
     
54 54
     /**
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
                 //Get the first site and if no sites exist throw an error
93 93
                 $site = Site::select('id', 'name')->firstOrFail();
94 94
             }
95
-            catch(ModelNotFoundException $e)
95
+            catch (ModelNotFoundException $e)
96 96
             {
97 97
                 //If no device is found then redirect the user to the home page and display a message about registering a device
98 98
                 return redirect('home')->with('no_devices', 'To access the dashboard page there must be at least one registered device assigned to a location.');
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
         
119 119
         $data = $this->dashData($site, $location, $device);
120 120
         
121
-        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
121
+        return response()->json([ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
122 122
     }
123 123
     
124 124
     /**
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         
139 139
         $data = $this->dashData($site, $location, $device);
140 140
         
141
-        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
141
+        return response()->json([ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
142 142
     }
143 143
     
144 144
     /**
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         
159 159
         $data = $this->dashData($site, $location, $device);
160 160
         
161
-        return response()->json([ 'active_device' => $data[0], 'devices' => $data[1], 'locations' => $data[2], 'sites' => $data[3] ]);
161
+        return response()->json([ 'active_device' => $data[ 0 ], 'devices' => $data[ 1 ], 'locations' => $data[ 2 ], 'sites' => $data[ 3 ] ]);
162 162
     }
163 163
     
164 164
     /**
@@ -180,9 +180,9 @@  discard block
 block discarded – undo
180 180
         //Get all the devices that belong to the given location ordered by name
181 181
         $devices = $location->devices()->publicDashData()->orderBy('name', 'ASC')->get();
182 182
         
183
-        $active_device = collect([$device, $location, $site]);
183
+        $active_device = collect([ $device, $location, $site ]);
184 184
         
185
-        return collect([$active_device, $devices, $locations, $sites]);
185
+        return collect([ $active_device, $devices, $locations, $sites ]);
186 186
     }
187 187
     
188 188
     /**
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
             return response()->json("Device is currently in use.", 403);
204 204
         
205 205
         //1 = open, 2 = close, 3 = lock
206
-        switch($request->command)
206
+        switch ($request->command)
207 207
         {
208 208
             case 1:
209 209
                 $device->cover_command = 'open';
@@ -239,12 +239,12 @@  discard block
 block discarded – undo
239 239
             
240 240
             //Check if the current time is during the open schedule or not
241 241
             if (($time_now > $open_time) && ($time_now < $close_time))
242
-                $command =  'open';
242
+                $command = 'open';
243 243
             else
244
-                $command =  'close';
244
+                $command = 'close';
245 245
         }
246 246
         else
247
-            $command =  'lock';
247
+            $command = 'lock';
248 248
         
249 249
         return $command;
250 250
     }
Please login to merge, or discard this patch.
app/User.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,6 +143,6 @@
 block discarded – undo
143 143
     public function roleString()
144 144
     {
145 145
         $role_en = array(0 => "Registered", 1 => "User", 2 => "Manager", 3 => "Admin");
146
-        return $role_en[ $this->role ] . ' (' . $this->role . ')';
146
+        return $role_en[ $this->role ].' ('.$this->role.')';
147 147
     }
148 148
 }
Please login to merge, or discard this patch.
app/Http/Controllers/ApiController.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */    
22 22
     public function index()
23 23
     {
24
-        return response()->json(['data' => 'SmartSettia API - Bad request type.'], 400);
24
+        return response()->json([ 'data' => 'SmartSettia API - Bad request type.' ], 400);
25 25
     }
26 26
 
27 27
     /**
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         //event(new Registered(true));
91 91
         
92 92
         // Return the new device info including the token.
93
-        return response()->json(['data' => $device->toArray()], 201);
93
+        return response()->json([ 'data' => $device->toArray() ], 201);
94 94
     }
95 95
     
96 96
     /**
@@ -127,13 +127,13 @@  discard block
 block discarded – undo
127 127
         foreach ($sensor_datas as $sensor_data) {
128 128
             $sensor = Sensor::firstOrCreate([
129 129
                 "device_id" => $device->id,
130
-                "name" => $sensor_data['name'], 
131
-                "type" => $sensor_data['type']
130
+                "name" => $sensor_data[ 'name' ], 
131
+                "type" => $sensor_data[ 'type' ]
132 132
             ]);
133 133
             
134 134
             SensorData::create([
135 135
                 "sensor_id" => $sensor->id,
136
-                "value" => $sensor_data['value']
136
+                "value" => $sensor_data[ 'value' ]
137 137
             ]);
138 138
         }
139 139
         
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
         //event(new Registered(true));
144 144
         
145 145
         // Return the new device info including the token.
146
-        return response()->json(['data' => $device->toArray()], 201);
146
+        return response()->json([ 'data' => $device->toArray() ], 201);
147 147
     }
148 148
     
149 149
     /**
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
         
163 163
         // If challenge string doesnt match then send 401 unauthorized.
164 164
         if ($request->input('challenge') != env('API_CHALLENGE', 'temppass')) {
165
-            return response()->json(['data' => 'Bad challenge.'], 401);
165
+            return response()->json([ 'data' => 'Bad challenge.' ], 401);
166 166
         }
167 167
         
168 168
         // If the uuid already exists then just send them the record.
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
                 'uuid' => $device->uuid,
173 173
                 'id' => $device->id,
174 174
                 'token' => $device->token,
175
-            ]], 200);
175
+            ] ], 200);
176 176
         }
177 177
         
178 178
         // Create the new device.
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
             'uuid' => $device->uuid,
197 197
             'id' => $device->id,
198 198
             'token' => $device->token,
199
-        ]], 201);
199
+        ] ], 201);
200 200
     }
201 201
     
202 202
     /**
@@ -217,21 +217,21 @@  discard block
 block discarded – undo
217 217
         $device = Device::getDeviceByUUID($request->input('uuid'));
218 218
         
219 219
         // Save the image to disk.
220
-        $path = $request->file('image')->storeAs('deviceimage', $device['id'], 'private');
220
+        $path = $request->file('image')->storeAs('deviceimage', $device[ 'id' ], 'private');
221 221
         
222 222
         // Update the url for the image.
223 223
         $deviceimage = Deviceimage::updateOrCreate(
224
-            ['device_id' => $device['id']],
225
-            ['url' => $path]
224
+            [ 'device_id' => $device[ 'id' ] ],
225
+            [ 'url' => $path ]
226 226
         );
227 227
         
228 228
         // Force the updated_at timestamp to update as the url may not change.
229 229
         $deviceimage->touch();
230 230
         
231 231
         return response()->json([ 'data' => [ 
232
-            'id' => $deviceimage['id'],
232
+            'id' => $deviceimage[ 'id' ],
233 233
             'url' => $path,
234
-        ]], 201);
234
+        ] ], 201);
235 235
     }
236 236
 }
237 237
 
Please login to merge, or discard this patch.
app/DataTables/ActivityLogDataTable.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,16 +16,16 @@  discard block
 block discarded – undo
16 16
     public function dataTable($query)
17 17
     {
18 18
         return datatables($query)
19
-            ->editColumn('causer_id', function ($activity) {
20
-                return ($activity->causer_id ? '<a href="/' . ($activity->causer_type == "App\User" ? 'user' : 'device') . '/' . $activity->causer_id . '">' . ($activity->causer->name ?? '') . '</a>' : 'App');
19
+            ->editColumn('causer_id', function($activity) {
20
+                return ($activity->causer_id ? '<a href="/'.($activity->causer_type == "App\User" ? 'user' : 'device').'/'.$activity->causer_id.'">'.($activity->causer->name ?? '').'</a>' : 'App');
21 21
             })
22
-            ->editColumn('subject_id', function ($activity) {
23
-                return ($activity->subject_id ? '<a href="/' . ($activity->subject_type == "App\User" ? 'user' : 'device') . '/' . $activity->subject_id . '">' . ($activity->subject->name ?? '') . '</a>' : 'App');
22
+            ->editColumn('subject_id', function($activity) {
23
+                return ($activity->subject_id ? '<a href="/'.($activity->subject_type == "App\User" ? 'user' : 'device').'/'.$activity->subject_id.'">'.($activity->subject->name ?? '').'</a>' : 'App');
24 24
             })
25
-            ->editColumn('properties', function ($activity) {
25
+            ->editColumn('properties', function($activity) {
26 26
                 return $activity->properties;
27 27
             })
28
-            ->rawColumns(['causer_id', 'subject_id', 'properties']);
28
+            ->rawColumns([ 'causer_id', 'subject_id', 'properties' ]);
29 29
     }
30 30
 
31 31
     /**
@@ -98,6 +98,6 @@  discard block
 block discarded – undo
98 98
      */
99 99
     protected function filename()
100 100
     {
101
-        return 'activitylog_' . time();
101
+        return 'activitylog_'.time();
102 102
     }
103 103
 }
Please login to merge, or discard this patch.
app/DataTables/DevicesDataTable.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -16,17 +16,17 @@
 block discarded – undo
16 16
     public function dataTable($query)
17 17
     {
18 18
         return datatables($query)
19
-            ->editColumn('name', function ($device) {
20
-                return '<a href="' . route('device.show', $device->id) . '">' . $device->name . '</a>';
19
+            ->editColumn('name', function($device) {
20
+                return '<a href="'.route('device.show', $device->id).'">'.$device->name.'</a>';
21 21
             })
22
-            ->addColumn('location', function ($device) {
22
+            ->addColumn('location', function($device) {
23 23
                 return ($device->location->name ?? 'null');
24 24
             })
25
-            ->addColumn('site', function ($device) {
25
+            ->addColumn('site', function($device) {
26 26
                 return ($device->location->site->name ?? 'null');
27 27
             })
28
-            ->addColumn('rates', function ($device) {
29
-                return $device->update_rate . '/' . $device->image_rate .'/' . $device->sensor_rate;
28
+            ->addColumn('rates', function($device) {
29
+                return $device->update_rate.'/'.$device->image_rate.'/'.$device->sensor_rate;
30 30
             })
31 31
             ->blacklist([ 'location', 'site', 'rates' ])
32 32
             ->rawColumns([ 'name' ]);
Please login to merge, or discard this patch.