App\DataTables\ActivityLogDataTable

Complexity

Total Complexity

17

Size/Duplication

Total Lines	133
Duplicated Lines	15.04 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	1	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	dataTable()	0	28	4
B	getRouteFromType()	0	20	8
A	query()	0	5	1
A	html()	0	7	1
A	getColumns()	0	10	1
A	getBuilderParameters()	20	20	1
A	filename()	0	4	1

<?php

namespace App\DataTables;

use App\User;
use Illuminate\Support\Facades\Auth;
use Yajra\DataTables\Services\DataTable;
use Spatie\Activitylog\Models\Activity;

class ActivityLogDataTable extends DataTable
{
    /**
     * Build DataTable class.
     *
     * @return \Yajra\DataTables\DataTableAbstract
     */
    public function dataTable($query)
    {
        return datatables($query)
            ->editColumn('causer_id', function ($activity) {
                if ($activity->causer_id) {
                    return '<a href="' . route($this->getRouteFromType($activity->causer_type), $activity->causer_id) . '">' . $activity->causer->name ?? '' . '</a>';
                } else {
                    return '';
                }
            })
            ->editColumn('subject_id', function ($activity) {
                if ($activity->subject_id) {
                    return '<a href="' . route($this->getRouteFromType($activity->subject_type), $activity->subject_id) . '">' . $activity->subject->name ?? '' . '</a>';
                } else {
                    return '';
                }
            })
            ->editColumn('properties', function ($activity) {
                return $activity->properties;
            })
            ->editColumn('created_at', function ($activity) {
                if ($activity->created_at->diffInDays() > 0)
                    return $activity->created_at->setTimezone(Auth::user()->timezone)->format('M d, Y h:i a');

Accessing timezone on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                else
                    return $activity->created_at->diffForHumans();
            })
            ->rawColumns(['causer_id', 'subject_id', 'properties']);
    }
    
    public function getRouteFromType($type) {
        switch ($type) {
            case "App\Device":

case statements should be defined using a colon.

                return 'device.show';
            case "App\Deviceimage":

case statements should be defined using a colon.

                return 'image.device';
            case "App\Location":

case statements should be defined using a colon.

                return 'location.show';
            case "App\Sensor":

case statements should be defined using a colon.

                return 'sensor.show';
            case "App\SensorData":
                return 'sensordata.show';
            case "App\Site":
                return 'site.show';
            case "App\User":
                return 'user.show';
            default:
                return 'logs';
        }
    }

    /**
     * Get query source of dataTable.
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function query()
    {
        $query = Activity::query();
        return $this->applyScopes($query);

The expression $this->applyScopes($query); of type Illuminate\Database\Query\Builder|Illuminate\Database\Eloquent\Builder adds the type Illuminate\Database\Query\Builder to the return on line 75 which is incompatible with the return type documented by App\DataTables\ActivityLogDataTable::query of type Illuminate\Database\Eloquent\Builder.

    }

    /**
     * Optional method if you want to use html builder.
     *
     * @return \Yajra\DataTables\Html\Builder
     */
    public function html()
    {
        return $this->builder()
            ->columns($this->getColumns())
            ->minifiedAjax()
            ->parameters($this->getBuilderParameters());
    }

    /**
     * Get columns.
     *
     * @return array
     */
    protected function getColumns()
    {
        return [
            'created_at',
            [ 'name' => 'causer_id', 'data' => 'causer_id', 'title' => 'Actor', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'description', 'data' => 'description', 'title' => 'Action', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'subject_id', 'data' => 'subject_id', 'title' => 'Subject', 'render' => null, 'searchable' => true, 'orderable' => true, 'exportable' => true, 'printable' => true, 'footer' => '' ],
            [ 'name' => 'properties', 'data' => 'properties', 'title' => 'Changes', 'render' => null, 'searchable' => true, 'orderable' => false, 'exportable' => true, 'printable' => true, 'footer' => '' ]
        ];
    }
    
    /**
     * Get builder parameters.
     *
     * @return array
     */
    protected function getBuilderParameters()
    {
        return [
            'dom'     => 'Bfrtip',
            'order'   => [ [ 0, 'desc' ] ],
            'buttons' => [
                [ 'extend' => 'collection', 'text' => '<i class="fa fa-file-excel-o"></i> Export', 'buttons' => [ 
                    [ 'extend' => 'csv', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
                    [ 'extend' => 'excel', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
                ] ],
                [ 'extend' => 'print', 'exportOptions' => [ 'modifier' => [ 'search' => true ] ] ],
                'reset',
                'reload',
            ],
            'paging' => true,
            'searching' => true,
            'info' => true,
            'searchDelay' => 500,
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'activitylog_' . time();
    }
}