App\Http\Controllers\SiteController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	122
Duplicated Lines	21.31 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	index()	0	5	1

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\DataTables\SiteDataTable;
use App\Site;

class SiteController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
    }
    
    /**
     * Display a listing of the resource.
     *
     * @param  SiteDataTable   $dataTable
     * @return Response

The type App\Http\Controllers\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index(SiteDataTable $dataTable)
    {
        $this->authorize('index', Site::class);
        
        return $dataTable->render('site.index');

The expression return $dataTable->render('site.index') also could return the type Illuminate\View\View|callable which is incompatible with the documented return type App\Http\Controllers\Response.

    }
    
    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $this->authorize('create', Site::class);
        
        return view('site.create');

The expression return view('site.create') returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }
    
    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request)
    {
        $this->authorize('store', Site::class);
        
        $request->validate([
            'name' => 'required|min:2|max:190|name|unique:sites,name',
        ]);
        
        $site = Site::create([ 'name' => $request->name ]);
        
        return redirect()->route('site.show', $site->id)

$site->id of type integer is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

            ->with('success', 'Site created successfully');
    }
    
    /**
     * Display the specified resource.
     *
     * @param  string  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $this->authorize('show', Site::class);
        
        $site = Site::findOrFail($id);
        $locations = $site->locations()->orderBy('name', 'ASC')->paginate(15);
    
        if (\Request::ajax())
            return response()->json(['site' => $site, 'locations' => $locations]);

The expression return response()->json(array('site' => $site, 'locations' => $locations)) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        else
            return view('site.show', [ 'site' => $site, 'locations' => $locations ]);

The expression return view('site.show', array('site' => $site, 'locations' => $locations)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }
    
    /**
     * Show the form for editing the specified resource.
     *
     * @param  string  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $this->authorize('edit', Site::class);
        
        $site = Site::findOrFail($id);
        return view('site.edit', [ 'site' => $site ]);

The expression return view('site.edit', array('site' => $site)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }
    
    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  Site  $site
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, Site $site)
    {
        $this->authorize('update', Site::class);
        
        $request->validate([
            'name' => 'required|min:2|max:190|name|unique:sites,name,'.$site->id,
        ]);
        
        $site->update([ 'name' => $request->name ]);
        
        return redirect()->route('site.show', $site->id)

$site->id of type integer is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

            ->with('success', 'Site updated successfully');
    }
    
    /**
     * Remove the specified resource from storage.
     *
     * @param  string  $id
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy($id)
    {
        $this->authorize('destroy', Site::class);
        
        Site::findOrFail($id)->delete();
        return redirect()->route('site.index')
            ->with('success', 'Site deleted successfully');
    }
}