App\Http\Controllers\SensorController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	131
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	1	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	create()	0	5	1
A	show()	0	16	1
A	index()	0	5	1
A	store()	0	14	1
A	update()	0	12	1
A	edit()	0	6	1
A	destroy()	0	7	1

<?php 

namespace App\Http\Controllers;

use App\Sensor;
use App\DataTables\SensorDataTable;
use Illuminate\Http\Request;
use Charts;

The type Charts was not found. Maybe you did not declare it correctly or list all dependencies?

class SensorController extends Controller 
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @param  SensorDataTable   $dataTable
     * @return Response

The type App\Http\Controllers\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index(SensorDataTable $dataTable)
    {
        $this->authorize('index', Sensor::class);
        
        return $dataTable->render('sensor.index');

The expression return $dataTable->render('sensor.index') also could return the type Illuminate\View\View|callable which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return Response
     */
    public function create()
    {
        $this->authorize('create', Sensor::class);
    
        return view('sensor.create');

The expression return view('sensor.create') returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Request $request
     * @return Response
     */
    public function store(Request $request)
    {
        $this->authorize('store', Sensor::class);
    
        request()->validate([
            'device_id' => 'required|integer|digits_between:1,10|exists:devices,id',
            'name' => 'required|min:2|max:190|name',
            'type' => 'required|max:190|type_name'
        ]);

        $sensor = Sensor::create($request->all());

        return redirect()->route('sensor.show', $sensor->id)

$sensor->id of type integer is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

The expression return redirect()->route('sensor.show', $sensor->id)->with('success', 'Sensor created successfully') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

            ->with('success', 'Sensor created successfully');
    }

    /**
     * Display the specified resource.
     *
     * @param  String  $id
     * @return Response
     */
    public function show($id)
    {
        $this->authorize('show', Sensor::class);
    
        $sensor = Sensor::findOrFail($id);
        $latestData = $sensor->latestData;

The property latestData does not seem to exist on App\Sensor. Are you sure there is no database migration missing?

        $sensordata = $sensor->data()->orderBy('id', 'desc')->paginate(25);
        $chartSensorData = $sensordata->reverse();
        $chart = Charts::create('line', 'highcharts')
            ->title($sensor->name)
            ->elementLabel($sensor->type)
            ->labels($chartSensorData->pluck('created_at'))
            ->values($chartSensorData->pluck('value'))
            ->responsive(true);

        return view('sensor.show', [ 'sensor' => $sensor, 'latestData' => $latestData, 'sensordata' => $sensordata, 'chart' => $chart ]);

The expression return view('sensor.show', array('sensor' => $sensor, 'latestData' => $latestData, 'sensordata' => $sensordata, 'chart' => $chart)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  String  $id
     * @return Response
     */
    public function edit($id)
    {
        $this->authorize('edit', Sensor::class);
    
        $sensor = Sensor::findOrFail($id);
        return view('sensor.edit', [ 'sensor' => $sensor ]);

The expression return view('sensor.edit', array('sensor' => $sensor)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Request  $request
     * @param  String  $id
     * @return Response
     */
    public function update(Request $request, $id)
    {
        $this->authorize('update', Sensor::class);
    
        request()->validate([
            'device_id' => 'required|integer|digits_between:1,10|exists:devices,id',
            'name' => 'required|min:2|max:190|name',
            'type' => 'required|max:190|type_name'
        ]);
        $query = Sensor::findOrFail($id)->update($request->all());

The assignment to $query is dead and can be removed.

        return redirect()->route('sensor.show', $id)

The expression return redirect()->route('sensor.show', $id)->with('success', 'Sensor updated successfully') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

$id of type string is incompatible with the type array expected by parameter $parameters of Illuminate\Routing\Redirector::route().

            ->with('success', 'Sensor updated successfully');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  String  $id
     * @return Response
     */
    public function destroy($id)
    {
        $this->authorize('destroy', Sensor::class);
    
        Sensor::findOrFail($id)->delete();
        return redirect()->route('sensor.index')

The expression return redirect()->route('sensor.index')->with('success', 'Sensor deleted successfully') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

            ->with('success', 'Sensor deleted successfully');
    }

}