Webcook\Cms\SecurityBundle\Controller\RoleController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	putRolesResourcesAction()	0	21	3
A	getValueFromArray()	0	8	2

<?php

/**
 * This file is part of Webcook security bundle.
 *
 * See LICENSE file in the root of the bundle. Webcook
 */

namespace Webcook\Cms\SecurityBundle\Controller;

use Webcook\Cms\CoreBundle\Base\BaseRestController;
use Webcook\Cms\SecurityBundle\Entity\Role;
use Webcook\Cms\SecurityBundle\Entity\Resource;
use Webcook\Cms\SecurityBundle\Entity\RoleResource;
use Webcook\Cms\SecurityBundle\Form\Type\RoleType;
use Webcook\Cms\SecurityBundle\Form\Type\ResourcesType;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Nelmio\ApiDocBundle\Annotation\ApiDoc;
use Webcook\Cms\SecurityBundle\Authorization\Voter\WebcookCmsVoter;
use FOS\RestBundle\Controller\Annotations\Get;
use FOS\RestBundle\Controller\Annotations\Post;
use FOS\RestBundle\Controller\Annotations\Put;
use FOS\RestBundle\Controller\Annotations\Delete;
use Doctrine\DBAL\LockMode;

/**
 * REST api controller - role management.
 */
class RoleController extends BaseRestController
{
    /**
     * Update resources of the role.
     *
     * @param int $id Id of the desired role.
     *
     * @ApiDoc(
     *  description="Update existing role.",
     *  input="Webcook\Cms\SecurityBundle\Form\Type\ResourcesType"
     * )
     * @Put(options={"i18n"=false})
     */
    public function putRolesResourcesAction($id)

The parameter $id is not used and could be removed.

    {
        $parameters = $this->getPutParameters('roleResources');

        foreach ($parameters as $roleResourceArray) {
            $roleResource = $this->getEntityManager()->getRepository('Webcook\Cms\SecurityBundle\Entity\RoleResource')->find($roleResourceArray['id']);

Are you sure the assignment to $roleResource is correct as $this->getEntityManager()->getRepository('Webcook\\Cms\\SecurityBundle\\Entity\\RoleResource')->find($roleResourceArray['id']) (which targets Doctrine\Common\Persistence\ObjectRepository::find()) seems to always return null.

            if ($roleResource) {
                $roleResource->setView($this->getValueFromArray($roleResourceArray, 'view'));
                $roleResource->setInsert($this->getValueFromArray($roleResourceArray, 'insert'));
                $roleResource->setEdit($this->getValueFromArray($roleResourceArray, 'edit'));
                $roleResource->setDelete($this->getValueFromArray($roleResourceArray, 'delete'));
            }
        }

        $this->getEntityManager()->flush();

        $view = $this->view(null, 204);

        return $this->handleView($view);
    }

    /**
     * Get specific value from an array.
     *
     * @param array  $array array of values
     * @param string $key   key of desired value
     *
     * @return bool|string Value or false.
     */
    private function getValueFromArray($array, $key)
    {
        if (array_key_exists($key, $array)) {
            return filter_var($array[$key], FILTER_VALIDATE_BOOLEAN);
        }

        return false;
    }
}