MenuContentProviderSettingsController::getMenuSettingsAction() - Code Metrics - Inspection of "Added api platform, rewrite." - ufik/webcookcms-core-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c81fc8...bdce41 )

by Tomáš

created 2017-02-09 18:11 UTC

MenuContentProviderSettingsController::getMenuSettingsAction() B

↳ Parent: Project

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	2
cts	2
cp	1
rs	8.9197
c	0
b	0
f	0
cc	4
eloc	13
nc	4
nop	2
crap	4

<?php

/**
 * This file is part of Webcook common bundle.
 *
 * See LICENSE file in the root of the bundle. Webcook
 */

namespace Webcook\Cms\CoreBundle\Controller;

use Webcook\Cms\CoreBundle\Base\BaseRestController;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Webcook\Cms\CoreBundle\Entity\MenuContentProviderSettings;
use Webcook\Cms\CoreBundle\Form\Type\MenuContentProviderSettingsType;
use Nelmio\ApiDocBundle\Annotation\ApiDoc;
use Webcook\Cms\SecurityBundle\Authorization\Voter\WebcookCmsVoter;
use FOS\RestBundle\Controller\Annotations\Get;
use FOS\RestBundle\Controller\Annotations\Post;
use FOS\RestBundle\Controller\Annotations\Put;
use FOS\RestBundle\Controller\Annotations\Delete;
use Doctrine\DBAL\LockMode;

/**
 * Page controller.
 */
class MenuContentProviderSettingsController extends BaseRestController
{
    /**
     * Get single settings for menu content provider.
     *
     * @param int $id Id of the desired settings.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function getMenuSettingsAction($pageId = null, $sectionId = null)
    {
        $settings = null;
        if (!is_null($pageId) && !is_null($sectionId)) {
            $page     = $this->getEntityManager()->getRepository('Webcook\Cms\CoreBundle\Entity\Page')->find($pageId);
            $section  = $this->getEntityManager()->getRepository('Webcook\Cms\CoreBundle\Entity\Section')->find($sectionId);

            $settings = $this->getEntityManager()->getRepository('Webcook\Cms\CoreBundle\Entity\MenuContentProviderSettings')->findOneBy(array(
                'page'    => $page,
                'section' => $section
            ));
        }
        

        if (is_null($settings)) {
            $view = $this->getViewWithMessage(null, 404, 'Settings not found.');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } else {
            $view = $this->view($settings, 200);
        }

        return $this->handleView($view);
    }
}


1		<?php
2
3		/**
4		* This file is part of Webcook common bundle.
5		*
6		* See LICENSE file in the root of the bundle. Webcook
7		*/
8
9		namespace Webcook\Cms\CoreBundle\Controller;
10
11		use Webcook\Cms\CoreBundle\Base\BaseRestController;
12		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
13		use Webcook\Cms\CoreBundle\Entity\MenuContentProviderSettings;
14		use Webcook\Cms\CoreBundle\Form\Type\MenuContentProviderSettingsType;
15		use Nelmio\ApiDocBundle\Annotation\ApiDoc;
16		use Webcook\Cms\SecurityBundle\Authorization\Voter\WebcookCmsVoter;
17		use FOS\RestBundle\Controller\Annotations\Get;
18		use FOS\RestBundle\Controller\Annotations\Post;
19		use FOS\RestBundle\Controller\Annotations\Put;
20		use FOS\RestBundle\Controller\Annotations\Delete;
21		use Doctrine\DBAL\LockMode;
22
23		/**
24		* Page controller.
25		*/
26		class MenuContentProviderSettingsController extends BaseRestController
27		{
28		/**
29		* Get single settings for menu content provider.
30		*
31		* @param int $id Id of the desired settings.
		0 ignored issues – show Bug introduced 2016-12-30 17:03 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
32		*/
33		public function getMenuSettingsAction($pageId = null, $sectionId = null)
34		{
35		$settings = null;
36		if (!is_null($pageId) && !is_null($sectionId)) {
37		$page = $this->getEntityManager()->getRepository('Webcook\Cms\CoreBundle\Entity\Page')->find($pageId);
38		$section = $this->getEntityManager()->getRepository('Webcook\Cms\CoreBundle\Entity\Section')->find($sectionId);
39
40		$settings = $this->getEntityManager()->getRepository('Webcook\Cms\CoreBundle\Entity\MenuContentProviderSettings')->findOneBy(array(
41		'page' => $page,
42	2	'section' => $section
43		));
44	2	}
45
46
47		if (is_null($settings)) {
48		$view = $this->getViewWithMessage(null, 404, 'Settings not found.');
		0 ignored issues – show Documentation introduced 2016-12-30 17:03 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49		} else {
50		$view = $this->view($settings, 200);
51		}
52
53		return $this->handleView($view);
54		}
55		}
56

ufik / webcookcms-core-bundle

Push — master ( c81fc8...bdce41 )

MenuContentProviderSettingsController::getMenuSettingsAction() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like