Issues in UsersPresenter.php (master) - Issues in master - ufik/WebCMS2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (362)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

AdminModule/presenters/UsersPresenter.php (19 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AdminModule;

use Nette\Application\UI;
use Nette\Mail;

/**
 * Users presenter.
 * @author Tomáš Voslař <tomas.voslar at webcook.cz>
 * @package WebCMS2
 */
class UsersPresenter extends \AdminModule\BasePresenter
{
    /* @var User */
    private $userEntity;

    /* @var Role */
    private $role;

    protected function beforeRender()
    {
        parent::beforeRender();
    }

    protected function startup()
    {
        parent::startup();
    }

    public function renderDefault()
    {
        $this->reloadContent();
    }

    protected function createComponentUserForm()
    {
        $roles = $this->em->getRepository("WebCMS\Entity\Role")->findAll();
        $tmp = array();
        foreach ($roles as $r) {
            $tmp[$r->getId()] = $r->getName();
        }
        $roles = $tmp;

        if ($this->getUser()->getRoles()[0] !== 'superadmin') {
            unset($roles[1]);
        }

        $infoEmail = $this->settings->get('Info email', \WebCMS\Settings::SECTION_BASIC)->getValue();
        $disableEmail = empty($infoEmail);

        $form = $this->createForm();
        $form->addText('username', 'Username')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addSelect('role', 'Role')->setTranslator(null)->setItems($roles)->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('name', 'Name')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('email', 'Email')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addPassword('password', 'Password')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addCheckbox('sendInfoEmail', 'Send info email with password')->setDisabled($disableEmail);
        $form->addSubmit('save', 'Save')->setAttribute('class', 'btn btn-success');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $form->onSuccess[] = callback($this, 'userEntityFormSubmitted');

        if ($this->userEntity) {
            $form->setDefaults($this->userEntity->toArray());
        }

        return $form;
    }

    protected function createComponentGrid($name)
    {
        $grid = $this->createGrid($this, $name, "User", null, array(
            'id <> 1',
        ));

        $grid->addColumnText('username', 'Name')->setSortable();

        $grid->addActionHref("updateUser", 'Edit')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-primary', 'ajax'), 'data-toggle' => 'modal', 'data-target' => '#myModal', 'data-remote' => 'false'));
        $grid->addActionHref("deleteUser", 'Delete')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-danger'), 'data-confirm' => 'Are you sure you want to delete the item?'));

        return $grid;
    }

    public function actionUpdateUser($id)
    {
        if ($id) {
            $this->userEntity = $this->em->find("WebCMS\Entity\User", $id);
        } else {
            $this->userEntity = new \WebCMS\Entity\User();

        }
    }

    public function actionDeleteUser($id)
    {
        $this->userEntity = $this->em->find("WebCMS\Entity\User", $id);
        $this->em->remove($this->userEntity);
        $this->em->flush();

        $this->flashMessage('User has been removed.', 'success');

        $this->forward('Users:default');
    }

    public function renderUpdateUser($id)

    {
        $this->reloadModalContent();

        $this->template->userEntity = $this->userEntity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function userEntityFormSubmitted(UI\Form $form)
    {
        $values = $form->getValues();

        $role = $this->em->find("WebCMS\Entity\Role", $values->role);
        $password = $this->getContext()->authenticator->calculateHash($values->password);

        $this->userEntity->setName($values->name);
        $this->userEntity->setEmail($values->email);

        if (array_key_exists('sendInfoEmail', $values) && $values->sendInfoEmail) {
            // send mail with new password
            $email = new Mail\Message();
            $email->setFrom($this->settings->get('Info email', \WebCMS\Settings::SECTION_BASIC)->getValue());
            $email->addTo($this->userEntity->getEmail());
            $email->setSubject($this->settings->get('User new password subject', \WebCMS\Settings::SECTION_EMAIL)->getValue(false));
            $email->setHtmlBody($this->settings->get('User new password', \WebCMS\Settings::SECTION_EMAIL)->getValue(false, array(
                '[PASSWORD]',
                '[LOGIN]',
                ), array(
                $values->password,
                $values->username,
            )));

            $email->send();

            $this->flashMessage('Info email with new password has been sent.', 'success');
        }

        if (!empty($values->password)) {
            $this->userEntity->setPassword($password);
        }

        $this->userEntity->setUsername($values->username);
        $this->userEntity->setRole($role);

        $this->em->persist($this->userEntity);
        $this->em->flush();

        $this->flashMessage('User has been updated.', 'success');

        $this->forward('Users:default');
    }

    /* ROLES */

    public function renderRoles()
    {
        $this->reloadContent();
    }

    public function actionUpdateRole($id)
    {
        if ($id) {
            $this->role = $this->em->find("WebCMS\Entity\Role", $id);
        } else {
            $this->role = new \WebCMS\Entity\Role();

        }
    }

    public function actionDeleteRole($id)

    {
        $this->role = $this->em->find("WebCMS\Entity\Role", $id);
        $this->em->remove($this->role);
        $this->em->flush();

        $this->flashMessage('Role has been removed.', 'success');

        $this->forward('Users:roles');
    }

    public function renderUpdateRole($id)

    {
        $this->reloadContent();

        $this->template->role = $this->role;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected function createComponentRoleForm()
    {
        $resources = \WebCMS\Helpers\SystemHelper::getResources();

        $pages = $this->em->getRepository('WebCMS\Entity\Page')->findAll();

        foreach ($pages as $page) {
            if ($page->getParent() != NULL) {
                $module = $this->createObject($page->getModuleName());

                foreach ($module->getPresenters() as $presenter) {
                    $suffix = $presenter['name'] == $page->getModuleName() ? '' : ' '.$presenter['name'];

                    $key = 'admin:'.$page->getModuleName().':'.$presenter['name'].$page->getId();
                    $resources[$key] = $page->getTitle().$suffix.' ('.$page->getLanguage()->getName().')';
                }
            }
        }

        $form = $this->createForm();
        $form->addCheckbox('automaticEnable', 'Automatic enable');
        $form->addText('name', 'Name')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $c = 0;
        foreach ($resources as $key => $r) {
            if (strpos('$r', ':') !== FALSE) {
                $form->addCheckbox('res'.str_replace(':', '', $key), $r)->setAttribute('class', 'check');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            } else {
                $form->addCheckbox('res'.str_replace(':', '', $key), $r)->setTranslator(null)->setAttribute('class', 'check');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }

            $c++;
        }

        // defaults setting
        $new = $this->role->getName();
        if (!empty($new)) {
            $defaultsPermissions = array();
            foreach ($this->role->getPermissions() as $key => $per) {
                $defaultsPermissions['res'.str_replace(':', '', $per->getResource())] = $per->getRead();
            }

            $form->setDefaults($this->role->toArray() + $defaultsPermissions);
        }

        $form->onSuccess[] = callback($this, 'roleFormSubmitted');
        $form->addSubmit('save', 'Save')->setAttribute('class', 'btn btn-success');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $form;
    }

    protected function createComponentRolesGrid($name)
    {
        $grid = $this->createGrid($this, $name, "Role", null, array(
            'id <> 1',
        ));

        $grid->addColumnText('name', 'Name')->setSortable();

        $grid->addActionHref("updateRole", 'Edit')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-primary', 'ajax')));
        $grid->addActionHref("deleteRole", 'Delete')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-danger'), 'data-confirm' => 'Are you sure you want to delete the item?'));

        return $grid;
    }

    public function roleFormSubmitted(UI\Form $form)
    {
        $values = $form->getValues();

        if (empty($values->name)) {
            $this->flashMessage('Please fill in at least the name.', 'danger');
            $this->forward('this');
        }

        $this->role->setName($values->name);
        $this->role->setAutomaticEnable($values->automaticEnable);

        if (!$this->role->getId()) {
            $this->em->persist($this->role);
        }

        $this->flashMessage('Role has been added.', 'success');

        // delete permissions
        $permissions = $this->role->getPermissions();
        foreach ($permissions as $per) {
            $this->em->remove($per);
        }

        // save permissions
        $perArray = array();
        foreach ($values as $key => $val) {
            if (strpos($key, 'res') !== FALSE) {
                $permission = new \WebCMS\Entity\Permission();

                $pageId = filter_var($key, FILTER_SANITIZE_NUMBER_INT);
                $page = $this->em->getRepository('WebCMS\Entity\Page')->find($pageId);

                $resource = 'admin:'.str_replace('resadmin', '', $key);
                $permission->setResource($resource);
                $permission->setPage($page);
                $permission->setRead($val);

                $perArray[] = $permission;
            }
        }

        $this->role->setPermissions($perArray);

        $this->em->flush(); // persist all changes

        $this->forward('Users:roles');
    }
}


Issues (362)

Security Analysis not enabled

AdminModule/presenters/UsersPresenter.php (19 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1		<?php
2
3		namespace AdminModule;
4
5		use Nette\Application\UI;
6		use Nette\Mail;
7
8		/**
9		* Users presenter.
10		* @author Tomáš Voslař <tomas.voslar at webcook.cz>
11		* @package WebCMS2
12		*/
13		class UsersPresenter extends \AdminModule\BasePresenter
14		{
15		/* @var User */
16		private $userEntity;
17
18		/* @var Role */
19		private $role;
20
21	4	protected function beforeRender()
22		{
23	4	parent::beforeRender();
24	4	}
25
26	4	protected function startup()
27		{
28	4	parent::startup();
29	4	}
30
31	1	public function renderDefault()
32		{
33	1	$this->reloadContent();
34	1	}
35
36	4	protected function createComponentUserForm()
37		{
38	1	$roles = $this->em->getRepository("WebCMS\Entity\Role")->findAll();
39	1	$tmp = array();
40	1	foreach ($roles as $r) {

ufik / WebCMS2

Issues (362)

Security Analysis not enabled

AdminModule/presenters/UsersPresenter.php (19 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like