Issues in HomepagePresenter.php (master) - Issues in master - ufik/WebCMS2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (362)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

AdminModule/presenters/HomepagePresenter.php (20 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AdminModule;

use Dubture\Monolog\Reader\LogReader;
use Nette\Utils\Finder;

/**
 * Admin presenter.
 *
 * @author Tomáš Voslař <tomas.voslar at webcook.cz>
 * @package WebCMS2
 */
class HomepagePresenter extends \AdminModule\BasePresenter
{
    /* @var logContent */
    private $logContent;

    /* @var exceptions */
    private $exceptions;

    protected function beforeRender()
    {
        parent::beforeRender();

        $this->reloadContent();

        $parameters = $this->getContext()->getParameters();

        $logFile = $parameters['tempDir'].'/../log/webcms.log';
        $reader = new LogReader($logFile, 2);

        $logs = array();
        foreach ($reader as $log) {
            if (!empty($log) && $log['level'] === 'INFO') {
                $logs[] = $log;
            }
        }

        $exceptions = array();
        if ($this->getUser()->getRoles()[0] === 'superadmin') {
            foreach (Finder::findFiles('exception-*.html')->in(APP_DIR . '/../log') as $key => $file) {
                $filename = $file->getFileName();
                $parsed = explode('-', $filename);
                $date = $parsed[1] . '-' . $parsed[2] . '-' . $parsed[3] . ' ' . $parsed[4] . ':' . $parsed[5] . ':' . $parsed[6];
                $exceptions[] = array('id' => substr($parsed[7], 0, -5), 'date' => $date, 'filename' => $filename);
            }

            $this->template->showLogger = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $this->template->showLogger = false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }   

        if (count($exceptions) > 0) {
            $this->exceptions = $exceptions;

            $this->template->showExceptions = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $this->template->showExceptions = false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        // favourite links
        $user = $this->em->getRepository('WebCMS\Entity\User')->find($this->getUser()->getId());
        $favourites = $this->em->getRepository('WebCMS\Entity\Favourites')->findBy(array(
            'user' => $user,
        ));

        $this->template->logReader = array_reverse($logs);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->links = $favourites;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected function startup()
    {
        parent::startup();
    }

    public function createComponentExceptionLogsGrid()
    {
        $grid = new \Grido\Grid($this, 'exceptionLogsGrid');
        $grid->AddColumnDate('date', 'Date')
            ->setDateFormat(\Grido\Components\Columns\Date::FORMAT_DATETIME)
            ->setSortable();
        $grid->AddColumnText('filename', 'Filename');

        $grid->setModel($this->exceptions);

        $grid->addActionHref("showExceptionLog", 'Show')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-primary'), 'target' => '_blank'));
        $grid->addActionHref("deleteExceptionLog", 'Delete')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-danger'), 'data-confirm' => 'Are you sure you want to delete this item?'));

        $grid->setDefaultSort(array('date' => 'DESC'));
        $grid->setRememberState(true);
        $grid->setDefaultPerPage(10);
        $grid->setTranslator($this->translator);
        $grid->setFilterRenderType(\Grido\Components\Filters\Filter::RENDER_INNER);

        return $grid;
    }

    public function renderShowExceptionLog($id)

    {
        $this->template->content = $this->logContent;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function actionShowExceptionLog($id)
    {
        foreach (Finder::findFiles('exception-*' . $id . '.html')->in(APP_DIR . '/../log') as $key => $file) {
            $contents = file_get_contents(APP_DIR . '/../log/' . $file->getFileName());
        }

        if (!empty($contents)) {
            $this->logContent = $contents;         

        } else {
            $this->logContent = 'Unable to show the exception log - file not found.';

        }      
    }

    public function actionDeleteExceptionLog($id)
    {
        foreach (Finder::findFiles('exception-*' . $id . '.html')->in(APP_DIR . '/../log') as $key => $file) {

            $filename = $file->getFileName();
        }

        if (!empty($filename)) {
            unlink(APP_DIR . '/../log/' . $filename);
            $this->flashMessage('Exception log has been deleted.', 'success');
        } else {
            $this->flashMessage('Unable to delete exception log - file not found.', 'error');
        }

        $this->forward('default');
    }

    public function actionDeleteAllExceptionLogs()
    {
        if ($this->getUser()->getRoles()[0] === 'superadmin') {
            foreach (Finder::findFiles('exception-*.html')->in(APP_DIR . '/../log') as $key => $file) {

                $filename = $file->getFileName();
                unlink(APP_DIR . '/../log/' . $filename);
            }
        }
        $this->flashMessage('All exception logs have been deleted.', 'success');
        $this->forward('default');
    }
}


1			<?php
2
3			namespace AdminModule;
4
5			use Dubture\Monolog\Reader\LogReader;
6			use Nette\Utils\Finder;
7
8			/**
9			* Admin presenter.
10			*
11			* @author Tomáš Voslař <tomas.voslar at webcook.cz>
12			* @package WebCMS2
13			*/
14			class HomepagePresenter extends \AdminModule\BasePresenter
15			{
16			/* @var logContent */
17			private $logContent;
18
19			/* @var exceptions */
20			private $exceptions;
21
22	1		protected function beforeRender()
23			{
24	1		parent::beforeRender();
25
26	1		$this->reloadContent();
27
28	1		$parameters = $this->getContext()->getParameters();
29
30	1		$logFile = $parameters['tempDir'].'/../log/webcms.log';
31	1		$reader = new LogReader($logFile, 2);
32
33	1		$logs = array();
34	1		foreach ($reader as $log) {
35	1		if (!empty($log) && $log['level'] === 'INFO') {
36	1		$logs[] = $log;
37	1		}
38	1		}
39
40	1		$exceptions = array();
41	1		if ($this->getUser()->getRoles()[0] === 'superadmin') {
42	1		foreach (Finder::findFiles('exception-*.html')->in(APP_DIR . '/../log') as $key => $file) {
43			$filename = $file->getFileName();
44			$parsed = explode('-', $filename);
45			$date = $parsed[1] . '-' . $parsed[2] . '-' . $parsed[3] . ' ' . $parsed[4] . ':' . $parsed[5] . ':' . $parsed[6];
46			$exceptions[] = array('id' => substr($parsed[7], 0, -5), 'date' => $date, 'filename' => $filename);
47	1		}
48	1
49			$this->template->showLogger = true;
			0 ignored issues – show Documentation introduced 2016-02-09 20:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-02-09 20:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `showLogger` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
50	1		} else {
51			$this->template->showLogger = false;
			0 ignored issues – show Documentation introduced 2016-02-09 20:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-02-09 20:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `showLogger` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
52			}
53
54	1		if (count($exceptions) > 0) {
55			$this->exceptions = $exceptions;
			0 ignored issues – show Documentation Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$exceptions` of type `array` is incompatible with the declared type `object<AdminModule\exceptions>` of property `$exceptions`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
56			$this->template->showExceptions = true;
			0 ignored issues – show Documentation introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `showExceptions` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
57			} else {
58	1		$this->template->showExceptions = false;
			0 ignored issues – show Documentation introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `showExceptions` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
59	1		}
60	1
61	1		// favourite links
62			$user = $this->em->getRepository('WebCMS\Entity\User')->find($this->getUser()->getId());
63	1		$favourites = $this->em->getRepository('WebCMS\Entity\Favourites')->findBy(array(
64	1		'user' => $user,
65	1		));
66
67	1		$this->template->logReader = array_reverse($logs);
			0 ignored issues – show Documentation introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `logReader` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
68			$this->template->links = $favourites;
			0 ignored issues – show Documentation introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `links` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
69	1		}
70	1
71			protected function startup()
72	1		{
73			parent::startup();
74			}
75	1
76			public function createComponentExceptionLogsGrid()
77			{
78	1		$grid = new \Grido\Grid($this, 'exceptionLogsGrid');
79			$grid->AddColumnDate('date', 'Date')
80	1		->setDateFormat(\Grido\Components\Columns\Date::FORMAT_DATETIME)
81			->setSortable();
82	1		$grid->AddColumnText('filename', 'Filename');
83	1
84			$grid->setModel($this->exceptions);
85	1
86	1		$grid->addActionHref("showExceptionLog", 'Show')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-primary'), 'target' => '_blank'));
87			$grid->addActionHref("deleteExceptionLog", 'Delete')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-danger'), 'data-confirm' => 'Are you sure you want to delete this item?'));
88
89			$grid->setDefaultSort(array('date' => 'DESC'));
90			$grid->setRememberState(true);
91			$grid->setDefaultPerPage(10);
92			$grid->setTranslator($this->translator);
93			$grid->setFilterRenderType(\Grido\Components\Filters\Filter::RENDER_INNER);
94
95			return $grid;
96			}
97
98			public function renderShowExceptionLog($id)
			0 ignored issues – show Unused Code introduced 2018-01-08 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
99			{
100			$this->template->content = $this->logContent;
			0 ignored issues – show Documentation introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `content` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
101			}
102
103			public function actionShowExceptionLog($id)
104			{
105			foreach (Finder::findFiles('exception-*' . $id . '.html')->in(APP_DIR . '/../log') as $key => $file) {
106			$contents = file_get_contents(APP_DIR . '/../log/' . $file->getFileName());
107			}
108
109			if (!empty($contents)) {
110			$this->logContent = $contents;
			0 ignored issues – show Documentation Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$contents` of type `string` is incompatible with the declared type `object<AdminModule\logContent>` of property `$logContent`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
111			} else {
112			$this->logContent = 'Unable to show the exception log - file not found.';
			0 ignored issues – show Documentation Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `'Unable to show the exce... log - file not found.'` of type `string` is incompatible with the declared type `object<AdminModule\logContent>` of property `$logContent`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
113			}
114			}
115
116			public function actionDeleteExceptionLog($id)
117			{
118		View Code Duplication	foreach (Finder::findFiles('exception-*' . $id . '.html')->in(APP_DIR . '/../log') as $key => $file) {
			0 ignored issues – show Duplication introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119			$filename = $file->getFileName();
120			}
121
122			if (!empty($filename)) {
123			unlink(APP_DIR . '/../log/' . $filename);
124			$this->flashMessage('Exception log has been deleted.', 'success');
125			} else {
126			$this->flashMessage('Unable to delete exception log - file not found.', 'error');
127			}
128
129			$this->forward('default');
130			}
131
132			public function actionDeleteAllExceptionLogs()
133			{
134			if ($this->getUser()->getRoles()[0] === 'superadmin') {
135		View Code Duplication	foreach (Finder::findFiles('exception-*.html')->in(APP_DIR . '/../log') as $key => $file) {
			0 ignored issues – show Duplication introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
136			$filename = $file->getFileName();
137			unlink(APP_DIR . '/../log/' . $filename);
138			}
139			}
140			$this->flashMessage('All exception logs have been deleted.', 'success');
141			$this->forward('default');
142			}
143			}
144

ufik / WebCMS2

Issues (362)

Security Analysis not enabled

AdminModule/presenters/HomepagePresenter.php (20 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like