Issues in FilesystemPresenter.php (master) - Issues in master - ufik/WebCMS2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (362)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

AdminModule/presenters/FilesystemPresenter.php (23 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AdminModule;

use Nette\Utils\Finder;

/**
 * Filesystem presenter.
 * @author Tomáš Voslař <tomas.voslar at webcook.cz>
 * @package WebCMS2
 */
class FilesystemPresenter extends \AdminModule\BasePresenter
{
    const DESTINATION_BASE = './upload/';

    private $path;

    /* @var \WebCMS\Helpers\ThumbnailCreator */
    private $thumbnailCreator;

    protected function beforeRender()
    {
        parent::beforeRender();
    }

    protected function startup()
    {
        parent::startup();

        $thumbnails = $this->em->getRepository('WebCMS\Entity\Thumbnail')->findAll();

        $this->thumbnailCreator = new \WebCMS\Helpers\ThumbnailCreator($this->settings, $thumbnails);
    }

    public function actionDefault($path)
    {
        if (!empty($path)) {
            $this->path = self::DESTINATION_BASE.$path.'/';
        } else {
            $this->path = self::DESTINATION_BASE;
        }
    }

    public function renderDefault($path, $dialog, $multiple)
    {
        $finder = new \Nette\Utils\Finder();

        $files = iterator_to_array($finder->findFiles('*')
                ->exclude('.htaccess')
                ->in(realpath($this->path)));
        $directories = iterator_to_array($finder->findDirectories('*')->in(realpath($this->path)));

        $sortedDirs = [];
        foreach ($directories as $name => $directory) {
            $sortedDirs[filemtime($name)] = $directory;
        }
        krsort($sortedDirs);

        $sortedFiles = [];
        foreach ($files as $name => $file) {
            $sortedFiles[filemtime($name)] = $file;
        }
        krsort($sortedFiles);

        if (empty($dialog)) {
            $this->reloadContent();
        } else {
            $this->reloadModalContent();
        }

        $this->path = str_replace(self::DESTINATION_BASE, '', $path).'/';

        $this->template->fsPath = $this->path;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->backLink = $this->createBackLink($this->path);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->files = $sortedFiles;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->directories = $sortedDirs;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->multiple = $multiple;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->maxUploadFileSize = $this->getMaxUploadFileSize();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

        /**
         * @param string $path
         */
        private function createBackLink($path)
        {
            $exploded = explode('/', $path);

            array_pop($exploded);
            array_pop($exploded);

            return implode("/", $exploded);
        }

    public function handleMakeDirectory($name)
    {
        @mkdir($this->path.\Nette\Utils\Strings::webalize($name));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $this->flashMessage('Directory has been created.', 'success');
    }

    public function handleUploadFile($path)

    {
        $files = $this->getRequest()->getFiles();
        $files = $files['file'];

        foreach ($files as $file) {
            $this->uploadSingleFile($file);
        }

        $this->reloadContent();
        $this->flashMessage($this->translation['File has been uploaded']);
        $this->sendPayload();
    }

    private function uploadSingleFile($file)
    {
        $filePath = $this->path.''.$file->getSanitizedName();
        $file->move($filePath);

        $f = new \SplFileInfo($filePath);

        if ($file->isImage()) {
            $this->thumbnailCreator->createThumbnails($f->getBasename(), str_replace($f->getBasename(), '', $filePath));
        }
    }

    public function handleDeleteFile($pathToRemove)
    {
        $pathToRemove = self::DESTINATION_BASE.$pathToRemove;
        if (is_file($pathToRemove)) {
            // delete all thumbnails if this file is image
            try {
                if (getimagesize($pathToRemove)) {
                    $image = \Nette\Image::fromFile($pathToRemove);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                    $thumbs = $this->em->getRepository('WebCMS\Entity\Thumbnail')->findAll();
                    foreach ($thumbs as $t) {
                        $file = pathinfo($pathToRemove);
                        $filename = $file['filename'].'.'.$file['extension'];

                // $this->path contains symlinked path, that is not the right way @see handleRegenerateThumbnails() function for the fix
                $toRemove = str_replace('upload', 'thumbnails', $pathToRemove);
                        $toRemove = str_replace($filename, $t->getKey().$filename, $toRemove);

                        unlink($toRemove);
                    }
                }
            } catch (UnknownImageFileException $exc) {

                // image is not file, so there is nothing to do
            }

            unlink($pathToRemove);
        }

        if (is_dir($pathToRemove)) {
            \WebCMS\Helpers\SystemHelper::rrmdir($pathToRemove);
            \WebCMS\Helpers\SystemHelper::rrmdir(str_replace('upload', 'thumbnails', $pathToRemove));
        }

        $this->flashMessage('File has been removed.', 'success');

        $this->forward('this');
    }

    public function actionDownloadFile($path)
    {
        $file = pathinfo($path);
        $filename = $file['filename'].'.'.$file['extension'];

        $finfo = finfo_open(FILEINFO_MIME_TYPE); // return mime type ala mimetype extension

        $path = self::DESTINATION_BASE.$path;
        $mimeType = finfo_file($finfo, $path);

        $this->sendResponse(new \Nette\Application\Responses\FileResponse($path, $filename, $mimeType));
    }

    public function actionFilesDialog($path)
    {
        if (!empty($path)) {
            $this->path = $path.'/';
        } else {
            $this->path = realpath(self::DESTINATION_BASE).'/';
        }
    }

    public function renderFilesDialog()
    {
        $finder = new \Nette\Utils\Finder();

        $template = $this->createTemplate();
        $template->setFile($this->template->basePathModule.'AdminModule/templates/Filesystem/filesDialog.latte');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $files = iterator_to_array($finder->findFiles('*')
                ->exclude('.htaccess')
                ->in($this->path));
        $directories = iterator_to_array($finder->findDirectories('*')->in($this->path));

        $sortedDirs = [];
        foreach ($directories as $name => $directory) {
            $sortedDirs[filemtime($name)] = $directory;
        }
        krsort($sortedDirs);

        $sortedFiles = [];
        foreach ($files as $name => $file) {
            $sortedFiles[filemtime($name)] = $file;
        }
        
        $sortedFilesWithPath = [];
        foreach ($sortedFiles as $file) {
            $sortedFilesWithPath[$file->getPathname()] = $file;
        }
        
        $template->files = $sortedFilesWithPath;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $template->directories = $sortedDirs;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $template->setTranslator($this->translator);
        $template->registerHelperLoader('\WebCMS\Helpers\SystemHelper::loader');
        $template->backLink = strpos($this->createBackLink($this->path), self::DESTINATION_BASE) === false ? realpath(self::DESTINATION_BASE) : $this->createBackLink($this->path);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $template->render();

        $this->terminate();
    }

    public function handleRegenerateThumbnails()
    {
        set_time_limit(0);

        \WebCMS\Helpers\SystemHelper::rrmdir('thumbnails', true);

        $timeStart = time();

        foreach (Finder::findFiles('*.jpg', '*.jpeg', '*.png', '*.gif')->from('upload') as $key => $file) {
            if (file_exists($key) && @getimagesize($key)) {
                $this->thumbnailCreator->createThumbnails($file->getBasename(), str_replace($file->getBasename(), '', $key));
            }
        }

        $timeOver = time();

        $seconds = $timeOver - $timeStart;

        $hours = floor($seconds / 3600);
        $mins = floor(($seconds - ($hours * 3600)) / 60);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $secs = floor($seconds % 60);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        // TODO log spent time
        $this->flashMessage('Thumbnails has been regenerated by recent settings.', 'success');
        $this->forward('default');
    }

    /**
     * Get the maximal file upload size from the environment variables.
     *
     * @author Taken from the Drupal.org project
     * @license GPL 2
     * @return int
     */
    public function getMaxUploadFileSize()
    {
        static $max_size = -1;

        if ($max_size < 0) {
            // Start with post_max_size.
            $max_size = $this->parseFileSize(ini_get('post_max_size'));

            // If upload_max_size is less, then reduce. Except if upload_max_size is
            // zero, which indicates no limit.
            $upload_max = $this->parseFileSize(ini_get('upload_max_filesize'));

            if ($upload_max > 0 && $upload_max < $max_size) {
                $max_size = $upload_max;
            }
        }
        return $max_size;
    }

    /**
     * Parse file size.
     *
     * @author Taken from the Drupal.org project
     * @license GPL 2
     * @return int
     */
    public function parseFileSize($size)
    {
        $unit = preg_replace('/[^bkmgtpezy]/i', '', $size); // Remove the non-unit characters from the size.
        $size = preg_replace('/[^0-9\.]/', '', $size); // Remove the non-numeric characters from the size.
        if ($unit) {
            // Find the position of the unit in the ordered string which is the power of magnitude to multiply a kilobyte by.
            return round($size * pow(1024, stripos('bkmgtpezy', $unit[0])));
        } else {
            return round($size);
        }
    }

}


Issues (362)

Security Analysis not enabled

AdminModule/presenters/FilesystemPresenter.php (23 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

ufik / WebCMS2

Issues (362)

Security Analysis not enabled

AdminModule/presenters/FilesystemPresenter.php (23 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like