UpdatePresenter::addModuleFormSubmitted() - Code Metrics - Inspection of "added dummy login fe presenter" - ufik/WebCMS2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fb7e4a...39c625 )

unknown

created 2015-12-21 15:01 UTC

UpdatePresenter::addModuleFormSubmitted() A

↳ Parent: UpdatePresenter

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1.5786

Metric	Value
dl	0
loc	17
ccs	2
cts	12
cp	0.1667
rs	9.4286
cc	1
eloc	11
nc	1
nop	1
crap	1.5786

<?php

namespace AdminModule;

/**
 * Description of UpdatePresenter
 *
 * @author Tomáš Voslař <tomas.voslar at webcook.cz>
 */
class UpdatePresenter extends \AdminModule\BasePresenter
{
    protected function beforeRender()
    {
        parent::beforeRender();
    }

    protected function startup()
    {
        parent::startup();
    }

    public function renderDefault()
    {
        $this->reloadContent();

        $packages = \WebCMS\Helpers\SystemHelper::getPackages();

        foreach ($packages as &$package) {
            if ($package['module']) {
                $module = $this->createObject($package['package']);

                $package['registered'] = $this->isRegistered($module->getName());
            }
        }

        $this->template->packages = $packages;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function handleUpdateSystem()
    {
        $installLog = './log/install.log';
        $installErrorLog = './log/install-error.log';

        putenv("COMPOSER_HOME=/usr/bin/.composer");

        exec("cd ../;git pull;composer update -n > $installLog 2> $installErrorLog");

        $successMessage = $this->getMessageFromFile('.'.$installLog);

        if (strpos($successMessage, 'System has been updated.') !== FALSE) {
            $this->flashMessage('System has been udpated.', 'success');
        }

        $errorMessage = $this->getMessageFromFile('.'.$installErrorLog);
        if (!empty($errorMessage)) {
            $this->flashMessage('Error while updating system. Please contact administrator.', 'danger');
        }

        $this->handleCheckUpdates();

        if (!$this->isAjax()) {
            $this->forward('Update:');
        } else {
            $this->invalidateControl('footer');
        }
    }

    /**
     * @param string $file
     */
    private function getMessageFromFile($file)
    {
        if (file_exists($file)) {
            $message = file_get_contents($file);
        } else {
            $message = 'error';
        }

        return $message;
    }

    public function actionClearCache()
    {
        $this->context->cacheStorage->clean(array(\Nette\Caching\Cache::ALL => TRUE));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->flashMessage('Cache has been cleared.', 'success');
        $this->redirect("Update:functions");
    }

    public function handleBackupDatabase()
    {
        $par = $this->context->getParameters();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (!file_exists('./upload/backups')) {
            mkdir('./upload/backups');
        }

        $user = $par['database']['user'];
        $password = $par['database']['password'];
        $database = $par['database']['dbname'];

        exec("mysqldump -u $user -p$password $database > ./upload/backups/db-backup-".time().".sql");

        $this->flashMessage('Backup has been create. You can download this backup in filesystem - backup directory.', 'success');
    }

    // REFACTOR
    public function actionRegister($name)
    {
        $module = $this->createObject($name);

        if (!$this->isRegistered($name)) {
            $exists = $this->em->getRepository('WebCMS\Entity\Module')->findOneBy(array(
            'name' => $module->getName(),
            ));

            if (is_object($exists)) {
                $exists->setActive(true);
            } else {
                $mod = new \WebCMS\Entity\Module();
                $mod->setName($module->getName());
                $mod->setPresenters($module->getPresenters());
                $mod->setActive(true);

                $this->em->persist($mod);
            }

            $this->em->flush();
            $this->copyTemplates($name);
            $this->flashMessage('Module has been registered.', 'success');
        } else {
            $this->flashMessage('Module is already registered.', 'danger');
        }

        $this->forward('default');
    }

    private function copyTemplates($name)
    {
        if (!file_exists('../app/templates/'.$name)) {
            mkdir('../app/templates/'.$name);
        }
        exec('cp -r ../libs/webcms2/'.$name.'/Frontend/templatesDefault/* ../app/templates/'.$name);
    }

    public function actionUnregister($name)
    {
        $module = $this->createObject($name);
        $module = $this->em->getRepository('WebCMS\Entity\Module')->findOneBy(array(
            'name' => $module->getName(),
        ));

        $module->setActive(false);
        $this->em->flush();

        $this->flashMessage('Module has been unregistered from system.', 'success');
        $this->forward('default');
    }

    private function isRegistered($name)

    {
        $exists = $this->em->getRepository('WebCMS\Entity\Module')->findOneBy(array(
            'name' => $name,
        ));

        if (is_object($exists) && $exists->getActive()) {
            return TRUE;
        } else {
            return FALSE;
        }
    }

    public function handleCheckUpdates()
    {
        $client = new \Packagist\Api\Client();

        $packages = \WebCMS\Helpers\SystemHelper::getPackages();

        $needUpdateCount = 0;
        foreach ($packages as &$package) {
            if ($package['vendor'] === 'webcms2') {
                $apiResult = $client->get($package['vendor'].'/'.$package['package']);
                $versions = $apiResult->getVersions();

                $devVersion = $versions[$package['version']];
                if (count($versions) > 1) {
                    $newestVersion = next($versions);
                    $newestVersion = $newestVersion->getVersion();
                    while (strpos($newestVersion, 'dev') !== false) {
                        $newestVersion = next($versions);
                        $newestVersion = $newestVersion->getVersion();
                    }
                } else {
                    $newestVersion = null;
                }

            // development or production version?
            if (strpos($package['version'], 'dev') !== false) {
                if ($package['versionHash'] !== mb_substr($devVersion->getSource()->getReference(), 0, 7)) {
                    $needUpdateCount++;
                }
            } else {
                if ($package['version'] !== $newestVersion) {
                    $needUpdateCount++;
                }
            }
            }
        }

        $nuc = $this->settings->get('needUpdateCount', 'system', 'text');

        $setting = $this->em->find('WebCMS\Entity\Setting', $nuc->getId());
        $setting->setValue($needUpdateCount);

        if ($needUpdateCount > 0) {
            $this->flashMessage('Available new updates.', 'success');
        } else {
            $this->flashMessage('Your system is up to date.', 'success');
        }

        $this->em->flush();

        $this->invalidateControl('header');
    }

    public function handleDeleteModule($name)
    {
        $config = json_decode(file_get_contents('../composer.json'));

        if (!empty($config->require->$name)) {
            unset($config->require->$name);
        }

        file_put_contents('../composer.json', json_encode($config, JSON_PRETTY_PRINT));

        $installLog = './log/install.log';
        $installErrorLog = './log/install-error.log';

        putenv("COMPOSER_HOME=/usr/bin/.composer");
        exec("rm -rf ../app/proxies/*");
        exec("cd ../;composer update $name -n > $installLog 2> $installErrorLog");
        exec("cd ../;composer dumpautoload");
        exec("./libs/webcms2/webcms2/install/install.sh 3");

        $this->forward('default');
    }

    public function actionAddModule()
    {
    }

    public function renderAddModule()
    {
        $this->reloadModalContent();
    }

    public function createComponentAddModuleForm()
    {
        $form = $this->createForm();

        $form->addSelect('module', 'Module', $this->getModulesToInstall())->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('version', 'Module version')->setDefaultValue('0.*')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $form->addSubmit('install', 'Install module');
        $form->onSuccess[] = callback($this, 'addModuleFormSubmitted');

        return $form;
    }

    public function addModuleFormSubmitted($form)
    {
        $values = $form->getValues();

        putenv("COMPOSER_HOME=/usr/bin/.composer");

        $installLog = './log/install.log';
        $installErrorLog = './log/install-error.log';

        $module = $values->module;
        $version = $values->version;
        exec("cd ../;composer require $module $version --no-update > $installLog 2> $installErrorLog");
        exec("cd ../;composer update > $installLog 2> $installErrorLog");
        exec("../libs/webcms2/webcms2/install/install.sh 3; >");

        $this->forward('default');
    }

    private function getModulesToInstall()
    {
        $packages = \WebCMS\Helpers\SystemHelper::getPackages();

        $client = new \Packagist\Api\Client();
        $apiResult = $client->search('webcms2/*');

        $notInstalled = array();
        foreach ($apiResult as $package) {
            if (!array_key_exists($package->getName(), $packages)) {
                $notInstalled[$package->getName()] = $package->getName();
            }
        }

        return $notInstalled;
    }

    public function renderFunctions()
    {
        $this->reloadContent();
    }

    public function renderCreateModule()
    {
        $this->reloadModalContent();
    }

    public function createComponentCreateModuleForm()

    {
        $form = $this->createForm();

        $form->addText('name', 'Name')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('author', 'Author')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('email', 'Author\'s email')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addTextArea('description', 'Description')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $form->addSubmit('install', 'Create new module')->setAttribute('class', 'btn btn-primary');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->onSuccess[] = callback($this, 'createModuleFormSubmitted');

        return $form;
    }

    public function createModuleFormSubmitted($form)
    {
        $values = $form->getValues();

        $name = strtolower(trim($values->name));
        $nameBig = ucfirst($name);
        $author = trim($values->author);
        $email = trim($values->email);
        $description = trim($values->description);

        exec("cd ../libs/webcms2/webcms2/install;./module.sh create $name $nameBig '$author' '$email' '$description' > ../../../../log/install.log 2> ../../../../log/install-error.log");

        $this->flashMessage('Module has been created.', 'success');
        $this->forward('default');
    }

    // render log tab
    public function renderLog()
    {
        $this->reloadContent();

        $this->template->installLog = $this->getLog('../log/install.log');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->installErrorLog = $this->getLog('../log/install-error.log');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->updateLog = $this->getLog('../log/auto-update.log');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->template->errorLog = $this->getLog('../log/error.log');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @param string $path
     */
    private function getLog($path)
    {
        if (file_exists($path)) {
            return nl2br(file_get_contents($path));
        }

        return '';
    }
}


Push — master ( fb7e4a...39c625 )

UpdatePresenter::addModuleFormSubmitted() A

Complexity

Size

Duplication

Code Coverage

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace AdminModule;
4
5		/**
6		* Description of UpdatePresenter
7		*
8		* @author Tomáš Voslař <tomas.voslar at webcook.cz>
9		*/
10		class UpdatePresenter extends \AdminModule\BasePresenter
11		{
12	5	protected function beforeRender()
13		{
14	5	parent::beforeRender();
15	5	}
16
17	6	protected function startup()
18		{
19	6	parent::startup();
20	6	}
21
22	1	public function renderDefault()
23		{
24	1	$this->reloadContent();
25
26	1	$packages = \WebCMS\Helpers\SystemHelper::getPackages();
27
28	1	foreach ($packages as &$package) {
29		if ($package['module']) {
30		$module = $this->createObject($package['package']);
31
32		$package['registered'] = $this->isRegistered($module->getName());
33		}
34	1	}
35
36	1	$this->template->packages = $packages;
		0 ignored issues – show Documentation introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2015-12-12 13:09 UTC by Report Bug Copy Issue Report Accessing `packages` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37	1	}
38
39	5	public function handleUpdateSystem()

ufik / WebCMS2

Push — master ( fb7e4a...39c625 )

UpdatePresenter::addModuleFormSubmitted() A

Complexity

Size

Duplication

Code Coverage

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like