PagesPresenter - Code Metrics - ufik/WebCMS2 - Measure and Improve Code Quality continuously with Scrutinizer

PagesPresenter B
last analyzed 2018-01-08 16:58 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	381
Duplicated Lines	14.7 %

Coupling/Cohesion

Components	1
Dependencies	14

Test Coverage

Coverage

24.6%

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
wmc	43
c	5
b	0
f	0
lcom	1
cbo	14
dl	56
loc	381
ccs	61
cts	248
cp	0.246
rs	8.3157

17 Methods

Rating	Name	Duplication	Size	Complexity
A	createBoxesFromParent()	0	14	2
A	beforeRender()	0	4	1
A	startup()	0	6	1
A	copyPermissions()	0	20	3
A	createComponentPagesGrid()	0	55	3
A	actionUpdatePage()	0	8	2
A	actionDeletePage()	10	10	1
A	renderUpdatePage()	0	6	1
A	renderDefault()	0	4	1
A	renderSorting()	0	20	2
A	actionMove()	0	12	2
A	actionMoveUp()	17	17	3
A	actionMoveDown()	17	17	3
B	createComponentPageForm()	0	54	7
B	pageFormSubmitted()	0	39	4
B	setPageValues()	0	36	4
A	generatePath()	12	12	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like PagesPresenter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use PagesPresenter, and based on these observations, apply Extract Interface, too.

<?php

namespace AdminModule;

use Nette\Application\UI;
use Nette\Utils\Finder;

/**
 * Admin presenter.
 * @author Tomáš Voslař <tomas.voslar at webcook.cz>
 * @package WebCMS2
 */
class PagesPresenter extends \AdminModule\BasePresenter
{
    /* @var Page */

    private $page;

    private $repository;

    protected function beforeRender()
    {
        parent::beforeRender();
    }

    protected function startup()
    {
        parent::startup();

        $this->repository = $this->em->getRepository('WebCMS\Entity\Page');
    }

    protected function createComponentPageForm()
    {
        $repository = $this->em->getRepository('WebCMS\Entity\Page');
        $hierarchy = $repository->getTreeForSelect(array(
            array('by' => 'root', 'dir' => 'ASC'),
            array('by' => 'lft', 'dir' => 'ASC'),
            ), array(
            'language = '.$this->state->language->getId(),
        ));

        $hierarchy = array(0 => $this->translation['Pick parent']) + $hierarchy;

        // loads modules
        $modules = $this->em->getRepository('WebCMS\Entity\Module')->findAll();
        $modulesToSelect = array(NULL => 'No module');
        foreach ($modules as $module) {
            $objectModule = $this->createObject($module->getName());

            foreach ($objectModule->getPresenters() as $presenter) {
                if ($presenter['frontend']) {
                    $modulesToSelect[$module->getId().'-'.$presenter['name']] = $module->getName().' '.$presenter['name'];
                }
            }
        }

        $layouts = array();
        foreach (Finder::findFiles('@*.latte')->in(APP_DIR.'/templates') as $key => $file) {
            $layouts[str_replace(array('@', '.latte'), '', $file->getFileName())] = $file->getFileName();
        }

        $form = $this->createForm();
        $form->addText('title', 'Name')->setAttribute('class', 'form-control')->setRequired();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('redirect', 'Redirect')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('class', 'Menu item class')->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addSelect('module', 'Module')->setTranslator(null)->setItems($modulesToSelect)->setAttribute('class', 'form-control')->setRequired();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addSelect('parent', 'Parent')->setTranslator(null)->setItems($hierarchy)->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addSelect('layout', 'Page layout')->setTranslator(null)->setItems($layouts)->setAttribute('class', 'form-control');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addCheckbox('default', 'Default');
        $form->addCheckbox('visible', 'Show');
        $form->addCheckbox('secured', 'Secured');

        $form->addSubmit('save', 'Save')->setAttribute('class', 'btn btn-success');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $form->onSuccess[] = callback($this, 'pageFormSubmitted');

        if ($this->page) {
            $form->setDefaults($this->page->toArray());
            if (is_object($this->page->getModule())) {
                $form['module']->setDefaultValue($this->page->getModule()->getId().'-'.$this->page->getPresenter());
            }
        }

        return $form;
    }

    public function pageFormSubmitted(UI\Form $form)
    {
        $values = $form->getValues();

        $tmpBoxes = array();
        if ($values->parent) {
            $parent = $this->em->find("WebCMS\Entity\Page", $values->parent);
            // copy boxes
            $tmpBoxes = $parent->getBoxes();
        } else {
            $parent = null;
        }

        $this->setPageValues($values, $parent);

        if (!$this->page->getId()) {
            $this->em->persist($this->page);

            $this->createBoxesFromParent($tmpBoxes);

            $this->em->flush();
            $this->copyPermissions();
        } else {
            $children = $this->page->getChildren();

            foreach ($children as $child) {
                  $this->generatePath($child);
            }
	}

        // persist and generate path
        $this->em->flush();
        $this->generatePath($this->page);
        $this->em->flush();
        $this->generateSitemap();

        $this->flashMessage('Page has been added.', 'success');
        $this->forward('Pages:default');
    }

    /**
     *
     *
     * @param [type] $values [description]

     */
    private function setPageValues($values, $parent)
    {
        if ($values->module) {
            $parse = explode('-', $values->module);
            $module = $this->em->find("WebCMS\Entity\Module", $parse[0]);
            $presenter = $parse[1];
        } else {
            $module = null;
            $presenter = '';
        }

        $this->page->setTitle($values->title);

        if (!empty($values->redirect)) {
            $this->page->setRedirect($values->redirect);
        } else {
            $this->page->setRedirect(null);
        }

        if ($module) {
            $this->page->setModuleName($module->getName());
        } else {
            $this->page->setModuleName('');
        }

        $this->page->setVisible($values->visible);
        $this->page->setDefault($values->default);
        $this->page->setSecured($values->secured);
        $this->page->setParent($parent);
        $this->page->setLanguage($this->state->language);
        $this->page->setModule($module);
        $this->page->setPresenter($presenter);
        $this->page->setPath('tmp value');
        $this->page->setClass($values->class);
        $this->page->setLayout($values->layout);
    }

    /**
     *
     *
     * @param  [type] $boxes [description]

     * @return [type] [description]

     */
    private function createBoxesFromParent($boxes)
    {
        foreach ($boxes as $box) {
            $tmp = new \WebCMS\Entity\Box();
            $tmp->setBox($box->getBox());
            $tmp->setFunction($box->getFunction());
            $tmp->setModuleName($box->getModuleName());
            $tmp->setPresenter($box->getPresenter());
            $tmp->setPageFrom($box->getPageFrom());
            $tmp->setPageTo($this->page);

            $this->em->persist($tmp);
        }
    }

    /**
     *
     *
     * @return [type] [description]

     */
    private function generatePath($page)

    {
        $path = $this->em->getRepository('WebCMS\Entity\Page')->getPath($page);
        $final = array();
        foreach ($path as $p) {
            if ($p->getParent() != NULL) {
                $final[] = $p->getSlug();
            }
        }

        $page->setPath(implode('/', $final));
    }

    /**
     *
     *
     * @return [type] [description]

     */
    private function copyPermissions()
    {
        $roles = $this->em->getRepository('WebCMS\Entity\Role')->findBy(array(
            'automaticEnable' => true,
        ));

        foreach ($roles as $r) {
            $module = $this->createObject($this->page->getModuleName());
            foreach ($module->getPresenters() as $presenter) {
                $permission = new \WebCMS\Entity\Permission();

                $resource = 'admin:'.$this->page->getModuleName().$presenter['name'].$this->page->getId();
                $permission->setResource($resource);
                $permission->setPage($this->page);
                $permission->setRead(true);

                $r->addPermission($permission);
            }
        }
    }

    protected function createComponentPagesGrid($name)
    {
        $parents = $this->em->getRepository('WebCMS\Entity\Page')->findBy(array(
            'parent' => NULL,
            'language' => $this->state->language->getId(),
        ));

        $prnts = array('' => $this->translation['Pick structure']);

        foreach ($parents as $p) {
            $prnts[$p->getId()] = $p->getTitle();
        }

        $grid = $this->createGrid($this, $name, 'Page', array(
            array('by' => 'root', 'dir' => 'ASC'),
            array('by' => 'lft', 'dir' => 'ASC'),
            ), array(
            'language = '.$this->state->language->getId(),
            )
        );

        $grid->addColumnText('title', 'Name')->setCustomRender(function ($item) {
            return str_repeat("-", $item->getLevel()).$item->getTitle();
        });

        $grid->addColumnText('root', 'Structure')->setCustomRender(function ($item) {
            return $item->getParent() ? $item->getParent() : '-';
        });

        $grid->addFilterSelect('root', 'Structure')->getControl()->setTranslator(null)->setItems($prnts);

        $grid->addColumnText('moduleName', 'Module');

        $grid->addColumnText('visible', 'Visible')->setReplacement(array(
            '1' => 'Yes',
            NULL => 'No',
        ));

        $grid->addColumnText('default', 'Default')->setReplacement(array(
            '1' => 'Yes',
            NULL => 'No',
        ));

        $grid->addColumnText('secured', 'Secured')->setReplacement(array(
            '1' => 'Yes',
            NULL => 'No',
        ));

        //$grid->addActionHref("moveUp", "Move up");
        //$grid->addActionHref("moveDown", "Move down");
        $grid->addActionHref("updatePage", 'Edit')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-primary', 'ajax')));
        $grid->addActionHref("deletePage", 'Delete')->getElementPrototype()->addAttributes(array('class' => array('btn', 'btn-danger'), 'data-confirm' => 'Are you sure you want to delete this item?'));

        return $grid;
    }

    public function actionUpdatePage($id)
    {
        if ($id) {
            $this->page = $this->em->find("WebCMS\Entity\Page", $id);
        } else {
            $this->page = new \WebCMS\Entity\Page();

        }
    }

    public function actionDeletePage($id)

    {
        $this->page = $this->em->find("WebCMS\Entity\Page", $id);
        $this->em->remove($this->page);
        $this->em->flush();

        $this->flashMessage('Page has been removed.', 'success');

        $this->forward('Pages:default');
    }

    public function renderUpdatePage($id)

    {
        $this->reloadContent();

        $this->template->page = $this->page;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function renderDefault()
    {
        $this->reloadContent();
    }

    // Sorting
    public function renderSorting($id)

    {
        $this->reloadContent();

        $roots = $this->repository->findBy(array(
            'parent' => NULL,
            'language' => $this->state->language->getId(),
        ));

        $tree = array();
        foreach ($roots as $r) {
            $tmp = array();
            $tmp['title'] = $r->getTitle();
            $tmp['__children'] = $this->repository->childrenHierarchy($r);

            $tree[] = $tmp;
        }

        $this->template->tree = $tree;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function actionMove($id, $oldPosition, $newPosition)
    {
        $step = $newPosition - $oldPosition;

        if ($step > 0) {
            $this->actionMoveDown($id, $step);
        } else {
            $this->actionMoveUp($id, $step * -1);
        }

        $this->forward('Pages:sorting');
    }

    public function actionMoveUp($id, $step = 1)

    {
        $this->page = $this->em->find("WebCMS\Entity\Page", $id);

        if ($this->page->getParent()) {
            $repository = $this->em->getRepository('WebCMS\Entity\Page');
            $repository->moveUp($this->page, $step);

            $this->flashMessage('Page has been moved up.', 'success');
        } else {
            $this->flashMessage('Page has not been moved up, because it is root page.', 'warning');
        }

        if (!$this->isAjax()) {
            $this->forward('Pages:default');
        }
    }

    public function actionMoveDown($id, $step = 1)

    {
        $this->page = $this->em->find("WebCMS\Entity\Page", $id);

        if ($this->page->getParent()) {
            $repository = $this->em->getRepository('WebCMS\Entity\Page');
            $repository->moveDown($this->page, $step);

            $this->flashMessage('Page has been moved down.', 'success');
        } else {
            $this->flashMessage('Page has not been moved up, because it is root page.', 'warning');
        }

        if (!$this->isAjax()) {
            $this->forward('Pages:default');
        }
    }
}


PagesPresenter B
last analyzed 2018-01-08 16:58 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

17 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

1		<?php
2
3		namespace AdminModule;
4
5		use Nette\Application\UI;
6		use Nette\Utils\Finder;
7
8		/**
9		* Admin presenter.
10		* @author Tomáš Voslař <tomas.voslar at webcook.cz>
11		* @package WebCMS2
12		*/
13		class PagesPresenter extends \AdminModule\BasePresenter
14		{
15		/* @var Page */
16
17		private $page;
18
19		private $repository;
20
21	1	protected function beforeRender()
22		{
23	1	parent::beforeRender();
24	1	}
25
26	1	protected function startup()
27		{
28	1	parent::startup();
29
30	1	$this->repository = $this->em->getRepository('WebCMS\Entity\Page');
31	1	}
32
33	1	protected function createComponentPageForm()
34		{
35		$repository = $this->em->getRepository('WebCMS\Entity\Page');
36		$hierarchy = $repository->getTreeForSelect(array(
37		array('by' => 'root', 'dir' => 'ASC'),
38		array('by' => 'lft', 'dir' => 'ASC'),
39		), array(
40		'language = '.$this->state->language->getId(),

ufik / WebCMS2

PagesPresenter B last analyzed 2018-01-08 16:58 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

17 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

PagesPresenter B
last analyzed 2018-01-08 16:58 UTC