CalculatorPresenter::formSubmitted() - Code Metrics - Inspection of "secured version of calculator" - ufik/Investform-module - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 151115...09f22c )

unknown

created 2016-02-01 19:16 UTC

CalculatorPresenter::formSubmitted() B

↳ Parent: CalculatorPresenter

Complexity

Conditions	3
Paths	3

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	1	Features	1

Metric	Value
c	6
b	1
f	1
dl	0
loc	25
rs	8.8571
cc	3
eloc	16
nc	3
nop	1

<?php

/**
 * This file is part of the Investform module for webcms2.
 * Copyright (c) @see LICENSE
 */

namespace FrontendModule\InvestformModule;

use WebCMS\InvestformModule\Common\FutureValueOfAnnuityCalculator;

/**
 * Description of InvestformPresenter
 *
 * @author Tomas Voslar <[email protected]>
 */
class CalculatorPresenter extends BasePresenter
{
	private $id;

	private $fvoa;

	private $year;

	protected function startup() 
    {
		parent::startup();

		foreach(range(200000, 3000000, 100000) as $number) {
			$amountItems[$number] = \WebCMS\Helpers\SystemHelper::price($number);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		}


	}

	protected function beforeRender()
    {
		parent::beforeRender();	
	}
	
	public function createComponentForm()
	{
		$form = $this->createForm('form-submit');

		$form->addSelect('amount', 'Amount', $this->amountItems)
			->setAttribute('placeholder', 'Type investement amount');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addSelect('length', 'Length', array(3 => 'Tříletý', 5 => 'Pětiletý'));
		$form->addText('date', 'Date')->setRequired('Date is mandatory.');

		$form->addHidden('secured');

		$form->addSubmit('calculate', 'Calculate');

		$form->onSuccess[] = callback($this, 'formSubmitted');

		return $form;
	}

	public function formSubmitted($form)
	{
		$values = $form->getValues();

		$from = strtotime($values->date);
		
		if ($values->length == 5) {
			if ($values->secured) {
				$year = 2020;
				$to = strtotime('2020-11-30');
			} else {
				$year = 2019;
				$to = strtotime('2019-11-30');
			}
			
		} else {
			$year = 2017;
			$to = strtotime('2017-10-30');
		}

		$length = ($to - $from) / 60 / 60 / 24 / 365;

		$this->year = $year;
		$this->fvoa = new FutureValueOfAnnuityCalculator($values->amount, $length);
	}

	public function renderDefault($id)
    {	
    	if (!is_object($this->fvoa)) {
    		$this->fvoa = new FutureValueOfAnnuityCalculator(0, 3);
    		$this->year = "";
    	}

    	$this->template->year = $this->year;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    	$this->template->fvoa = $this->fvoa;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    	$this->template->id = $id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}
}


Push — master ( 151115...09f22c )

CalculatorPresenter::formSubmitted() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			* This file is part of the Investform module for webcms2.
5			* Copyright (c) @see LICENSE
6			*/
7
8			namespace FrontendModule\InvestformModule;
9
10			use WebCMS\InvestformModule\Common\FutureValueOfAnnuityCalculator;
11
12			/**
13			* Description of InvestformPresenter
14			*
15			* @author Tomas Voslar <[email protected]>
16			*/
17			class CalculatorPresenter extends BasePresenter
18			{
19			private $id;
20
21			private $fvoa;
22
23			private $year;
24
25			protected function startup()
26			{
27			parent::startup();
28
29			foreach(range(200000, 3000000, 100000) as $number) {
30			$amountItems[$number] = \WebCMS\Helpers\SystemHelper::price($number);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report `$amountItems` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$amountItems = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
31			}
32
33
34			}
35
36			protected function beforeRender()
37			{
38			parent::beforeRender();
39			}
40
41			public function createComponentForm()
42			{
43			$form = $this->createForm('form-submit');
44
45			$form->addSelect('amount', 'Amount', $this->amountItems)
46			->setAttribute('placeholder', 'Type investement amount');
			0 ignored issues – show Documentation introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report `'Type investement amount'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47			$form->addSelect('length', 'Length', array(3 => 'Tříletý', 5 => 'Pětiletý'));
48			$form->addText('date', 'Date')->setRequired('Date is mandatory.');
49
50			$form->addHidden('secured');
51
52			$form->addSubmit('calculate', 'Calculate');
53
54			$form->onSuccess[] = callback($this, 'formSubmitted');
55
56			return $form;
57			}
58
59			public function formSubmitted($form)
60			{
61			$values = $form->getValues();
62
63			$from = strtotime($values->date);
64
65			if ($values->length == 5) {
66			if ($values->secured) {
67			$year = 2020;
68			$to = strtotime('2020-11-30');
69			} else {
70			$year = 2019;
71			$to = strtotime('2019-11-30');
72			}
73
74			} else {
75			$year = 2017;
76			$to = strtotime('2017-10-30');
77			}
78
79			$length = ($to - $from) / 60 / 60 / 24 / 365;
80
81			$this->year = $year;
82			$this->fvoa = new FutureValueOfAnnuityCalculator($values->amount, $length);
83			}
84
85			public function renderDefault($id)
86			{
87			if (!is_object($this->fvoa)) {
88			$this->fvoa = new FutureValueOfAnnuityCalculator(0, 3);
89			$this->year = "";
90			}
91
92			$this->template->year = $this->year;
			0 ignored issues – show Documentation introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report Accessing `year` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
93			$this->template->fvoa = $this->fvoa;
			0 ignored issues – show Documentation introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report Accessing `fvoa` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
94			$this->template->id = $id;
			0 ignored issues – show Documentation introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
95			}
96			}
97

ufik / Investform-module

Push — master ( 151115...09f22c )

CalculatorPresenter::formSubmitted() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like