SettingsPresenter::createComponentSettingsForm() - Code Metrics - ufik/Investform-module - Measure and Improve Code Quality continuously with Scrutinizer

SettingsPresenter::createComponentSettingsForm() A
last analyzed 2017-10-19 10:04 UTC

↳ Parent: SettingsPresenter

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	1
eloc	10
nc	1
nop	0

<?php

/**
 * This file is part of the Investform module for webcms2.
 * Copyright (c) @see LICENSE
 */

namespace AdminModule\InvestformModule;

/**
 * Description of
 * @author Tomáš Voslař <tomas.voslar at webcook.cz>
 */
class SettingsPresenter extends BasePresenter
{	
    protected function startup()
    {
		parent::startup();
    }

    protected function beforeRender()
    {
		parent::beforeRender();	
    }
	
    public function actionDefault($idPage)
    {
    }
	
    public function createComponentSettingsForm()
    {
		$settings = array();

        $settings[] = $this->settings->get('Form Subject', 'InvestformModule', 'text');
        $settings[] = $this->settings->get('Form Email body', 'InvestformModule', 'textarea');
        $settings[] = $this->settings->get('Contract Subject', 'InvestformModule', 'text');
        $settings[] = $this->settings->get('Contract Email body', 'InvestformModule', 'textarea');
        $settings[] = $this->settings->get('Notification subject', 'InvestformModule', 'text');
        $settings[] = $this->settings->get('Notification body', 'InvestformModule', 'textarea');
        $settings[] = $this->settings->get('Businessman password', 'InvestformModule', 'text');

		return $this->createSettingsForm($settings);
    }
	
    public function renderDefault($idPage)
    {
		$this->reloadContent();

		$this->template->idPage = $idPage;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}

1			<?php
2
3			/**
4			* This file is part of the Investform module for webcms2.
5			* Copyright (c) @see LICENSE
6			*/
7
8			namespace AdminModule\InvestformModule;
9
10			/**
11			* Description of
12			* @author Tomáš Voslař <tomas.voslar at webcook.cz>
13			*/
14			class SettingsPresenter extends BasePresenter
15			{
16			protected function startup()
17			{
18			parent::startup();
19			}
20
21			protected function beforeRender()
22			{
23			parent::beforeRender();
24			}
25
26			public function actionDefault($idPage)
27			{
28			}
29
30			public function createComponentSettingsForm()
31			{
32			$settings = array();
33
34			$settings[] = $this->settings->get('Form Subject', 'InvestformModule', 'text');
35			$settings[] = $this->settings->get('Form Email body', 'InvestformModule', 'textarea');
36			$settings[] = $this->settings->get('Contract Subject', 'InvestformModule', 'text');
37			$settings[] = $this->settings->get('Contract Email body', 'InvestformModule', 'textarea');
38			$settings[] = $this->settings->get('Notification subject', 'InvestformModule', 'text');
39			$settings[] = $this->settings->get('Notification body', 'InvestformModule', 'textarea');
40			$settings[] = $this->settings->get('Businessman password', 'InvestformModule', 'text');
41
42			return $this->createSettingsForm($settings);
43			}
44
45			public function renderDefault($idPage)
46			{
47			$this->reloadContent();
48
49			$this->template->idPage = $idPage;
			0 ignored issues – show Documentation introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-01-31 15:16 UTC by Report Bug Copy Issue Report Accessing `idPage` on the interface `Nette\Templating\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
50			}
51			}

ufik / Investform-module

SettingsPresenter::createComponentSettingsForm() A last analyzed 2017-10-19 10:04 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

SettingsPresenter::createComponentSettingsForm() A
last analyzed 2017-10-19 10:04 UTC