FileParser - Code Metrics - uecode/segment-io-php - Measure and Improve Code Quality continuously with Scrutinizer

FileParser A
last analyzed 2017-05-02 19:39 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	3
dl	0
loc	40
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getCommandName()	4	1
A	getDefaultCommands()	8	1
A	getDefinition()	7	1

<?php

namespace SegmentIO\Cli;

use SegmentIO\Cli\Command\FileParserCommand;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Input\InputInterface;

/**
 * FileParser Class
 *
 * @author Keith Kirk <[email protected]>
 */
class FileParser extends Application
{
    /**
     * Gets the name of the command based on input.
     *
     * @param InputInterface $input The input interface
     *
     * @return string The command name
     */
    protected function getCommandName(InputInterface $input)
    {
        return 'parse';
    }

    /**
     * Gets the default commands that should always be available.
     *
     * @return array An array of default Command instances
     */
    protected function getDefaultCommands()
    {
        $defaultCommands = parent::getDefaultCommands();

        $defaultCommands[] = new FileParserCommand();

        return $defaultCommands;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Overridden so that the application doesn't expect the command
     * name to be the first argument.
     */
    public function getDefinition()
    {
        $inputDefinition = parent::getDefinition();
        $inputDefinition->setArguments();

        return $inputDefinition;
    }
}


1			<?php
2
3			namespace SegmentIO\Cli;
4
5			use SegmentIO\Cli\Command\FileParserCommand;
6			use Symfony\Component\Console\Application;
7			use Symfony\Component\Console\Input\InputInterface;
8
9			/**
10			* FileParser Class
11			*
12			* @author Keith Kirk <[email protected]>
13			*/
14			class FileParser extends Application
15			{
16			/**
17			* Gets the name of the command based on input.
18			*
19			* @param InputInterface $input The input interface
20			*
21			* @return string The command name
22			*/
23			protected function getCommandName(InputInterface $input)
24			{
25			return 'parse';
26			}
27
28			/**
29			* Gets the default commands that should always be available.
30			*
31			* @return array An array of default Command instances
32			*/
33			protected function getDefaultCommands()
34			{
35			$defaultCommands = parent::getDefaultCommands();
36
37			$defaultCommands[] = new FileParserCommand();
38
39			return $defaultCommands;
			0 ignored issues – show Best Practice introduced 2016-02-01 16:28 UTC by Report Bug Copy Issue Report The expression `return $defaultCommands;` seems to be an `array`, but some of its elements' types (`SegmentIO\Cli\Command\FileParserCommand`) are incompatible with the return type of the parent method `Symfony\Component\Consol...ion::getDefaultCommands` of type `array<Symfony\Component\...le\Command\ListCommand>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
40			}
41
42			/**
43			* Overridden so that the application doesn't expect the command
44			* name to be the first argument.
45			*/
46			public function getDefinition()
47			{
48			$inputDefinition = parent::getDefinition();
49			$inputDefinition->setArguments();
50
51			return $inputDefinition;
52			}
53			}
54

uecode / segment-io-php

FileParser A last analyzed 2017-05-02 19:39 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

FileParser A
last analyzed 2017-05-02 19:39 UTC