Issues in web.php (master) - Issues in master - uccellolabs/uccello - Measure and Improve Code Quality continuously with Scrutinizer

Issues (652)

routes/web.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

Route::get('logout', '\App\Http\Controllers\Auth\LoginController@logout')->name('logout');

Route::name('uccello.')->group(function() {

    // Adapt params if we use or not multi domains
    if (!uccello()->useMultiDomains()) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $domainParam = '';
        $domainAndModuleParams = '{module}';
    } else {
        $domainParam = '{domain}';
        $domainAndModuleParams = '{domain}/{module}';
    }

    Route::get($domainParam.'/domains/tree/root', 'Core\DomainsTreeController@root')->name('domains.tree.root');
    Route::get($domainParam.'/domains/tree/children', 'Core\DomainsTreeController@children')->name('domains.tree.children');

    // Overrided routes
    Route::get($domainParam.'/role/edit', 'Role\EditController@process')
        ->defaults('module', 'role')
        ->name('role.edit');

    Route::get($domainParam.'/user/list', 'User\ListController@process')
        ->defaults('module', 'user')
        ->name('user.list');

    Route::post($domainParam.'/user/list/content', 'User\ListController@processForContent')
        ->defaults('module', 'user')
        ->name('user.list.content');

    Route::get($domainParam.'/user/edit', 'User\EditController@process')
        ->defaults('module', 'user')
        ->name('user.edit');

    Route::post($domainParam.'/user/import', 'User\ListController@import')
        ->defaults('module', 'user')
        ->name('user.import');

    Route::post($domainParam.'/domain', 'Domain\EditController@save')
        ->defaults('module', 'domain')
        ->name('domain.save');

    Route::post($domainParam.'/group/edit/relation', 'Group\EditController@addRelation')
        ->defaults('module', 'group')
        ->name('group.edit.relation.add');

    Route::get($domainParam.'/group/edit/relation/delete', 'Core\EditController@deleteRelation')
        ->defaults('module', 'group')
        ->name('group.edit.relation.delete');

    // Settings
    Route::get($domainParam.'/settings', 'Settings\SettingsController@dashboard')
        ->defaults('module', 'settings')
        ->name('settings.dashboard');

    Route::get($domainParam.'/settings/module/manager', 'Settings\ModuleManagerController@process')
        ->defaults('module', 'settings')
        ->name('settings.module.manager');

    Route::post($domainParam.'/settings/module/activation', 'Settings\ModuleManagerController@activation')
        ->defaults('module', 'settings')
        ->name('settings.module.activation');

    Route::get($domainParam.'/settings/menu/manager', 'Settings\MenuManagerController@process')
        ->defaults('module', 'settings')
        ->name('settings.menu.manager');

    Route::post($domainParam.'/settings/menu/store', 'Settings\MenuManagerController@store')
        ->defaults('module', 'settings')
        ->name('settings.menu.store');

    Route::post($domainParam.'/settings/menu/reset', 'Settings\MenuManagerController@reset')
        ->defaults('module', 'settings')
        ->name('settings.menu.reset');

    Route::get($domainParam.'/user-account', 'User\AccountController@index')
        ->defaults('module', 'home')
        ->name('user.account');

    Route::post($domainParam.'/user-account/profile', 'User\AccountController@updateProfile')
        ->defaults('module', 'home')
        ->name('user.profile.update');

    Route::post($domainParam.'/user-account/avatar', 'User\AccountController@updateAvatar')
        ->defaults('module', 'home')
        ->name('user.avatar.update');

    Route::post($domainParam.'/user-account/password', 'User\AccountController@updatePassword')
        ->defaults('module', 'home')
        ->name('user.password.update');

    Route::post($domainParam.'/user-account/settings', 'User\AccountController@updateSettings')
        ->defaults('module', 'home')
        ->name('user.settings.update');


    // Default routes
    Route::get($domainParam.'/home', 'Core\IndexController@process')
        ->defaults('module', 'home')
        ->name('home');

    Route::get($domainParam.'/search', 'Core\SearchController@search')->name('search');

    Route::get($domainAndModuleParams, 'Core\IndexController@process')->name('index');
    Route::get($domainAndModuleParams.'/list', 'Core\ListController@process')->name('list');
    Route::post($domainAndModuleParams.'/list/content', 'Core\ListController@processForContent')->name('list.content');
    Route::get($domainAndModuleParams.'/list/autocomplete', 'Core\ListController@processForAutocomplete')->name('autocomplete');
    Route::post($domainAndModuleParams.'/list/filter', 'Core\ListController@saveFilter')->name('list.filter.save');
    Route::post($domainAndModuleParams.'/list/filter/delete', 'Core\ListController@deleteFilter')->name('list.filter.delete');
    Route::post($domainAndModuleParams.'/export', 'Core\ExportController@process')->name('export');
    Route::get($domainAndModuleParams.'/detail', 'Core\DetailController@process')->name('detail');
    Route::get($domainAndModuleParams.'/edit', 'Core\EditController@process')->name('edit');
    Route::post($domainAndModuleParams.'/edit/relation', 'Core\EditController@addRelation')->name('edit.relation.add');
    Route::get($domainAndModuleParams.'/edit/relation/delete', 'Core\EditController@deleteRelation')->name('edit.relation.delete');
    Route::get($domainAndModuleParams.'/popup_edit', 'Core\PopupEditController@process')->name('popup.edit');
    Route::post($domainAndModuleParams.'/popup', 'Core\PopupEditController@save')->name('popup.save');
    Route::get($domainAndModuleParams.'/delete', 'Core\DeleteController@process')->name('delete');
    Route::get($domainAndModuleParams.'/restore', 'Core\EditController@restore')->name('restore');
    Route::post($domainAndModuleParams, 'Core\EditController@save')->name('save');
    Route::get($domainAndModuleParams.'/download', 'Core\DownloadController@process')->name('download');
    Route::get($domainAndModuleParams.'/tree', 'Core\TreeController@process')->name('tree');
    Route::get($domainAndModuleParams.'/tree/root', 'Core\TreeController@root')->name('tree.root');
    Route::get($domainAndModuleParams.'/tree/children', 'Core\TreeController@children')->name('tree.children');
});

1			<?php
2
3			Route::get('logout', '\App\Http\Controllers\Auth\LoginController@logout')->name('logout');
4
5			Route::name('uccello.')->group(function() {
6
7			// Adapt params if we use or not multi domains
8			if (!uccello()->useMultiDomains()) {
			0 ignored issues – show Bug introduced 2018-12-30 00:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `uccello()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
9			$domainParam = '';
10			$domainAndModuleParams = '{module}';
11			} else {
12			$domainParam = '{domain}';
13			$domainAndModuleParams = '{domain}/{module}';
14			}
15
16			Route::get($domainParam.'/domains/tree/root', 'Core\DomainsTreeController@root')->name('domains.tree.root');
17			Route::get($domainParam.'/domains/tree/children', 'Core\DomainsTreeController@children')->name('domains.tree.children');
18
19			// Overrided routes
20			Route::get($domainParam.'/role/edit', 'Role\EditController@process')
21			->defaults('module', 'role')
22			->name('role.edit');
23
24			Route::get($domainParam.'/user/list', 'User\ListController@process')
25			->defaults('module', 'user')
26			->name('user.list');
27
28			Route::post($domainParam.'/user/list/content', 'User\ListController@processForContent')
29			->defaults('module', 'user')
30			->name('user.list.content');
31
32			Route::get($domainParam.'/user/edit', 'User\EditController@process')
33			->defaults('module', 'user')
34			->name('user.edit');
35
36			Route::post($domainParam.'/user/import', 'User\ListController@import')
37			->defaults('module', 'user')
38			->name('user.import');
39
40			Route::post($domainParam.'/domain', 'Domain\EditController@save')
41			->defaults('module', 'domain')
42			->name('domain.save');
43
44			Route::post($domainParam.'/group/edit/relation', 'Group\EditController@addRelation')
45			->defaults('module', 'group')
46			->name('group.edit.relation.add');
47
48			Route::get($domainParam.'/group/edit/relation/delete', 'Core\EditController@deleteRelation')
49			->defaults('module', 'group')
50			->name('group.edit.relation.delete');
51
52			// Settings
53			Route::get($domainParam.'/settings', 'Settings\SettingsController@dashboard')
54			->defaults('module', 'settings')
55			->name('settings.dashboard');
56
57			Route::get($domainParam.'/settings/module/manager', 'Settings\ModuleManagerController@process')
58			->defaults('module', 'settings')
59			->name('settings.module.manager');
60
61			Route::post($domainParam.'/settings/module/activation', 'Settings\ModuleManagerController@activation')
62			->defaults('module', 'settings')
63			->name('settings.module.activation');
64
65			Route::get($domainParam.'/settings/menu/manager', 'Settings\MenuManagerController@process')
66			->defaults('module', 'settings')
67			->name('settings.menu.manager');
68
69			Route::post($domainParam.'/settings/menu/store', 'Settings\MenuManagerController@store')
70			->defaults('module', 'settings')
71			->name('settings.menu.store');
72
73			Route::post($domainParam.'/settings/menu/reset', 'Settings\MenuManagerController@reset')
74			->defaults('module', 'settings')
75			->name('settings.menu.reset');
76
77			Route::get($domainParam.'/user-account', 'User\AccountController@index')
78			->defaults('module', 'home')
79			->name('user.account');
80
81			Route::post($domainParam.'/user-account/profile', 'User\AccountController@updateProfile')
82			->defaults('module', 'home')
83			->name('user.profile.update');
84
85			Route::post($domainParam.'/user-account/avatar', 'User\AccountController@updateAvatar')
86			->defaults('module', 'home')
87			->name('user.avatar.update');
88
89			Route::post($domainParam.'/user-account/password', 'User\AccountController@updatePassword')
90			->defaults('module', 'home')
91			->name('user.password.update');
92
93			Route::post($domainParam.'/user-account/settings', 'User\AccountController@updateSettings')
94			->defaults('module', 'home')
95			->name('user.settings.update');
96
97
98			// Default routes
99			Route::get($domainParam.'/home', 'Core\IndexController@process')
100			->defaults('module', 'home')
101			->name('home');
102
103			Route::get($domainParam.'/search', 'Core\SearchController@search')->name('search');
104
105			Route::get($domainAndModuleParams, 'Core\IndexController@process')->name('index');
106			Route::get($domainAndModuleParams.'/list', 'Core\ListController@process')->name('list');
107			Route::post($domainAndModuleParams.'/list/content', 'Core\ListController@processForContent')->name('list.content');
108			Route::get($domainAndModuleParams.'/list/autocomplete', 'Core\ListController@processForAutocomplete')->name('autocomplete');
109			Route::post($domainAndModuleParams.'/list/filter', 'Core\ListController@saveFilter')->name('list.filter.save');
110			Route::post($domainAndModuleParams.'/list/filter/delete', 'Core\ListController@deleteFilter')->name('list.filter.delete');
111			Route::post($domainAndModuleParams.'/export', 'Core\ExportController@process')->name('export');
112			Route::get($domainAndModuleParams.'/detail', 'Core\DetailController@process')->name('detail');
113			Route::get($domainAndModuleParams.'/edit', 'Core\EditController@process')->name('edit');
114			Route::post($domainAndModuleParams.'/edit/relation', 'Core\EditController@addRelation')->name('edit.relation.add');
115			Route::get($domainAndModuleParams.'/edit/relation/delete', 'Core\EditController@deleteRelation')->name('edit.relation.delete');
116			Route::get($domainAndModuleParams.'/popup_edit', 'Core\PopupEditController@process')->name('popup.edit');
117			Route::post($domainAndModuleParams.'/popup', 'Core\PopupEditController@save')->name('popup.save');
118			Route::get($domainAndModuleParams.'/delete', 'Core\DeleteController@process')->name('delete');
119			Route::get($domainAndModuleParams.'/restore', 'Core\EditController@restore')->name('restore');
120			Route::post($domainAndModuleParams, 'Core\EditController@save')->name('save');
121			Route::get($domainAndModuleParams.'/download', 'Core\DownloadController@process')->name('download');
122			Route::get($domainAndModuleParams.'/tree', 'Core\TreeController@process')->name('tree');
123			Route::get($domainAndModuleParams.'/tree/root', 'Core\TreeController@root')->name('tree.root');
124			Route::get($domainAndModuleParams.'/tree/children', 'Core\TreeController@children')->name('tree.children');
125			});

uccellolabs / uccello

Issues (652)

routes/web.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like