uccellolabs / uccello

app/Providers/RouteServiceProvider.php

<?php

namespace Uccello\Core\Providers;

use App\Providers\RouteServiceProvider as DefaultRouteServiceProvider;

The type App\Providers\RouteServiceProvider was not found. Maybe you did not declare it correctly or list all dependencies?

use Illuminate\Support\Facades\Route;
use Uccello\Core\Models\Domain;
use Uccello\Core\Models\Module;

/**
 * Route Service Provider
 */
class RouteServiceProvider extends DefaultRouteServiceProvider
{
    /**
     * @inheritDoc
     */
    public function boot()
    {
        parent::boot();

        // Bind domain
        Route::bind('domain', function ($value) {
            if (preg_match('`^[0-9]+$`', $value)) { // By id
                $domain = Domain::findOrFail($value);
            } else { // By slug
                $domain = Domain::where('slug', $value)->first() ?? abort(404);

Are you sure the usage of abort(404) is correct as it seems to always return null.

            }
            return $domain;
        });

        // Bind module
        Route::bind('module', function ($value) {
            if (preg_match('`^[0-9]+$`', $value)) { // By id
                $module = Module::findOrFail($value);
            } else { // By name
                $module = Module::where('name', $value)->first() ?? abort(404);

Are you sure the usage of abort(404) is correct as it seems to always return null.

            }
            return $module;
        });
    }

    /**
     * @inheritDoc
     */
    public function map()
    {
        parent::map();

        $this->mapUccelloRoutes();
    }

    /**
     * Define "uccello" routes for the application.
     *
     * @return void
     */
    protected function mapUccelloRoutes()
    {
        // Web
        Route::middleware('web', 'auth')

The call to Illuminate\Support\Facades\Route::middleware() has too many arguments starting with 'auth'.

            ->namespace('Uccello\Core\Http\Controllers') // We prefer to do this instead of modifying $this->namespace, else LoginController is not find
            ->group(__DIR__.'/../../routes/web.php');
    }
}