uccellolabs / uccello

app/Console/Commands/UserCommand.php

<?php

namespace Uccello\Core\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\Hash;
use Uccello\Core\Models\Domain;
use Uccello\Core\Models\Role;
use Uccello\Core\Models\Privilege;
use App\User;

The type App\User was not found. Maybe you did not declare it correctly or list all dependencies?

class UserCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'uccello:user';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create a new user';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $domain = Domain::first();

        $username = $this->ask(trans('uccello::command.user.username'));

It seems like trans('uccello::command.user.username') can also be of type array; however, parameter $question of Illuminate\Console\Command::ask() does only seem to accept string, maybe add an additional type check?

        $name = $this->ask(trans('uccello::command.user.name'));
        $email = $this->ask(trans('uccello::command.user.email'));
        $password = $this->secret(trans('uccello::command.user.password'));

It seems like trans('uccello::command.user.password') can also be of type array; however, parameter $question of Illuminate\Console\Command::secret() does only seem to accept string, maybe add an additional type check?

        $isAdmin = $this->confirm(trans('uccello::command.user.is_admin'));

It seems like trans('uccello::command.user.is_admin') can also be of type array; however, parameter $question of Illuminate\Console\Command::confirm() does only seem to accept string, maybe add an additional type check?

        $user = User::create([
            'username' => $username,
            'name' => $name,
            'email' => $email,
            'password' => Hash::make($password),
            'is_admin' => $isAdmin,
            'domain_id' => $domain->id
        ]);

        $this->addRole($domain, $user);

        $this->info(trans('uccello::command.user.user_created'));

It seems like trans('uccello::command.user.user_created') can also be of type array; however, parameter $string of Illuminate\Console\Command::info() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Add role to user
     */
    protected function addRole($domain, $user)
    {
        $roles = Role::orderBy('name')->get();
        $role = null;

The assignment to $role is dead and can be removed.

        if ($roles) {
            $choices = [ ];
            foreach ($roles as $role) {
                $choices[ ] = $role->name;
            }

            $roleName = $this->choice(trans('uccello::command.user.role'), $choices);

It seems like trans('uccello::command.user.role') can also be of type array; however, parameter $question of Illuminate\Console\Command::choice() does only seem to accept string, maybe add an additional type check?

            $role = Role::where('name', $roleName)->first();

            Privilege::firstOrCreate([
                'domain_id' => $domain->id,
                'role_id' => $role->id,
                'user_id' => $user->id
            ]);
        }
    }
}