Passed
Pull Request — master (#33)
by
unknown
19:38
created
app/Helpers/Uccello.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -234,26 +234,26 @@  discard block
 block discarded – undo
234 234
 
235 235
         if (is_numeric($nameOrId)) {
236 236
             // Use cache
237
-            $modules = Cache::rememberForever('modules_by_id', function () {
237
+            $modules = Cache::rememberForever('modules_by_id', function() {
238 238
                 $modulesGroupedById = collect();
239 239
                 Module::all()->map(function($item) use($modulesGroupedById) {
240
-                    $modulesGroupedById[$item->id] = $item;
240
+                    $modulesGroupedById[ $item->id ] = $item;
241 241
                     return $modulesGroupedById;
242 242
                 });
243 243
                 return $modulesGroupedById;
244 244
             });
245
-            return $modules[(string) $nameOrId] ?? null;
245
+            return $modules[ (string)$nameOrId ] ?? null;
246 246
         } else {
247 247
             // Use cache
248
-            $modules = Cache::rememberForever('modules_by_name', function () {
248
+            $modules = Cache::rememberForever('modules_by_name', function() {
249 249
                 $modulesGroupedByName = collect();
250 250
                 Module::all()->map(function($item) use($modulesGroupedByName) {
251
-                    $modulesGroupedByName[$item->name] = $item;
251
+                    $modulesGroupedByName[ $item->name ] = $item;
252 252
                     return $modulesGroupedByName;
253 253
                 });
254 254
                 return $modulesGroupedByName;
255 255
             });
256
-            return $modules[(string) $nameOrId] ?? null;
256
+            return $modules[ (string)$nameOrId ] ?? null;
257 257
         }
258 258
     }
259 259
 
@@ -271,26 +271,26 @@  discard block
 block discarded – undo
271 271
 
272 272
         if (is_numeric($nameOrId)) {
273 273
             // Use cache
274
-            $uitypes = Cache::rememberForever('uitypes_by_id', function () {
274
+            $uitypes = Cache::rememberForever('uitypes_by_id', function() {
275 275
                 $uitypesGroupedById = collect();
276 276
                 Uitype::all()->map(function($item) use($uitypesGroupedById) {
277
-                    $uitypesGroupedById[$item->id] = $item;
277
+                    $uitypesGroupedById[ $item->id ] = $item;
278 278
                     return $uitypesGroupedById;
279 279
                 });
280 280
                 return $uitypesGroupedById;
281 281
             });
282
-            return $uitypes[(string) $nameOrId] ?? null;
282
+            return $uitypes[ (string)$nameOrId ] ?? null;
283 283
         } else {
284 284
             // Use cache
285
-            $uitypes = Cache::rememberForever('uitypes_by_name', function () {
285
+            $uitypes = Cache::rememberForever('uitypes_by_name', function() {
286 286
                 $uitypesGroupedByName = collect();
287 287
                 Uitype::all()->map(function($item) use($uitypesGroupedByName) {
288
-                    $uitypesGroupedByName[$item->name] = $item;
288
+                    $uitypesGroupedByName[ $item->name ] = $item;
289 289
                     return $uitypesGroupedByName;
290 290
                 });
291 291
                 return $uitypesGroupedByName;
292 292
             });
293
-            return $uitypes[(string) $nameOrId] ?? null;
293
+            return $uitypes[ (string)$nameOrId ] ?? null;
294 294
         }
295 295
     }
296 296
 
@@ -308,26 +308,26 @@  discard block
 block discarded – undo
308 308
 
309 309
         if (is_numeric($nameOrId)) {
310 310
             // Use cache
311
-            $displaytypes = Cache::rememberForever('displaytypes_by_id', function () {
311
+            $displaytypes = Cache::rememberForever('displaytypes_by_id', function() {
312 312
                 $displaytypesGroupedById = collect();
313 313
                 Displaytype::all()->map(function($item) use($displaytypesGroupedById) {
314
-                    $displaytypesGroupedById[$item->id] = $item;
314
+                    $displaytypesGroupedById[ $item->id ] = $item;
315 315
                     return $displaytypesGroupedById;
316 316
                 });
317 317
                 return $displaytypesGroupedById;
318 318
             });
319
-            return $displaytypes[(string) $nameOrId] ?? null;
319
+            return $displaytypes[ (string)$nameOrId ] ?? null;
320 320
         } else {
321 321
             // Use cache
322
-            $displaytypes = Cache::rememberForever('displaytypes_by_name', function () {
322
+            $displaytypes = Cache::rememberForever('displaytypes_by_name', function() {
323 323
                 $displaytypesGroupedByName = collect();
324 324
                 Displaytype::all()->map(function($item) use($displaytypesGroupedByName) {
325
-                    $displaytypesGroupedByName[$item->name] = $item;
325
+                    $displaytypesGroupedByName[ $item->name ] = $item;
326 326
                     return $displaytypesGroupedByName;
327 327
                 });
328 328
                 return $displaytypesGroupedByName;
329 329
             });
330
-            return $displaytypes[(string) $nameOrId] ?? null;
330
+            return $displaytypes[ (string)$nameOrId ] ?? null;
331 331
         }
332 332
     }
333 333
 
@@ -345,26 +345,26 @@  discard block
 block discarded – undo
345 345
 
346 346
         if (is_numeric($nameOrId)) {
347 347
             // Use cache
348
-            $capabilities = Cache::rememberForever('capabilities_by_id', function () {
348
+            $capabilities = Cache::rememberForever('capabilities_by_id', function() {
349 349
                 $capabilitiesGroupedById = collect();
350 350
                 Capability::all()->map(function($item) use($capabilitiesGroupedById) {
351
-                    $capabilitiesGroupedById[$item->id] = $item;
351
+                    $capabilitiesGroupedById[ $item->id ] = $item;
352 352
                     return $capabilitiesGroupedById;
353 353
                 });
354 354
                 return $capabilitiesGroupedById;
355 355
             });
356
-            return $capabilities[(string) $nameOrId] ?? null;
356
+            return $capabilities[ (string)$nameOrId ] ?? null;
357 357
         } else {
358 358
             // Use cache
359
-            $capabilities = Cache::rememberForever('capabilities_by_name', function () {
359
+            $capabilities = Cache::rememberForever('capabilities_by_name', function() {
360 360
                 $capabilitiesGroupedByName = collect();
361 361
                 Capability::all()->map(function($item) use($capabilitiesGroupedByName) {
362
-                    $capabilitiesGroupedByName[$item->name] = $item;
362
+                    $capabilitiesGroupedByName[ $item->name ] = $item;
363 363
                     return $capabilitiesGroupedByName;
364 364
                 });
365 365
                 return $capabilitiesGroupedByName;
366 366
             });
367
-            return $capabilities[(string) $nameOrId] ?? null;
367
+            return $capabilities[ (string)$nameOrId ] ?? null;
368 368
         }
369 369
     }
370 370
 
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
      * @param string $type
407 407
      * @return array
408 408
      */
409
-    public function getDatatableColumns(Module $module, $filterId=null, $type='list'): array
409
+    public function getDatatableColumns(Module $module, $filterId = null, $type = 'list'): array
410 410
     {
411 411
         $columns = [ ];
412 412
 
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
      * @param string $type
463 463
      * @return Filter
464 464
      */
465
-    public function getDefaultFilter(Module $module, $type="list")
465
+    public function getDefaultFilter(Module $module, $type = "list")
466 466
     {
467 467
         $filter = Filter::where('module_id', $module->id)
468 468
         ->where('type', $type)
Please login to merge, or discard this patch.
app/Models/Filter.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -78,24 +78,24 @@
 block discarded – undo
78 78
             $filter = new static();
79 79
 
80 80
             // Refactor $data to mach match 'conditions' filter format...
81
-            if(is_array($data['columns']) && is_array(reset($data['columns'])))
81
+            if (is_array($data[ 'columns' ]) && is_array(reset($data[ 'columns' ])))
82 82
             {
83
-                if (empty($data['conditions'])) {
84
-                    $data['conditions'] = [];
83
+                if (empty($data[ 'conditions' ])) {
84
+                    $data[ 'conditions' ] = [ ];
85 85
                 }
86 86
                 else {
87
-                    $data['conditions'] = (array) $data['conditions'];
87
+                    $data[ 'conditions' ] = (array)$data[ 'conditions' ];
88 88
                 }
89 89
 
90
-                foreach ($data['columns'] as $fieldName => $field) {
90
+                foreach ($data[ 'columns' ] as $fieldName => $field) {
91 91
                     foreach ($field as $key => $value) {
92 92
                         if (!empty($value) && $key != 'columnName') {
93
-                            $data['conditions'][$key][$fieldName] = $value;
93
+                            $data[ 'conditions' ][ $key ][ $fieldName ] = $value;
94 94
                         }
95 95
                     }
96 96
                 }
97 97
 
98
-                unset($data['columns']);
98
+                unset($data[ 'columns' ]);
99 99
             }
100 100
 
101 101
             foreach ($data as $key => $value) {
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,8 +82,7 @@
 block discarded – undo
82 82
             {
83 83
                 if (empty($data['conditions'])) {
84 84
                     $data['conditions'] = [];
85
-                }
86
-                else {
85
+                } else {
87 86
                     $data['conditions'] = (array) $data['conditions'];
88 87
                 }
89 88
 
Please login to merge, or discard this patch.
app/Models/User.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
         $i = 0;
149 149
         foreach ($words as $w) {
150
-            $initials .= $w[0];
150
+            $initials .= $w[ 0 ];
151 151
             $i++;
152 152
 
153 153
             if ($i === 3) { // Maximum: 3 letters
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $image = 'vendor/uccello/uccello/images/user-no-image.png';
169 169
 
170 170
         if ($this->avatarType === 'gravatar') {
171
-            $image = 'https://www.gravatar.com/avatar/' . md5($this->email) . '?d=mm';
171
+            $image = 'https://www.gravatar.com/avatar/'.md5($this->email).'?d=mm';
172 172
 
173 173
         } elseif ($this->avatarType === 'image' && !empty($this->avatar->path)) {
174 174
             $image = $this->avatar->path;
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
      */
186 186
     public function rolesOnDomain($domain) : Collection
187 187
     {
188
-        return Cache::remember('domain_'.$domain->slug.'_roles', 600, function () use($domain) {
188
+        return Cache::remember('domain_'.$domain->slug.'_roles', 600, function() use($domain) {
189 189
             $roles = collect();
190 190
 
191 191
             if (config('uccello.roles.display_ancestors_roles')) {
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $hasRole = false;
235 235
 
236
-        $descendants = Cache::remember('domain_'.$domain->slug.'_descendants', 600, function () use($domain) {
236
+        $descendants = Cache::remember('domain_'.$domain->slug.'_descendants', 600, function() use($domain) {
237 237
             return $domain->findDescendants()->get();
238 238
         });
239 239
 
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
     {
260 260
         $keyName = 'user_'.$this->id.'_'.$domain->slug.'_'.$module->name.'_capabilities';
261 261
 
262
-        return Cache::remember($keyName, 600, function () use($domain, $module) {
262
+        return Cache::remember($keyName, 600, function() use($domain, $module) {
263 263
             $capabilities = collect();
264 264
 
265 265
             // Get the domain and all its parents
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 
314 314
         $keyName = 'user_'.$this->id.'_'.$domain->slug.'_can_access_to_settings_panel';
315 315
 
316
-        return Cache::remember($keyName, 600, function () use($domain) {
316
+        return Cache::remember($keyName, 600, function() use($domain) {
317 317
 
318 318
             $hasCapability = false;
319 319
 
@@ -465,8 +465,8 @@  discard block
 block discarded – undo
465 465
     {
466 466
         // Use cache
467 467
         $allowedGroups = Cache::rememberForever(
468
-            'allowed_groups_for_' . ($this->is_admin ? 'admin' : $this->getKey()),
469
-            function () {
468
+            'allowed_groups_for_'.($this->is_admin ? 'admin' : $this->getKey()),
469
+            function() {
470 470
                 return $this->getAllowedGroupUuidsProcess();
471 471
             }
472 472
         );
@@ -478,8 +478,8 @@  discard block
 block discarded – undo
478 478
     {
479 479
         // Use cache
480 480
         $allowedGroupsAndUsers = Cache::rememberForever(
481
-            'allowed_group_users_for_' . ($addUsers ? 'u_' : '') . ($this->is_admin ? 'admin' : $this->getKey()),
482
-            function () use ($addUsers) {
481
+            'allowed_group_users_for_'.($addUsers ? 'u_' : '').($this->is_admin ? 'admin' : $this->getKey()),
482
+            function() use ($addUsers) {
483 483
                 return $this->getAllowedGroupsAndUsersProcess($addUsers);
484 484
             }
485 485
         );
@@ -489,16 +489,16 @@  discard block
 block discarded – undo
489 489
 
490 490
     protected function getAllowedGroupUuidsProcess()
491 491
     {
492
-        $allowedUserUuids = collect([$this->uuid]);
492
+        $allowedUserUuids = collect([ $this->uuid ]);
493 493
 
494 494
         if ($this->is_admin) {
495 495
             $groups = Group::all();
496 496
         } else {
497
-            $groups = [];
498
-            $users = [];
497
+            $groups = [ ];
498
+            $users = [ ];
499 499
 
500 500
             foreach ($this->groups as $group) {
501
-                $groups[$group->uuid] = $group;
501
+                $groups[ $group->uuid ] = $group;
502 502
             };
503 503
 
504 504
             $this->addRecursiveChildrenGroups($groups, $users, $groups, false);
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
         }
508 508
 
509 509
         foreach ($groups as $uuid => $group) {
510
-            $allowedUserUuids[] = $uuid;
510
+            $allowedUserUuids[ ] = $uuid;
511 511
         }
512 512
 
513 513
         return $allowedUserUuids;
@@ -516,19 +516,19 @@  discard block
 block discarded – undo
516 516
     protected function addRecursiveChildrenGroups(&$groups, &$users, $searchGroups, $addUsers = false)
517 517
     {
518 518
         foreach ($searchGroups as $uuid => $searchGroup) {
519
-            $searchChildrenGroups = [];
519
+            $searchChildrenGroups = [ ];
520 520
 
521 521
             foreach ($searchGroup->childrenGroups as $childrenGroup) {
522
-                if (empty($groups[$childrenGroup->uuid])) {
523
-                    $groups[$childrenGroup->uuid] = $childrenGroup;
524
-                    $searchChildrenGroups[$childrenGroup->uuid] = $childrenGroup;
522
+                if (empty($groups[ $childrenGroup->uuid ])) {
523
+                    $groups[ $childrenGroup->uuid ] = $childrenGroup;
524
+                    $searchChildrenGroups[ $childrenGroup->uuid ] = $childrenGroup;
525 525
                 }
526 526
 
527
-                if($addUsers)
527
+                if ($addUsers)
528 528
                 {
529 529
                     foreach ($childrenGroup->users as $user) {
530
-                        if (empty($users[$user->uuid])) {
531
-                            $users[$user->uuid] = $user;
530
+                        if (empty($users[ $user->uuid ])) {
531
+                            $users[ $user->uuid ] = $user;
532 532
                         }
533 533
                     }
534 534
                 }
@@ -540,26 +540,26 @@  discard block
 block discarded – undo
540 540
 
541 541
     protected function getAllowedGroupsAndUsersProcess($addUsers = true)
542 542
     {
543
-        $allowedUserUuids = collect([[
543
+        $allowedUserUuids = collect([ [
544 544
             'uuid' => $this->uuid,
545 545
             'recordLabel' => uctrans('me', $this->module)
546
-        ]]);
546
+        ] ]);
547 547
 
548 548
         if ($this->is_admin) {
549 549
             $groups = Group::orderBy('name')->get();
550 550
             $users  = \App\User::orderBy('name')->get();
551 551
         } else {
552
-            $groups = [];
553
-            $users = [];
552
+            $groups = [ ];
553
+            $users = [ ];
554 554
 
555 555
             foreach ($this->groups as $group) {
556
-                $groups[$group->uuid] = $group;
556
+                $groups[ $group->uuid ] = $group;
557 557
 
558
-                if($addUsers)
558
+                if ($addUsers)
559 559
                 {
560 560
                     foreach ($group->users as $user) {
561
-                        if (empty($users[$user->uuid])) {
562
-                            $users[$user->uuid] = $user;
561
+                        if (empty($users[ $user->uuid ])) {
562
+                            $users[ $user->uuid ] = $user;
563 563
                         }
564 564
                     }
565 565
                 }
@@ -572,15 +572,15 @@  discard block
 block discarded – undo
572 572
         }
573 573
 
574 574
         foreach ($groups as $uuid => $group) {
575
-            $allowedUserUuids[] = [
575
+            $allowedUserUuids[ ] = [
576 576
                 'uuid' => $group->uuid,
577 577
                 'recordLabel' => $group->recordLabel
578 578
             ];
579 579
         }
580 580
 
581 581
         foreach ($users as $uuid => $user) {
582
-            if($user->getKey() != $this->getKey()) {
583
-                $allowedUserUuids[] = [
582
+            if ($user->getKey() != $this->getKey()) {
583
+                $allowedUserUuids[ ] = [
584 584
                     'uuid' => $user->uuid,
585 585
                     'recordLabel' => $user->recordLabel
586 586
                 ];
Please login to merge, or discard this patch.
app/Models/Group.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,17 +61,17 @@
 block discarded – undo
61 61
 
62 62
     public function parentGroups()
63 63
     {
64
-        return $this->belongsToMany(static::class, $this->tablePrefix . 'rl_groups_groups', 'children_id', 'parent_id');
64
+        return $this->belongsToMany(static::class, $this->tablePrefix.'rl_groups_groups', 'children_id', 'parent_id');
65 65
     }
66 66
 
67 67
     public function childrenGroups()
68 68
     {
69
-        return $this->belongsToMany(static::class, $this->tablePrefix . 'rl_groups_groups', 'parent_id', 'children_id');
69
+        return $this->belongsToMany(static::class, $this->tablePrefix.'rl_groups_groups', 'parent_id', 'children_id');
70 70
     }
71 71
 
72 72
     public function users()
73 73
     {
74
-        return $this->belongsToMany(User::class, $this->tablePrefix . 'rl_groups_users');
74
+        return $this->belongsToMany(User::class, $this->tablePrefix.'rl_groups_users');
75 75
     }
76 76
 
77 77
     /**
Please login to merge, or discard this patch.
app/Support/Traits/UccelloModule.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,15 +56,15 @@
 block discarded – undo
56 56
 
57 57
     protected static function getModuleFromClass($className)
58 58
     {
59
-        $modules = Cache::rememberForever('modules_by_model_class', function () {
59
+        $modules = Cache::rememberForever('modules_by_model_class', function() {
60 60
             $modulesGroupedByModelClass = collect();
61
-            Module::all()->map(function ($item) use ($modulesGroupedByModelClass) {
62
-                $modulesGroupedByModelClass[$item->model_class] = $item;
61
+            Module::all()->map(function($item) use ($modulesGroupedByModelClass) {
62
+                $modulesGroupedByModelClass[ $item->model_class ] = $item;
63 63
                 return $modulesGroupedByModelClass;
64 64
             });
65 65
             return $modulesGroupedByModelClass;
66 66
         });
67
-        return $modules[(string) $className] ?? null;
67
+        return $modules[ (string)$className ] ?? null;
68 68
     }
69 69
 
70 70
     public function getUuidAttribute()
Please login to merge, or discard this patch.
app/Http/Controllers/Core/ListController.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             ->get();
52 52
 
53 53
         // Order by
54
-        $filterOrderBy = (array) $selectedFilter->order;
54
+        $filterOrderBy = (array)$selectedFilter->order;
55 55
 
56 56
         return $this->autoView(compact('datatableColumns', 'filters', 'selectedFilter', 'filterOrderBy'));
57 57
     }
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
             if ($relatedList && $relatedList->method) {
114 114
                 // Related list method
115 115
                 $method = $relatedList->method;
116
-                $recordIdsMethod = $method . 'RecordIds';
116
+                $recordIdsMethod = $method.'RecordIds';
117 117
 
118 118
                 // Get related records ids
119 119
                 $model = new $modelClass;
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 
122 122
                 // Add the record id itself to be filtered
123 123
                 if ($relatedList->module_id === $relatedList->related_module_id && !empty($recordId) && !$filteredRecordIds->contains($recordId)) {
124
-                    $filteredRecordIds[] = (int)$recordId;
124
+                    $filteredRecordIds[ ] = (int)$recordId;
125 125
                 }
126 126
 
127 127
                 // Make the quer
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
             $records = $query->paginate($length);
133 133
         }
134 134
 
135
-        $records->getCollection()->transform(function ($record) use ($domain, $module) {
135
+        $records->getCollection()->transform(function($record) use ($domain, $module) {
136 136
             foreach ($module->fields as $field) {
137 137
                 // If a special template exists, use it. Else use the generic template
138 138
                 $uitype = uitype($field->uitype_id);
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
         $results = collect();
177 177
         if (method_exists($modelClass, 'getSearchResult') && property_exists($modelClass, 'searchableColumns')) {
178 178
             $searchResults = new Search();
179
-            $searchResults->registerModel($modelClass, (array) (new $modelClass)->searchableColumns);
179
+            $searchResults->registerModel($modelClass, (array)(new $modelClass)->searchableColumns);
180 180
             $results = $searchResults->search($q)->take(config('uccello.max_results.autocomplete', 10));
181 181
         }
182 182
 
@@ -197,9 +197,9 @@  discard block
 block discarded – undo
197 197
         $savePageLength = $request->input('save_page_length');
198 198
 
199 199
         // Optional data
200
-        $data = [];
200
+        $data = [ ];
201 201
         if ($savePageLength) {
202
-            $data["length"] = $request->input('page_length');
202
+            $data[ "length" ] = $request->input('page_length');
203 203
         }
204 204
 
205 205
         $filter = Filter::firstOrNew([
Please login to merge, or discard this patch.
app/Http/Controllers/Core/ExportController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
         // With conditions
64 64
         if ($request->input('with_conditions') === '1') {
65 65
             // TODO: Build $conditions['search'] earlier in the export process to match filter format...
66
-            $conditions = ['search' => json_decode($request->input('conditions'))];
66
+            $conditions = [ 'search' => json_decode($request->input('conditions')) ];
67 67
             $export = $export->withConditions($conditions);
68 68
         }
69 69
 
Please login to merge, or discard this patch.
database/migrations/2018_04_15_000035_alter_filter_module.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      */
26 26
     public function down()
27 27
     {
28
-        Schema::table($this->tablePrefix . 'filters', function (Blueprint $table) {
28
+        Schema::table($this->tablePrefix.'filters', function(Blueprint $table) {
29 29
             $table->renameColumn('order', 'order_by');
30 30
         });
31 31
     }
Please login to merge, or discard this patch.