ModuleManagerController::activation() - Code Metrics - uccellolabs/uccello - Measure and Improve Code Quality continuously with Scrutinizer

ModuleManagerController::activation() B
last analyzed 2020-07-02 16:09 UTC

↳ Parent: ModuleManagerController

Complexity

Conditions	8
Paths	40

Size

Total Lines	55
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	8
eloc	28
c	2
b	1
f	0
nc	40
nop	3
dl	0
loc	55
rs	8.4444

How to fix Long Method

<?php

namespace Uccello\Core\Http\Controllers\Settings;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Artisan;
use Uccello\Core\Http\Controllers\Core\Controller;
use Uccello\Core\Models\Domain;
use Uccello\Core\Models\Module;

class ModuleManagerController extends Controller
{
    /**
     * Default view name
     *
     * @var string
     */
    protected $viewName = 'module-manager.main';

    /**
     * Check user permissions
     */
    protected function checkPermissions()
    {
        $this->middleware('uccello.permissions:admin');
    }

    /**
     * Displays the list of modules
     *
     * @param \Uccello\Core\Models\Domain|null $domain
     * @param \Uccello\Core\Models\Module $module
     * @param \Illuminate\Http\Request $request
     * @return void
     */
    public function process(?Domain $domain, Module $module, Request $request)
    {
        // Pre-process
        $this->preProcess($domain, $module, $request);

        $mainModules = [ ];
        $adminModules = [ ];
        foreach (Module::orderBy('id')->get() as $_module) {
            if ($_module->isAdminModule()) {
                $adminModules[ ] = $_module;
            } else {
                $mainModules[ ] = $_module;
            }
        }

        return $this->autoView(compact('mainModules', 'adminModules'));

    }

    /**
     * Activates or deactivates a module on the current domain
     *
     * @param \Uccello\Core\Models\Domain|null $domain
     * @param \Uccello\Core\Models\Module $module
     * @param \Illuminate\Http\Request $request
     * @return array
     */
    public function activation(?Domain $domain, Module $module, Request $request)
    {
        // Pre-process
        $this->preProcess($domain, $module, $request);

        // Activate or deactivate a module on the current domain
        $success = false;
        $error = '';
        if (request('src_module')) {
            $sourceModule = ucmodule(request('src_module'));
            $isActive = request('active') == 1;

            if ($sourceModule) {
                // Activate the module on the current domain
                if ($isActive === true) {
                    $domain->modules()->attach($sourceModule);
                    $success = true;
                    $message = 'message.module_activated';
                }
                // Deactivate the module on the current domain only if it is not mandatory
                elseif (!$sourceModule->isMandatory()) {
                    $domain->modules()->detach($sourceModule);
                    $success = true;
                    $message = 'message.module_deactivated';
                }
                // Impossible to deactivate a mandatory module
                else {
                    $error = 'error.module_is_mandatory';
                }
            }
        }
        // Module name is not defined
        else {
            $error = 'error.module_not_defined';
        }

        $result = [
            'success' => $success
        ];

        // Add message if defined
        if (!empty($message)) {
            $result[ 'message' ] = uctrans($message, $module);
        }

        // Add error if defined
        if (!empty($error)) {
            $result[ 'error' ] = uctrans($error, $module);
        }

        if ($success) {
            Artisan::call('cache:clear');
        }

        return $result;
    }
}

1			<?php
2
3			namespace Uccello\Core\Http\Controllers\Settings;
4
5			use Illuminate\Http\Request;
6			use Illuminate\Support\Facades\Artisan;
7			use Uccello\Core\Http\Controllers\Core\Controller;
8			use Uccello\Core\Models\Domain;
9			use Uccello\Core\Models\Module;
10
11			class ModuleManagerController extends Controller
12			{
13			/**
14			* Default view name
15			*
16			* @var string
17			*/
18			protected $viewName = 'module-manager.main';
19
20			/**
21			* Check user permissions
22			*/
23			protected function checkPermissions()
24			{
25			$this->middleware('uccello.permissions:admin');
26			}
27
28			/**
29			* Displays the list of modules
30			*
31			* @param \Uccello\Core\Models\Domain\|null $domain
32			* @param \Uccello\Core\Models\Module $module
33			* @param \Illuminate\Http\Request $request
34			* @return void
35			*/
36			public function process(?Domain $domain, Module $module, Request $request)
37			{
38			// Pre-process
39			$this->preProcess($domain, $module, $request);
40
41			$mainModules = [ ];
42			$adminModules = [ ];
43			foreach (Module::orderBy('id')->get() as $_module) {
44			if ($_module->isAdminModule()) {
45			$adminModules[ ] = $_module;
46			} else {
47			$mainModules[ ] = $_module;
48			}
49			}
50
51			return $this->autoView(compact('mainModules', 'adminModules'));
			0 ignored issues – show Bug Best Practice introduced 2018-12-30 00:12 UTC by Report Bug Copy Issue Report The expression `return $this->autoView(c...ules', 'adminModules'))` returns the type `Illuminate\View\View` which is incompatible with the documented return type `void`. Loading history...
52			}
53
54			/**
55			* Activates or deactivates a module on the current domain
56			*
57			* @param \Uccello\Core\Models\Domain\|null $domain
58			* @param \Uccello\Core\Models\Module $module
59			* @param \Illuminate\Http\Request $request
60			* @return array
61			*/
62			public function activation(?Domain $domain, Module $module, Request $request)
63			{
64			// Pre-process
65			$this->preProcess($domain, $module, $request);
66
67			// Activate or deactivate a module on the current domain
68			$success = false;
69			$error = '';
70			if (request('src_module')) {
71			$sourceModule = ucmodule(request('src_module'));
72			$isActive = request('active') == 1;
73
74			if ($sourceModule) {
75			// Activate the module on the current domain
76			if ($isActive === true) {
77			$domain->modules()->attach($sourceModule);
78			$success = true;
79			$message = 'message.module_activated';
80			}
81			// Deactivate the module on the current domain only if it is not mandatory
82			elseif (!$sourceModule->isMandatory()) {
83			$domain->modules()->detach($sourceModule);
84			$success = true;
85			$message = 'message.module_deactivated';
86			}
87			// Impossible to deactivate a mandatory module
88			else {
89			$error = 'error.module_is_mandatory';
90			}
91			}
92			}
93			// Module name is not defined
94			else {
95			$error = 'error.module_not_defined';
96			}
97
98			$result = [
99			'success' => $success
100			];
101
102			// Add message if defined
103			if (!empty($message)) {
104			$result[ 'message' ] = uctrans($message, $module);
105			}
106
107			// Add error if defined
108			if (!empty($error)) {
109			$result[ 'error' ] = uctrans($error, $module);
110			}
111
112			if ($success) {
113			Artisan::call('cache:clear');
114			}
115
116			return $result;
117			}
118			}

uccellolabs / uccello

ModuleManagerController::activation() B last analyzed 2020-07-02 16:09 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ModuleManagerController::activation() B
last analyzed 2020-07-02 16:09 UTC