Uccello\Core\Support\Scopes\AssignedUser

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes	3
Bugs	2	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	apply()	0	32	5

<?php

namespace Uccello\Core\Support\Scopes;

use Illuminate\Database\Eloquent\Scope;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Facades\Auth;
use Uccello\Core\Models\Domain;
use Uccello\Core\Models\Entity;

class AssignedUser implements Scope
{
    /**
     * Apply the scope to a given Eloquent query builder.
     *
     * @param  \Illuminate\Database\Eloquent\Builder  $query
     * @param  \Illuminate\Database\Eloquent\Model  $model
     * @return void
     */
    public function apply(Builder $builder, Model $model)
    {
        $user = Auth::user();

        // Records assigned to a group to which the user belongs
        if ($user && !$user->is_admin) {

Accessing is_admin on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $builder->whereIn($model->getTable().'.assigned_user_id', $user->getAllowedGroupUuids());

The method getAllowedGroupUuids() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            // Records assigned to an user with roles subordonate to the roles of the user
            $builder->orWhereIn($model->getTable().'.assigned_user_id', function ($query) use ($user) {
                $entityTable = with(new Entity)->getTable();
                $privilegesTable = env('UCCELLO_TABLE_PREFIX', 'uccello_').'privileges';

                $domain = request()->has('domain') ? request('domain') : Domain::first();
                $subordonateRolesIds = $user->subordonateRolesIdsOnDomain($domain);

The method subordonateRolesIdsOnDomain() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

                $query->select($entityTable.'.id')
                    ->from($entityTable)
                    ->join($privilegesTable, function ($join) use($entityTable, $privilegesTable, $subordonateRolesIds) {
                        $join->on("$privilegesTable.user_id", '=', $entityTable.'.record_id')
                        ->whereIn("$privilegesTable.role_id", $subordonateRolesIds);
                    })
                    ->where("$entityTable.module_id", ucmodule('user')->id ?? null);
            });

            // Records created by the user
            if (!empty($model->module)) {
                $builder->orWhereIn($model->getTable().'.'.$model->getKeyName(), function ($query) use($model) {
                    $query->select('record_id')
                    ->from(with(new Entity)->getTable())
                    ->where('module_id', $model->module->id ?? null)

The property id does not seem to exist on Illuminate\Database\Eloquent\Relations\Relation.

                    ->where('creator_id', auth()->id());
                });
            }
        }
    }
}