Uccello\Core\Http\Controllers\User\ListController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	buildContentQuery()	0	25	4
A	process()	0	12	1
A	import()	0	17	2

<?php

namespace Uccello\Core\Http\Controllers\User;

use App\User;

The type App\User was not found. Maybe you did not declare it correctly or list all dependencies?

use Illuminate\Http\Request;
use Uccello\Core\Http\Controllers\Core\ListController as CoreListController;
use Uccello\Core\Models\Domain;
use Uccello\Core\Models\Module;
use Uccello\Core\Support\Traits\WithPrivileges;
use Uccello\Core\Support\Traits\WithRoles;

class ListController extends CoreListController
{
    use WithRoles;

The trait Uccello\Core\Support\Traits\WithRoles requires some properties which are not provided by Uccello\Core\Http\Controllers\User\ListController: $id, $name

    use WithPrivileges;

The trait Uccello\Core\Support\Traits\WithPrivileges requires the property $id which is not provided by Uccello\Core\Http\Controllers\User\ListController.

    /**
     * {@inheritdoc}
     */
    public function process(?Domain $domain, Module $module, Request $request)
    {
        // Get default view
        $view = parent::process($domain, $module, $request);

        // Useful if multi domains is not used
        $domain = $this->domain;

        // Add data to the view
        $view->roles = $this->getAllRolesOnDomain($domain);

        return $view;
    }

    /**
     * Import user from another domain
     *
     * @param \Uccello\Core\Models\Domain|null $domain
     * @param \Uccello\Core\Models\Module $module
     * @param \Illuminate\Http\Request $request
     * @return void
     */
    public function import(?Domain $domain, Module $module, Request $request)
    {
        $this->preProcess($domain, $module, $request);

        // Useful if multi domains is not used
        $domain = $this->domain;

        $roleIds = (array)$request->roles;

        $user = User::find($request->user_id);
        if ($user) {
            $this->createPrivilegesForUser($domain, $user, $roleIds);
        }

        $route = ucroute('uccello.list', $domain, $module);

        return redirect($route);

The expression return redirect($route) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type void.

    }

    /**
     * Build query for retrieving content
     *
     * @return \Illuminate\Database\Eloquent\Builder;
     */
    protected function buildContentQuery()
    {
        $filter = [
            'order' => $this->request->get('order'),
            'columns' => $this->request->get('columns'),
        ];

        // Get model model class
        $modelClass = $this->module->model_class;

The property model_class does not seem to exist on Uccello\Core\Models\Module. Are you sure there is no database migration missing?

        // Check if the class exists
        if (!class_exists($modelClass) || !method_exists($modelClass, 'scopeInDomain')) {
            return false;

The expression return false returns the type false which is incompatible with the documented return type Illuminate\Database\Eloquent\Builder.

        }

        // Filter on domain if column exists
        $query = $modelClass::withRoleInDomain($this->domain, $this->request->session()->get('descendants'))
                            ->filterBy($filter);

        // Display trash if filter is selected
        if ($this->isDisplayingTrash()) {
            $query = $query->onlyTrashed();
        }

        return $query;
    }
}