Uccello\Core\Http\Controllers\Core\TreeController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	checkPermissions()	0	3	1
A	children()	0	20	3
A	process()	0	16	2
A	getFormattedRecordToAdd()	0	8	1
A	root()	0	19	2

<?php

namespace Uccello\Core\Http\Controllers\Core;

use Illuminate\Http\Request;
use Uccello\Core\Models\Domain;
use Uccello\Core\Models\Module;

class TreeController extends Controller
{
    protected $viewName = 'tree.main';

    /**
     * Check user permissions
     */
    protected function checkPermissions()
    {
        $this->middleware('uccello.permissions:retrieve');
    }

    /**
     * @inheritDoc
     */
    public function process(?Domain $domain, Module $module, Request $request)
    {
        // Pre-process
        $this->preProcess($domain, $module, $request);

        if (!app('uccello')->isTreeModule($module)) {

The method isTreeModule() does not exist on Uccello\Core\Facades\Uccello.

            abort(404);
        }

        // Get model class
        $modelClass = $module->model_class;

The property model_class does not seem to exist on Uccello\Core\Models\Module. Are you sure there is no database migration missing?

        // Total count
        $totalCount = $modelClass::inDomain($domain, $this->request->session()->get('descendants'))->count();

        return $this->autoView(compact('totalCount'));
    }

    /**
     * Returns all root records where the user can access
     *
     * @return array
     */
    public function root(?Domain $domain, Module $module, Request $request)
    {
        // Pre-process
        $this->preProcess($domain, $module, $request);

        // Get model class
        $modelClass = $module->model_class;

The property model_class does not seem to exist on Uccello\Core\Models\Module. Are you sure there is no database migration missing?

        // Get all roots records (according to the current domain)
        $rootRecords = $modelClass::getRoots()
            ->inDomain($domain, $this->request->session()->get('descendants'))
            ->get();

        $roots = collect();
        foreach ($rootRecords as $record) {
            $roots[] = $this->getFormattedRecordToAdd($record);
        }

        return $roots;

The expression return $roots returns the type Illuminate\Support\Collection which is incompatible with the documented return type array.

    }

    /**
     * Returns all record's children.
     *
     * @return array
     */
    public function children(?Domain $domain, Module $module, Request $request)
    {
        // Pre-process
        $this->preProcess($domain, $module, $request);

        // Get model class
        $modelClass = $module->model_class;

The property model_class does not seem to exist on Uccello\Core\Models\Module. Are you sure there is no database migration missing?

        // Get parent record (according to the current domain)
        $parentRecord = $modelClass::inDomain($domain, $this->request->session()->get('descendants'))
            ->find(request('id'));

        $children = collect();
        if ($parentRecord) {
            foreach ($parentRecord->children()->get() as $record) {
                $children[] = $this->getFormattedRecordToAdd($record);
            }
        }

        return $children;

The expression return $children returns the type Illuminate\Support\Collection which is incompatible with the documented return type array.

    }

    /**
     * Get formatted record to add to the tree
     *
     * @param mixed $record
     * @return array|null
     */
    protected function getFormattedRecordToAdd($record)
    {
        return [
            "id" => $record->getKey(),
            "text" => $record->recordLabel,
            "children" => $record->children->count() > 0,
            "a_attr" => [
                "href" => ucroute('uccello.detail', $this->domain, $this->module, [ 'id' => $record->getKey() ])
            ]
        ];
    }
}