Uccello\Core\Http\Controllers\Core\SearchController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getSearchResults()	0	20	4
A	search()	0	13	2
A	getAutorizedModules()	0	22	4

<?php

namespace Uccello\Core\Http\Controllers\Core;

use Spatie\Searchable\Search;

The type Spatie\Searchable\Search was not found. Maybe you did not declare it correctly or list all dependencies?

use Uccello\Core\Models\Domain;
use Uccello\Core\Models\Module;

class SearchController extends Controller
{
    protected $viewName = 'search.main';

    /**
     * @var \Uccello\Core\Models\Domain
     */
    protected $domain;

    /**
     * Search records in all modules where user has retrieve capability.
     *
     * @param \Uccello\Core\Models\Domain
     * @return \Illuminate\Support\Collection
     */
    public function search(?Domain $domain)
    {
        // Pre-process. We force module to be 'home'
        $this->preProcess($domain, ucmodule('home'), request());

It seems like ucmodule('home') can also be of type null; however, parameter $module of Uccello\Core\Http\Controllers\Core\Controller::preProcess() does only seem to accept Uccello\Core\Models\Module, maybe add an additional type check?

        if (!request('q')) {
            return collect();
        }

        $searchResults = $this->getSearchResults();


        return $this->autoView(compact('searchResults'));

The expression return $this->autoView(compact('searchResults')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Support\Collection.

    }

    /**
     * Search records in all autorized modules
     *
     * @return \Illuminate\Support\Collection
     */
    protected function getSearchResults()
    {
        $searchResults = new Search();

        // Get all modules in autorized modules
        $modules = $this->getAutorizedModules();

        foreach ($modules as $module) {
            $modelClass = $module->model_class;

            if (method_exists($modelClass, 'getSearchResult') && property_exists($modelClass, 'searchableColumns')) {
                $searchResults->registerModel($modelClass, (array) (new $modelClass)->searchableColumns);
            }
        }

        $searchQuery = request('q');

        return $searchResults
            ->search($searchQuery)
            ->take(config('uccello.max_results.search', 50));
    }

    /**
     * Retrieve all modules in witch the user can search.
     *
     * @return \Illuminate\Support\Collection
     */
    protected function getAutorizedModules()
    {
        $autorizedModules = collect();

        // Restrct on CRUD modules activated on the domain
        $query = $this->domain->modules()->whereNotNull('model_class');

        // If we want to restrict the search in a module add the condition
        if (request('module')) {
            $query = $query->where('name', request('module'));
        }

        // Get all module
        $modules = $query->get();

        foreach ($modules as $module) {
            if (auth()->user()->canRetrieve($this->domain, $module)) {
                $autorizedModules->push($module);
            }
        }

        return $autorizedModules;
    }
}