Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | class NetteDatabaseTableMssqlDataSource extends NetteDatabaseTableDataSource implements IDataSource |
||
15 | { |
||
16 | |||
17 | /** |
||
18 | * Filter by date |
||
19 | * @param Filter\FilterDate $filter |
||
20 | * @return void |
||
21 | */ |
||
22 | View Code Duplication | public function applyFilterDate(Filter\FilterDate $filter) |
|
33 | |||
34 | |||
35 | /** |
||
36 | * Filter by date range |
||
37 | * @param Filter\FilterDateRange $filter |
||
38 | * @return void |
||
39 | */ |
||
40 | View Code Duplication | public function applyFilterDateRange(Filter\FilterDateRange $filter) |
|
67 | |||
68 | |||
69 | /** |
||
70 | * Apply limit and offset on data |
||
71 | * @param int $offset |
||
72 | * @param int $limit |
||
73 | * @return static |
||
74 | */ |
||
75 | public function limit($offset, $limit) |
||
94 | |||
95 | } |
||
96 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.