tzurbaev / osnova-api

src/Services/Tweets/Tweet.php

<?php

namespace Osnova\Services\Tweets;

use Osnova\Services\Media\TweetMedia;
use Osnova\Services\ServiceEntity;

class Tweet extends ServiceEntity
{
    /**
     * Get tweet ID.
     *
     * @return string|null
     */
    public function getId()
    {
        return $this->getData('id');

The expression return $this->getData('id') also could return the type array which is incompatible with the documented return type null|string.

    }

    /**
     * Get tweet author.
     *
     * @return TweetUser|null
     */
    public function getAuthor()
    {
        return $this->makeEntity(TweetUser::class, 'user');
    }

    /**
     * Get publication date.
     *
     * @return \DateTimeImmutable
     */
    public function getDate()
    {
        return new \DateTimeImmutable($this->getData('created'), 'Europe/Moscow');

It seems like $this->getData('created') can also be of type array; however, parameter $time of DateTimeImmutable::__construct() does only seem to accept string, maybe add an additional type check?

'Europe/Moscow' of type string is incompatible with the type DateTimeZone expected by parameter $timezone of DateTimeImmutable::__construct().

    }

    /**
     * Determines whether the tweet has media list.
     *
     * @return bool
     */
    public function hasMedia()
    {
        return $this->getData('has_media') === true;
    }

    /**
     * Get media list.
     *
     * @return array|TweetMedia[]
     */
    public function getMedia()
    {
        $media = $this->getData('media', []);

array() of type array is incompatible with the type null|string expected by parameter $default of Osnova\Services\ServiceEntity::getData().

        if (!is_array($media) || empty($media)) {
            return [];
        }

        return array_map(function (array $item) {
            return $this->makeEntityFrom(TweetMedia::class, $item);
        }, $media);
    }

    /**
     * Get tweet text.
     *
     * @return string|null
     */
    public function getText()
    {
        return $this->getData('text') ?? '';

The expression return $this->getData('text') ?? '' also could return the type array which is incompatible with the documented return type null|string.

    }

    /**
     * Get retweets count.
     *
     * @return int
     */
    public function getRetweetsCount()
    {
        return intval($this->getData('retweet_count'));
    }

    /**
     * Get favorites count.
     *
     * @return int
     */
    public function getFavoritesCount()
    {
        return intval($this->getData('favorite_count'));
    }
}