ProvidesExtraFieldsValidator::makeExtraFieldsValidator()

Complexity

Conditions	3
Paths	2

Size

Total Lines	25
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function makeExtraFieldsValidator()
    {
        /** @var ValidationFactory $factory */
        $factory = $this->container->make(ValidationFactory::class);
        $rules = method_exists($this, 'rules') ? $this->container->call([$this, 'rules']) : [];
        $data = $this->validationData();

The method validationData() does not exist on Laravel\ExtraFieldsValidator\ProvidesExtraFieldsValidator. Did you maybe mean validator()?

        /** @var Validator $validator */
        $validator = $factory->make($data, $rules, $this->messages(), $this->attributes());

It seems like attributes() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like messages() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $validator->afterSuccess(function (Validator $validator) {
            /** @var ExtraFieldsDetector $detector */
            $detector = $this->container->make(
                config('extra-validator.extra_fields_detector', ExtraFieldsDetector::class)
            );

            $extraField = $detector->getFirstExtraField($validator->getData(), $validator->getRules());

            if (is_null($extraField)) {
                return true;
            }

            $validator->errors()->add($extraField, $this->getExtraFieldErrorMessage($extraField));

            return false;
        });