Zurbaev\ApiClient\Traits\LazyArrayAccess

Complexity

Total Complexity

6

Size/Duplication

Total Lines	62
Duplicated Lines	19.35 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	offsetSet()	11	11	2
A	offsetGet()	0	5	2
A	offsetUnset()	0	7	1
A	offsetExists()	0	5	1

<?php

namespace Zurbaev\ApiClient\Traits;

/**
 * Trait LazyArrayAccess
 *
 * @property array $items
 * @property array $keys
 */
trait LazyArrayAccess
{
    /**
     * Determines if given offset exists in current collection.
     *
     * @param mixed $offset
     *
     * @return bool
     */
    public function offsetExists($offset)
    {
        $this->checkLazyLoad();

It seems like checkLazyLoad() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return isset($this->items[$offset]);
    }

    /**
     * Puts value to given offset or appends it to current collection.
     *
     * @param mixed $offset
     * @param mixed $value
     */
    public function offsetSet($offset, $value)

This method seems to be duplicated in your project.

    {
        $this->checkLazyLoad();

It seems like checkLazyLoad() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (is_null($offset)) {
            $this->items[] = $value;
        } else {
            $this->items[$offset] = $value;
        }

        $this->keys = array_keys($this->items);
    }

    /**
     * Retrieves given offset from current collection.
     * Returns NULL if no value found.
     *
     * @param mixed $offset
     *
     * @return mixed|null
     */
    public function offsetGet($offset)
    {
        $this->checkLazyLoad();

It seems like checkLazyLoad() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return isset($this->items[$offset]) ? $this->items[$offset] : null;
    }

    /**
     * Drops given offset from current collection.
     *
     * @param mixed $offset
     */
    public function offsetUnset($offset)
    {
        $this->checkLazyLoad();

It seems like checkLazyLoad() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        unset($this->items[$offset]);

        $this->keys = array_keys($this->items);
    }
}