Textlocal::getResponseData() - Code Metrics - Inspection of "Nexmo Driver Added" - tzsk/sms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( af7c86...2260a0 )

by Kazi Mainuddin

created 2019-01-24 13:30 UTC

Textlocal::getResponseData() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	14
Ratio	100 %

Importance

Changes

Metric	Value
dl	14
loc	14
rs	9.7998
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace Tzsk\Sms\Drivers;

use GuzzleHttp\Client;
use Tzsk\Sms\Abstracts\Driver;

class Textlocal extends Driver
{
    /**
     * Textlocal Settings.
     *
     * @var object
     */
    protected $settings;

    /**
     * Http Client.
     *
     * @var Client
     */
    protected $client;

    /**
     * Construct the class with the relevant settings.
     *
     * SendSmsInterface constructor.
     * @param array $settings
     */
    public function __construct($settings)
    {
        $this->settings = (object) $settings;
        $this->client = new Client();
    }

    /**
     * Send text message and return response.
     *
     * @return mixed
     */
    public function send()

    {
        $response = collect();
        foreach ($this->recipients as $recipient) {
            $response->put(
                $recipient,
                $this->client->request('POST', $this->settings->url, $this->payload($recipient))
            );
        }

        return (count($this->recipients) == 1) ? $response->first() : $response;
    }

    /**
     * @param string $recipient
     * @return array
     */
    public function payload($recipient)
    {
        return [
            'form_params' => [
                'username' => $this->settings->username,
                'hash' => $this->settings->hash,
                'numbers' => $recipient,
                'sender' => urlencode($this->settings->sender),
                'message' => $this->body,
            ],
        ];
    }
}


1		<?php
2
3		namespace Tzsk\Sms\Drivers;
4
5		use GuzzleHttp\Client;
6		use Tzsk\Sms\Abstracts\Driver;
7
8		class Textlocal extends Driver
9		{
10		/**
11		* Textlocal Settings.
12		*
13		* @var object
14		*/
15		protected $settings;
16
17		/**
18		* Http Client.
19		*
20		* @var Client
21		*/
22		protected $client;
23
24		/**
25		* Construct the class with the relevant settings.
26		*
27		* SendSmsInterface constructor.
28		* @param array $settings
29		*/
30		public function __construct($settings)
31		{
32		$this->settings = (object) $settings;
33		$this->client = new Client();
34		}
35
36		/**
37		* Send text message and return response.
38		*
39		* @return mixed
40		*/
41	View Code Duplication	public function send()
		0 ignored issues – show Duplication introduced 2019-01-24 13:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		{
43		$response = collect();
44		foreach ($this->recipients as $recipient) {
45		$response->put(
46		$recipient,
47		$this->client->request('POST', $this->settings->url, $this->payload($recipient))
48		);
49		}
50
51		return (count($this->recipients) == 1) ? $response->first() : $response;
52		}
53
54		/**
55		* @param string $recipient
56		* @return array
57		*/
58		public function payload($recipient)
59		{
60		return [
61		'form_params' => [
62		'username' => $this->settings->username,
63		'hash' => $this->settings->hash,
64		'numbers' => $recipient,
65		'sender' => urlencode($this->settings->sender),
66		'message' => $this->body,
67		],
68		];
69		}
70		}
71

tzsk / sms

Push — master ( af7c86...2260a0 )

Textlocal::getResponseData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like