Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Textlocal extends Driver |
||
9 | { |
||
10 | /** |
||
11 | * Textlocal Settings. |
||
12 | * |
||
13 | * @var object |
||
14 | */ |
||
15 | protected $settings; |
||
16 | |||
17 | /** |
||
18 | * Http Client. |
||
19 | * |
||
20 | * @var Client |
||
21 | */ |
||
22 | protected $client; |
||
23 | |||
24 | /** |
||
25 | * Construct the class with the relevant settings. |
||
26 | * |
||
27 | * SendSmsInterface constructor. |
||
28 | * @param array $settings |
||
29 | */ |
||
30 | public function __construct($settings) |
||
35 | |||
36 | /** |
||
37 | * Send text message and return response. |
||
38 | * |
||
39 | * @return mixed |
||
40 | */ |
||
41 | View Code Duplication | public function send() |
|
53 | |||
54 | /** |
||
55 | * @param string $recipient |
||
56 | * @return array |
||
57 | */ |
||
58 | public function payload($recipient) |
||
70 | } |
||
71 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.