Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Clockwork extends Driver |
||
9 | { |
||
10 | /** |
||
11 | * Settings. |
||
12 | * |
||
13 | * @var object |
||
14 | */ |
||
15 | protected $settings; |
||
16 | |||
17 | /** |
||
18 | * Client. |
||
19 | * |
||
20 | * @var ClockworkClient |
||
21 | */ |
||
22 | protected $client; |
||
23 | |||
24 | /** |
||
25 | * Construct the class with the relevant settings. |
||
26 | * |
||
27 | * SendSmsInterface constructor. |
||
28 | * @param $settings object |
||
29 | */ |
||
30 | public function __construct($settings) |
||
35 | |||
36 | /** |
||
37 | * Send text message and return response. |
||
38 | * |
||
39 | * @return object |
||
40 | */ |
||
41 | View Code Duplication | public function send() |
|
53 | } |
||
54 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.