Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | View Code Duplication | class Farazsms extends Driver |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * Tsms Settings. |
||
12 | * |
||
13 | * @var null|object |
||
14 | */ |
||
15 | protected $settings; |
||
16 | |||
17 | /** |
||
18 | * Smsir Client. |
||
19 | * |
||
20 | * @var null|SoapClient |
||
21 | */ |
||
22 | protected $client; |
||
23 | |||
24 | /** |
||
25 | * Construct the class with the relevant settings. |
||
26 | * |
||
27 | * @param $settings |
||
28 | * @throws \SoapFault |
||
29 | */ |
||
30 | public function __construct($settings) |
||
35 | |||
36 | /** |
||
37 | * Send text message and return response. |
||
38 | * |
||
39 | * @return object |
||
40 | * @throws \GuzzleHttp\Exception\GuzzleException |
||
41 | */ |
||
42 | public function send() |
||
57 | |||
58 | /** |
||
59 | * @param string $recipient |
||
60 | * @param string $token |
||
61 | * @return array |
||
62 | */ |
||
63 | protected function payload($recipient) |
||
74 | } |
||
75 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.