Tzsk\Sms\Tests\SmsManagerTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	82
Duplicated Lines	43.9 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	test_it_has_default_driver()	0	8	1
A	test_it_wont_accespt_wrong_driver()	0	5	1
A	test_driver_can_be_changed()	0	8	1
A	test_it_has_proper_driver_instance()	0	6	1
A	test_can_call_directly()	10	10	1
A	test_can_call_from_facade()	10	10	1
A	test_can_be_sent_by_dispatch_method()	8	8	1
A	test_sms_builder_can_be_sent()	8	8	1
A	test_sms_builder_via_can_be_sent()	0	8	1

<?php

namespace Tzsk\Sms\Tests;

use Tzsk\Sms\Facade\Sms;
use Tzsk\Sms\SmsBuilder;
use Tzsk\Sms\Abstracts\Driver;
use Tzsk\Sms\Drivers\Textlocal;
use Tzsk\Sms\Tests\Mocks\MockSmsManager;
use Tzsk\Sms\Tests\Mocks\Drivers\BarDriver;

class SmsManagerTest extends TestCase

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: artisan, be, call, seed

{
    public function test_it_has_default_driver()
    {
        $manager = new MockSmsManager();

        $this->assertArraySubset(config('sms'), $manager->getConfig());
        $this->assertEquals(config('sms.default'), $manager->getDriver());
        $this->assertArraySubset($manager->getSettings(), config('sms.drivers.'.$manager->getDriver()));
    }

    public function test_it_wont_accespt_wrong_driver()
    {
        $this->expectException(\Exception::class);
        $manager = (new MockSmsManager())->via('foo');

$manager is not used, you could remove the assignment.

    }

    public function test_driver_can_be_changed()
    {
        $gateway = 'twilio';
        $manager = (new MockSmsManager())->via($gateway);

        $this->assertEquals($gateway, $manager->getDriver());
        $this->assertArraySubset($manager->getSettings(), config('sms.drivers.'.$gateway));
    }

    public function test_it_has_proper_driver_instance()
    {
        $manager = new MockSmsManager();

        $this->assertInstanceOf(Driver::class, $manager->driverInstance());
    }

    public function test_can_call_directly()

This method seems to be duplicated in your project.

    {
        $response = (new MockSmsManager())->via('bar')
            ->send('foo', function ($message) {
                $message->to(['baz']);
            });
        $this->assertInstanceOf(BarDriver::class, $response);
        $this->assertEquals('foo', $response->getBody());
        $this->assertContains('baz', $response->getRecipients());
    }

    public function test_can_call_from_facade()

This method seems to be duplicated in your project.

    {
        $response = Sms::via('bar')->send('foo', function ($m) {
            $m->to('baz');
        });

        $this->assertInstanceOf(BarDriver::class, $response);
        $this->assertEquals('foo', $response->getBody());
        $this->assertContains('baz', $response->getRecipients());
    }

    public function test_can_be_sent_by_dispatch_method()

This method seems to be duplicated in your project.

    {
        $response = Sms::via('bar')->send('foo')->to('baz')->dispatch();

        $this->assertInstanceOf(BarDriver::class, $response);
        $this->assertEquals('foo', $response->getBody());
        $this->assertContains('baz', $response->getRecipients());
    }

    public function test_sms_builder_can_be_sent()

This method seems to be duplicated in your project.

    {
        $response = Sms::send((new SmsBuilder)->via('bar')->to('baz')->send('foo'));

        $this->assertInstanceOf(BarDriver::class, $response);
        $this->assertEquals('foo', $response->getBody());
        $this->assertContains('baz', $response->getRecipients());
    }

    public function test_sms_builder_via_can_be_sent(Type $var = null)

The parameter $var is not used and could be removed.

    {
        $response = Sms::via('bar')->send((new SmsBuilder)->to('baz')->send('foo'));

        $this->assertInstanceOf(BarDriver::class, $response);
        $this->assertEquals('foo', $response->getBody());
        $this->assertContains('baz', $response->getRecipients());
    }
}