DriverCommon::test_it_has_recipients() - Code Metrics - Inspection of "Travis CI added" - tzsk/sms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2adfbb...9718a0 )

by Kazi Mainuddin

created 2019-01-11 09:12 UTC

DriverCommon::test_it_has_recipients() A

↳ Parent: DriverCommon

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Tzsk\Sms\Tests\Drivers;

trait DriverCommon
{
    public function test_it_has_recipients()
    {
        $driver = $this->getDriver();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $driver->to(['foo']);
        $driver->to('bar');

        $this->assertContains('foo', $driver->getRecipients());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertContains('bar', $driver->getRecipients());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function test_it_has_body()
    {
        $driver = $this->getDriver();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $text = 'foo';
        $driver->message($text);

        $this->assertEquals($text, $driver->getBody());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Tzsk\Sms\Tests\Drivers;
4
5			trait DriverCommon
6			{
7			public function test_it_has_recipients()
8			{
9			$driver = $this->getDriver();
			0 ignored issues – show Bug introduced 2019-01-11 09:21 UTC by Report Bug Copy Issue Report It seems like `getDriver()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
10
11			$driver->to(['foo']);
12			$driver->to('bar');
13
14			$this->assertContains('foo', $driver->getRecipients());
			0 ignored issues – show Bug introduced 2019-01-11 09:21 UTC by Report Bug Copy Issue Report It seems like `assertContains()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15			$this->assertContains('bar', $driver->getRecipients());
			0 ignored issues – show Bug introduced 2019-01-11 09:21 UTC by Report Bug Copy Issue Report It seems like `assertContains()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17
18			public function test_it_has_body()
19			{
20			$driver = $this->getDriver();
			0 ignored issues – show Bug introduced 2019-01-11 09:21 UTC by Report Bug Copy Issue Report It seems like `getDriver()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21
22			$text = 'foo';
23			$driver->message($text);
24
25			$this->assertEquals($text, $driver->getBody());
			0 ignored issues – show Bug introduced 2019-01-11 09:21 UTC by Report Bug Copy Issue Report It seems like `assertEquals()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			}
27			}
28

tzsk / sms

Push — master ( 2adfbb...9718a0 )

DriverCommon::test_it_has_recipients() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like