Driver::message() - Code Metrics - Inspection of "some modifies in order to DRY principle, and some..." - tzsk/sms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

unknown

created 2019-01-07 20:15 UTC

Driver::message() A

↳ Parent: Driver

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
nc	3
cc	3
nop	1

<?php
namespace Tzsk\Sms\Abstracts;

use Tzsk\Sms\Contracts\DriverInterface;

abstract class Driver implements DriverInterface
{
    /**
     * To Numbers array.
     *
     * @var array
     */
    protected $recipients = [];

    /**
     * Message body.
     *
     * @var string
     */
    protected $body = "";

    /**
     * Driver constructor.
     *
     * @param $settings
     */
    abstract public function __construct($settings);

    /**
     * String or Array of numbers.
     *
     * @param $numbers string|array
     * @return $this
     * @throws \Exception
     */
    public function to($numbers)
    {
        $recipients = is_array($numbers) ? $numbers : [$numbers];
        $recipients = array_map(function ($item) {
            return trim($item);
        }, array_merge($this->recipients, $recipients));

        $this->recipients = array_values(array_filter($recipients));

        if (count($this->recipients) < 1) {
            throw new \Exception("Message recipient could not be empty.");
        }

        return $this;
    }

    /**
     * Set text message body.
     *
     * @param $message string
     * @return $this
     * @throws \Exception
     */
    public function message($message)
    {
        if (!is_string($message)) {
            throw new \Exception("Message text should be a string.");
        }
        if (trim($message) == '') {
            throw new \Exception("Message text could not be empty.");
        }
        $this->body = $message;

        return $this;
    }

    /**
     * Send the message
     *
     * @return object
     */
    abstract public function send();
}


1			<?php
2			namespace Tzsk\Sms\Abstracts;
3
4			use Tzsk\Sms\Contracts\DriverInterface;
5
6			abstract class Driver implements DriverInterface
7			{
8			/**
9			* To Numbers array.
10			*
11			* @var array
12			*/
13			protected $recipients = [];
14
15			/**
16			* Message body.
17			*
18			* @var string
19			*/
20			protected $body = "";
21
22			/**
23			* Driver constructor.
24			*
25			* @param $settings
26			*/
27			abstract public function __construct($settings);
28
29			/**
30			* String or Array of numbers.
31			*
32			* @param $numbers string\|array
33			* @return $this
34			* @throws \Exception
35			*/
36			public function to($numbers)
37			{
38			$recipients = is_array($numbers) ? $numbers : [$numbers];
39			$recipients = array_map(function ($item) {
40			return trim($item);
41			}, array_merge($this->recipients, $recipients));
42
43			$this->recipients = array_values(array_filter($recipients));
44
45			if (count($this->recipients) < 1) {
46			throw new \Exception("Message recipient could not be empty.");
47			}
48
49			return $this;
50			}
51
52			/**
53			* Set text message body.
54			*
55			* @param $message string
56			* @return $this
57			* @throws \Exception
58			*/
59			public function message($message)
60			{
61			if (!is_string($message)) {
62			throw new \Exception("Message text should be a string.");
63			}
64			if (trim($message) == '') {
65			throw new \Exception("Message text could not be empty.");
66			}
67			$this->body = $message;
68
69			return $this;
70			}
71
72			/**
73			* Send the message
74			*
75			* @return object
76			*/
77			abstract public function send();
78			}
79

tzsk / sms

Pull Request — master (#13)

Driver::message() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like