AbstractVendor::fetchCategories() - Code Metrics - Inspection of "Travis & Code Fix" - tzsk/scrape-pod - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e4966f...264912 )

by Kazi Mainuddin

created 2017-10-29 10:22 UTC

AbstractVendor::fetchCategories() A

↳ Parent: AbstractVendor

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
c	0
b	0
f	0
rs	9.4285
cc	3
eloc	10
nc	3
nop	1

<?php
namespace Tzsk\ScrapePod\Vendors;

use DateTime;
use function GuzzleHttp\Psr7\str;
use SimpleXMLElement;

abstract class AbstractVendor
{
	/**
	 * @param SimpleXMLElement $feed
	 *
	 * @return array
	 */
	public function buildFeed(SimpleXMLElement $feed)
	{
		$output = [
			'title'          => (string) $feed->channel->title,
			'description'    => (string) $feed->channel->description,
			'summary'        => (string) $this->getValueByPath($feed->channel, "summary"),
			'image'          => (string) $feed->channel->image->url,
			'site'           => (string) $feed->channel->link,
			'author'         => (string) $this->getValueByPath($feed->channel, "author"),
			'language'       => (string) $feed->channel->language,
			'categories'     => $this->fetchCategories($feed->channel),
			'episode_count'  => (int) count($feed->channel->item),
			'episodes'       => $this->getEpisodes($feed->channel)
		];

		return $output;
	}

	/**
	 * @param SimpleXMLElement|mixed $channel
	 *
	 * @return array
	 */
	protected function getEpisodes($channel)
	{
		$items = [];
		foreach($channel->item as $value) {
			$items[] = [
				'title'        => (string) $value->title,
				'mp3'          => $this->getAudioUrl($value),
				'size'         => $this->getEpisodeSize($value),
				'duration'     => $this->getEpisodeDuration($value),
				'description'  => (string) $value->description,
				'link'         => (string) $value->link,
				'image'        => $this->getEpisodeImage($value, $channel),
				'published_at' => $this->getPublishedDate($value),
			];
		}

		return $items;
	}

	/**
	 * @param SimpleXMLElement $value
	 *
	 * @return null|string
	 */
	protected function getAudioUrl($value)
	{
		return isset($value->enclosure) ? (string) $value->enclosure->attributes()->url : null;
	}

	/**
	 * @param SimpleXMLElement $value
	 *
	 * @return int
	 */
	protected function getEpisodeSize($value)
	{
		return isset($value->enclosure) ? (int) $value->enclosure->attributes()->length : 0;
	}

	/**
	 * @param SimpleXMLElement $item
	 *
	 * @return string
	 */
	protected function getPublishedDate($item)
	{
		$published_at = new DateTime();
		$published_at->setTimestamp(strtotime($item->pubDate));

		return $published_at->format('Y-m-d H:i:s');
	}

	/**
	 * @param SimpleXMLElement|mixed $item
	 * @param string $path
	 *
	 * @return string
	 */
	protected function getValueByPath($item, $path)
	{
		return empty($item->xpath("itunes:{$path}")) ? null :
			$item->xpath("itunes:{$path}")[0];
	}

	/**
	 * @param SimpleXMLElement|mixed $item
	 *
	 * @return int
	 */
	protected function getEpisodeDuration($item)
	{
		$duration = (string) $this->getValueByPath($item, "duration");

		$durationArray = explode(":", $duration);
		if (count($durationArray) > 1) {
			sscanf($duration, "%d:%d:%d", $hours, $minutes, $seconds);


			$duration = isset($seconds) ? $hours * 3600 + $minutes * 60 + $seconds : $hours * 60 + $minutes;
		}

		return (int) $duration;
	}

	/**
	 * @param SimpleXMLElement $item
	 *
	 * @param SimpleXMLElement $channel
	 *
	 * @return string
	 */
	protected function getEpisodeImage($item, $channel)
	{
		$xmlImage = $this->getValueByPath($item, "image");

		return $xmlImage ? (string) $xmlImage->attributes()->href : (string) $channel->image->url;

	}

	/**
	 * @param SimpleXMLElement|mixed $channel
	 *
	 * @return array
	 */
	protected function fetchCategories($channel)
	{
		$categories = $channel->xpath('itunes:category');

		$items = [];
		foreach ( $categories as $category ) {
			$item = ['title' => (string) $category->attributes()->text, 'children' => []];

			if (! empty($category->xpath('itunes:category'))) {
				$inner = $this->fetchCategories($category);

				$item['children'] = $inner;
			}

			$items[] = $item;
		}

		return $items;
	}
}

1			<?php
2			namespace Tzsk\ScrapePod\Vendors;
3
4			use DateTime;
5			use function GuzzleHttp\Psr7\str;
6			use SimpleXMLElement;
7
8			abstract class AbstractVendor
9			{
10			/**
11			* @param SimpleXMLElement $feed
12			*
13			* @return array
14			*/
15			public function buildFeed(SimpleXMLElement $feed)
16			{
17			$output = [
18			'title' => (string) $feed->channel->title,
19			'description' => (string) $feed->channel->description,
20			'summary' => (string) $this->getValueByPath($feed->channel, "summary"),
21			'image' => (string) $feed->channel->image->url,
22			'site' => (string) $feed->channel->link,
23			'author' => (string) $this->getValueByPath($feed->channel, "author"),
24			'language' => (string) $feed->channel->language,
25			'categories' => $this->fetchCategories($feed->channel),
26			'episode_count' => (int) count($feed->channel->item),
27			'episodes' => $this->getEpisodes($feed->channel)
28			];
29
30			return $output;
31			}
32
33			/**
34			* @param SimpleXMLElement\|mixed $channel
35			*
36			* @return array
37			*/
38			protected function getEpisodes($channel)
39			{
40			$items = [];
41			foreach($channel->item as $value) {
42			$items[] = [
43			'title' => (string) $value->title,
44			'mp3' => $this->getAudioUrl($value),
45			'size' => $this->getEpisodeSize($value),
46			'duration' => $this->getEpisodeDuration($value),
47			'description' => (string) $value->description,
48			'link' => (string) $value->link,
49			'image' => $this->getEpisodeImage($value, $channel),
50			'published_at' => $this->getPublishedDate($value),
51			];
52			}
53
54			return $items;
55			}
56
57			/**
58			* @param SimpleXMLElement $value
59			*
60			* @return null\|string
61			*/
62			protected function getAudioUrl($value)
63			{
64			return isset($value->enclosure) ? (string) $value->enclosure->attributes()->url : null;
65			}
66
67			/**
68			* @param SimpleXMLElement $value
69			*
70			* @return int
71			*/
72			protected function getEpisodeSize($value)
73			{
74			return isset($value->enclosure) ? (int) $value->enclosure->attributes()->length : 0;
75			}
76
77			/**
78			* @param SimpleXMLElement $item
79			*
80			* @return string
81			*/
82			protected function getPublishedDate($item)
83			{
84			$published_at = new DateTime();
85			$published_at->setTimestamp(strtotime($item->pubDate));
86
87			return $published_at->format('Y-m-d H:i:s');
88			}
89
90			/**
91			* @param SimpleXMLElement\|mixed $item
92			* @param string $path
93			*
94			* @return string
95			*/
96			protected function getValueByPath($item, $path)
97			{
98			return empty($item->xpath("itunes:{$path}")) ? null :
99			$item->xpath("itunes:{$path}")[0];
100			}
101
102			/**
103			* @param SimpleXMLElement\|mixed $item
104			*
105			* @return int
106			*/
107			protected function getEpisodeDuration($item)
108			{
109			$duration = (string) $this->getValueByPath($item, "duration");
110
111			$durationArray = explode(":", $duration);
112			if (count($durationArray) > 1) {
113			sscanf($duration, "%d:%d:%d", $hours, $minutes, $seconds);
			2 ignored issues – show Bug introduced 2017-10-29 10:12 UTC by Report Bug Copy Issue Report The variable `$minutes` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2017-10-29 10:12 UTC by Report Bug Copy Issue Report The variable `$seconds` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
114
115			$duration = isset($seconds) ? $hours * 3600 + $minutes * 60 + $seconds : $hours * 60 + $minutes;
116			}
117
118			return (int) $duration;
119			}
120
121			/**
122			* @param SimpleXMLElement $item
123			*
124			* @param SimpleXMLElement $channel
125			*
126			* @return string
127			*/
128			protected function getEpisodeImage($item, $channel)
129			{
130			$xmlImage = $this->getValueByPath($item, "image");
131
132			return $xmlImage ? (string) $xmlImage->attributes()->href : (string) $channel->image->url;
			0 ignored issues – show Bug introduced 2017-10-29 10:23 UTC by Report Bug Copy Issue Report The method `attributes` cannot be called on `$xmlImage` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
133			}
134
135			/**
136			* @param SimpleXMLElement\|mixed $channel
137			*
138			* @return array
139			*/
140			protected function fetchCategories($channel)
141			{
142			$categories = $channel->xpath('itunes:category');
143
144			$items = [];
145			foreach ( $categories as $category ) {
146			$item = ['title' => (string) $category->attributes()->text, 'children' => []];
147
148			if (! empty($category->xpath('itunes:category'))) {
149			$inner = $this->fetchCategories($category);
150
151			$item['children'] = $inner;
152			}
153
154			$items[] = $item;
155			}
156
157			return $items;
158			}
159			}

tzsk / scrape-pod

Push — master ( e4966f...264912 )

AbstractVendor::fetchCategories() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like