Issues in Customer.php (master) - Issues in master - tzsk/payu - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Concerns/Customer.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Tzsk\Payu\Concerns;

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\ValidationException;
use Tzsk\Payu\Contracts\HasFormParams;

class Customer implements HasFormParams
{
    public ?string $firstName = null;

    public ?string $lastName = null;
    public ?string $email = null;
    public ?string $phone = null;
    public ?string $addressOne = null;
    public ?string $addressTwo = null;
    public ?string $city = null;
    public ?string $state = null;
    public ?string $country = null;
    public ?string $zipCode = null;

    public static function make(): self
    {
        return new self();
    }

    public function firstName(string $firstName): self
    {
        $this->firstName = $firstName;

        return $this;
    }

    public function lastName(string $lastName): self
    {
        $this->lastName = $lastName;

        return $this;
    }

    public function email(string $email): self
    {
        $this->email = $email;

        return $this;
    }

    public function phone(string $phone): self
    {
        $this->phone = $phone;

        return $this;
    }

    public function addressOne(string $addressOne): self
    {
        $this->addressOne = $addressOne;

        return $this;
    }

    public function addressTwo(string $addressTwo): self
    {
        $this->addressTwo = $addressTwo;

        return $this;
    }

    public function city(string $city): self
    {
        $this->city = $city;

        return $this;
    }

    public function state(string $state): self
    {
        $this->state = $state;

        return $this;
    }

    public function country(string $country): self
    {
        $this->country = $country;

        return $this;
    }

    public function zipCode(string $zipCode): self
    {
        $this->zipCode = $zipCode;

        return $this;
    }

    public function toArray(): array
    {
        return [
            'firstname' => $this->firstName,
            'lastname' => $this->lastName,
            'email' => $this->email,
            'phone' => $this->phone,
            'address1' => $this->addressOne,
            'address2' => $this->addressTwo,
            'city' => $this->city,
            'state' => $this->state,
            'country' => $this->country,
            'zipcode' => $this->zipCode,
        ];
    }

    /**
     * @throws ValidationException
     */
    public function validate(): array
    {
        return Validator::make($this->toArray(), [
            'firstname' => 'required|string',
            'lastname' => 'nullable|string',
            'email' => 'required|email',
            'phone' => 'nullable|string',
            'address1' => 'nullable|string',
            'address2' => 'nullable|string',
            'city' => 'nullable|string',
            'state' => 'nullable|string',
            'country' => 'nullable|string',
            'zipcode' => 'nullable|string',
        ])->validate();
    }

    public function fields(): array
    {
        return array_filter($this->toArray());
    }
}


1			<?php
2
3			namespace Tzsk\Payu\Concerns;
4
5			use Illuminate\Support\Facades\Validator;
6			use Illuminate\Validation\ValidationException;
7			use Tzsk\Payu\Contracts\HasFormParams;
8
9			class Customer implements HasFormParams
10			{
11			public ?string $firstName = null;
			0 ignored issues – show Bug introduced 2020-09-10 07:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected '?', expecting T_FUNCTION or T_CONST Loading history...
12			public ?string $lastName = null;
13			public ?string $email = null;
14			public ?string $phone = null;
15			public ?string $addressOne = null;
16			public ?string $addressTwo = null;
17			public ?string $city = null;
18			public ?string $state = null;
19			public ?string $country = null;
20			public ?string $zipCode = null;
21
22			public static function make(): self
23			{
24			return new self();
25			}
26
27			public function firstName(string $firstName): self
28			{
29			$this->firstName = $firstName;
30
31			return $this;
32			}
33
34			public function lastName(string $lastName): self
35			{
36			$this->lastName = $lastName;
37
38			return $this;
39			}
40
41			public function email(string $email): self
42			{
43			$this->email = $email;
44
45			return $this;
46			}
47
48			public function phone(string $phone): self
49			{
50			$this->phone = $phone;
51
52			return $this;
53			}
54
55			public function addressOne(string $addressOne): self
56			{
57			$this->addressOne = $addressOne;
58
59			return $this;
60			}
61
62			public function addressTwo(string $addressTwo): self
63			{
64			$this->addressTwo = $addressTwo;
65
66			return $this;
67			}
68
69			public function city(string $city): self
70			{
71			$this->city = $city;
72
73			return $this;
74			}
75
76			public function state(string $state): self
77			{
78			$this->state = $state;
79
80			return $this;
81			}
82
83			public function country(string $country): self
84			{
85			$this->country = $country;
86
87			return $this;
88			}
89
90			public function zipCode(string $zipCode): self
91			{
92			$this->zipCode = $zipCode;
93
94			return $this;
95			}
96
97			public function toArray(): array
98			{
99			return [
100			'firstname' => $this->firstName,
101			'lastname' => $this->lastName,
102			'email' => $this->email,
103			'phone' => $this->phone,
104			'address1' => $this->addressOne,
105			'address2' => $this->addressTwo,
106			'city' => $this->city,
107			'state' => $this->state,
108			'country' => $this->country,
109			'zipcode' => $this->zipCode,
110			];
111			}
112
113			/**
114			* @throws ValidationException
115			*/
116			public function validate(): array
117			{
118			return Validator::make($this->toArray(), [
119			'firstname' => 'required\|string',
120			'lastname' => 'nullable\|string',
121			'email' => 'required\|email',
122			'phone' => 'nullable\|string',
123			'address1' => 'nullable\|string',
124			'address2' => 'nullable\|string',
125			'city' => 'nullable\|string',
126			'state' => 'nullable\|string',
127			'country' => 'nullable\|string',
128			'zipcode' => 'nullable\|string',
129			])->validate();
130			}
131
132			public function fields(): array
133			{
134			return array_filter($this->toArray());
135			}
136			}
137

tzsk / payu

Issues (41)

Security Analysis not enabled

src/Concerns/Customer.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like