MoneyVerifier::getInstance() - Code Metrics - Inspection of "Resolved Conflict" - tzsk/payu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c985f8...7064aa )

by Kazi Mainuddin

created 2018-03-13 07:39 UTC

MoneyVerifier::getInstance() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php

namespace Tzsk\Payu\Verifiers;

class MoneyVerifier extends AbstractVerifier
{
    /**
     * @return object
     */
    public function verify()

    {
        try {
            $response = $this->client->request('POST', $this->url(), [
class MyClass { }

$x = new MyClass();
$x->foo = true;
                'headers' => [
                    'Authorization' => $this->config->getAuth()
                ],
            ]);
    
            return $this->makeResponse(json_decode($response->getBody()));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        } catch (\Exception $e) {
            return (object) ['status' => false, 'message' => $e->getMessage()];
        }
    }

    /**
     * @return string
     */
    protected function url()
    {
        $src = "https://www.payumoney.com/{$this->prefix()}payment/op/getPaymentResponse?";

        return $src . http_build_query($this->fields());
    }

    /**
     * @return array
     */
    protected function fields()
    {
        return [
            'merchantKey' => $this->config->getKey(),
            'merchantTransactionIds' => implode("|", $this->txnIds)
        ];
    }

    /**
     * @return string
     */
    protected function prefix()
    {
        $env = $this->config->getEnv();

        return ($env == 'test') ? 'sandbox/' : '';
    }

    /**
     * @param object $data
     * @return array
     */
    protected function makeResponse($data)
    {
        if (!empty($data->errorCode)) {
            return (object) ['status' => false, 'data' => [], 'message' => $data->message];
        }
        $response = ['status' => true, 'data' => [], 'message' => ''];
        $collection = collect($data->result)->pluck('postBackParam', 'merchantTransactionId');

        foreach($this->txnIds as $id) {
            if (! empty($collection[$id])) {
                $response['data'][$id] = $this->getInstance($collection[$id]);
            }
        }

        return (object) $response;
    }
}


1		<?php
2
3		namespace Tzsk\Payu\Verifiers;
4
5		class MoneyVerifier extends AbstractVerifier
6		{
7		/**
8		* @return object
9		*/
10	View Code Duplication	public function verify()
		0 ignored issues – show Duplication introduced 2018-03-13 07:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		try {
13		$response = $this->client->request('POST', $this->url(), [
		0 ignored issues – show Bug introduced 2018-02-09 12:55 UTC by Report Bug Copy Issue Report The property `client` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14		'headers' => [
15		'Authorization' => $this->config->getAuth()
16		],
17		]);
18
19		return $this->makeResponse(json_decode($response->getBody()));
		0 ignored issues – show Bug Best Practice introduced 2018-02-09 12:55 UTC by Report Bug Copy Issue Report The return type of `return $this->makeRespon...$response->getBody()));` (`array`) is incompatible with the return type declared by the abstract method `Tzsk\Payu\Verifiers\AbstractVerifier::verify` of type `object`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
20		} catch (\Exception $e) {
21		return (object) ['status' => false, 'message' => $e->getMessage()];
22		}
23		}
24
25		/**
26		* @return string
27		*/
28		protected function url()
29		{
30		$src = "https://www.payumoney.com/{$this->prefix()}payment/op/getPaymentResponse?";
31
32		return $src . http_build_query($this->fields());
33		}
34
35		/**
36		* @return array
37		*/
38		protected function fields()
39		{
40		return [
41		'merchantKey' => $this->config->getKey(),
42		'merchantTransactionIds' => implode("\|", $this->txnIds)
43		];
44		}
45
46		/**
47		* @return string
48		*/
49		protected function prefix()
50		{
51		$env = $this->config->getEnv();
52
53		return ($env == 'test') ? 'sandbox/' : '';
54		}
55
56		/**
57		* @param object $data
58		* @return array
59		*/
60		protected function makeResponse($data)
61		{
62		if (!empty($data->errorCode)) {
63		return (object) ['status' => false, 'data' => [], 'message' => $data->message];
64		}
65		$response = ['status' => true, 'data' => [], 'message' => ''];
66		$collection = collect($data->result)->pluck('postBackParam', 'merchantTransactionId');
67
68		foreach($this->txnIds as $id) {
69		if (! empty($collection[$id])) {
70		$response['data'][$id] = $this->getInstance($collection[$id]);
71		}
72		}
73
74		return (object) $response;
75		}
76		}
77

tzsk / payu

Push — master ( c985f8...7064aa )

MoneyVerifier::getInstance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like