Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | class ProcessorTest extends TestCase |
||
12 | { |
||
13 | public function testWillReturnPayuPaymentObject() |
||
20 | |||
21 | View Code Duplication | protected function getCredentials($transaction = true) |
|
34 | |||
35 | View Code Duplication | protected function getTransaction() |
|
46 | } |
||
47 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.