Tzsk\Payu\Tests\Helpers\FormBuilderTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	49
Duplicated Lines	48.98 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testItWillBuildWithCorrectCredentials()	0	9	1
A	testWillFailWithWrongCredentials()	0	10	2
A	getCredentials()	13	13	2
A	getTransaction()	11	11	1

<?php

namespace Tzsk\Payu\Tests\Helpers;

use Tzsk\Payu\Tests\TestCase;
use Tzsk\Payu\Helpers\FormBuilder;
use Illuminate\Support\Facades\Session;

class FormBuilderTest extends TestCase
{
    public function testItWillBuildWithCorrectCredentials()
    {
        $credentials = $this->getCredentials();

$credentials is not used, you could remove the assignment.

        $builder = (new FormBuilder(request()))->build();
        $this->assertTrue(is_object($builder));
        $this->assertTrue(is_array($builder->fields));
        $this->assertNotEmpty($builder->url);
    }

    public function testWillFailWithWrongCredentials()
    {
        $credentials = $this->getCredentials(false);

$credentials is not used, you could remove the assignment.

        try {
            $builder = (new FormBuilder(request()))->build();

$builder is not used, you could remove the assignment.

        } catch (\Exception $e) {
            $this->assertNotEmpty($e->getMessage());
        }
    }

    protected function getCredentials($transaction = true)

This method seems to be duplicated in your project.

    {
        $data = [
            'data' => $transaction ? $this->getTransaction() : [],
            'status_url' => 'foo',
            'account' => 'payubiz',
            'model' => ['id' => 1, 'class' => 'baz'],
        ];

        Session::put('tzsk_payu_data', $data);

        return $data;
    }

    protected function getTransaction()

This method seems to be duplicated in your project.

    {
        return [
            'txnid' => strtoupper(str_random(8)),
            'amount' => rand(100, 999),
            'productinfo' => 'Product Information',
            'firstname' => 'John',
            'email' => 'john@doe.com',
            'phone' => '9876543210',
        ];
    }
}