Issues in gravityforms-multiple-form-instances.php - Fixed Issues - Inspection of "wip WordPress standards compatibility" - tyxla/Gravity-Forms-Multiple-Form-Instances - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 760316...4068c7 )

by Marin

created 2016-02-01 22:27 UTC

gravityforms-multiple-form-instances.php (29 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Plugin Name: Gravity Forms: Multiple Form Instances
 * Description: Allows multiple instances of the same form to be run on a single page when using AJAX.
 * Author: tyxla
 * Author URI: http://marinatanasov.com/
 * Plugin URI: https://github.com/tyxla/Gravity-Forms-Multiple-Form-Instances
 * Version: 1.0.15
 * License: GPL2
 * Requires at least: 3.0.1
 * Tested up to: 4.4.1
 */

/**
 * The main plugin class.
 */
class Gravity_Forms_Multiple_Form_Instances {

	/**
	 * Constructor.
	 *	
	 * Used to initialize the plugin and hook the related functionality.
	 *
	 * @access public
	 */
	function __construct() {

		// hook the HTML ID string find & replace functionality
		add_filter('gform_get_form_filter', array($this, 'gform_get_form_filter'), 10, 2);

	}

	/**
	 * Replaces all occurences of the form ID with a new, unique ID.
	 *	
	 * This is where the magic happens.
	 *
	 * @access public
	 *
	 * @param string $form_string The form HTML string.
	 * @param array $form Array with the form settings.
	 * @return string $form_string The modified form HTML string.
	 */
	function gform_get_form_filter($form_string, $form) {

		// if form has been submitted, use the submitted ID, otherwise generate a new unique ID
		if (isset($_POST['gform_random_id'])) {

			$random_id = absint( $_POST['gform_random_id'] );

		} else {
			$random_id = mt_rand();	
		}

		// this is where we keep our unique ID
		$hidden_field = "<input type='hidden' name='gform_field_values'";

		// define all occurences of the original form ID that wont hurt the form input
		$strings = array(
			"for='choice_"                                                      => "for='choice_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"id='choice_"                                                       => "id='choice_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"id='label_"                                                        => "id='label_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"'gform_wrapper_" . $form['id'] . "'"                               => "'gform_wrapper_" . $random_id . "'",
			"'gf_" . $form['id'] . "'"                                          => "'gf_" . $random_id . "'",
			"'gform_" . $form['id'] . "'"                                       => "'gform_" . $random_id . "'",
			"'gform_ajax_frame_" . $form['id'] . "'"                            => "'gform_ajax_frame_" . $random_id . "'",
			"#gf_" . $form['id'] . "'"                                          => "#gf_" . $random_id . "'",
			"'gform_fields_" . $form['id'] . "'"                                => "'gform_fields_" . $random_id . "'",
			"id='field_" . $form['id'] . "_"                                    => "id='field_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"for='input_" . $form['id'] . "_"                                   => "for='input_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"id='input_" . $form['id'] . "_"                                    => "id='input_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"'gform_submit_button_" . $form['id'] . "'"                         => "'gform_submit_button_" . $random_id . "'",
			'"gf_submitting_' . $form['id'] . '"'                               => '"gf_submitting_' . $random_id . '"',
			"'gf_submitting_" . $form['id'] . "'"                               => "'gf_submitting_" . $random_id . "'",
			"#gform_ajax_frame_" . $form['id']                                  => "#gform_ajax_frame_" . $random_id,
			"#gform_wrapper_" . $form['id']                                     => "#gform_wrapper_" . $random_id,
			"#gform_" . $form['id']                                             => "#gform_" . $random_id,
			"trigger('gform_post_render', [" . $form['id']                      => "trigger('gform_post_render', [" . $random_id,
			"gformInitSpinner( " . $form['id'] . ","                            => "gformInitSpinner( " . $random_id . ",",
			"trigger('gform_page_loaded', [" . $form['id']                      => "trigger('gform_page_loaded', [" . $random_id,
			"'gform_confirmation_loaded', [" . $form['id'] . "]"                => "'gform_confirmation_loaded', [" . $random_id . "]",
			'gf_apply_rules(' . $form['id'] . ','                               => 'gf_apply_rules(' . $random_id . ',',
			'gform_confirmation_wrapper_' . $form['id']                         => 'gform_confirmation_wrapper_' . $random_id,
			'gforms_confirmation_message_' . $form['id']                        => 'gform_confirmation_wrapper_' . $random_id,
			'gform_confirmation_message_' . $form['id']                         => 'gform_confirmation_message_' . $random_id,
			'if(formId == ' . $form['id'] . ')'                                 => 'if(formId == ' . $random_id . ')',
			"window['gf_form_conditional_logic'][" . $form['id'] . "]"          => "window['gf_form_conditional_logic'][" . $random_id . "]",
			"trigger('gform_post_conditional_logic', [" . $form['id'] . ","     => "trigger('gform_post_conditional_logic', [" . $random_id . ",",
			'gformShowPasswordStrength("input_' . $form['id'] . '_'             => 'gformShowPasswordStrength("input_' . $random_id . '_',
			"gformInitChosenFields('#input_" . $form['id'] . "_"                => "gformInitChosenFields('#input_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"jQuery('#input_" . $form['id'] . "_"                               => "jQuery('#input_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			'gforms_calendar_icon_input_' . $form['id'] . '_'                   => 'gforms_calendar_icon_input_' . $random_id . '_',
			"id='ginput_base_price_" . $form['id'] . "_"                        => "id='ginput_base_price_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"id='ginput_quantity_" . $form['id'] . "_"                          => "id='ginput_quantity_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"gfield_price_" . $form['id'] . "_"                                 => "gfield_price_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"gfield_quantity_" . $form['id'] . "_"                              => "gfield_quantity_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"gfield_product_" . $form['id'] . "_"                               => "gfield_product_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"ginput_total_" . $form['id']                                       => "ginput_total_" . $random_id,
			"GFCalc(" . $form['id'] . ","                                       => "GFCalc(" . $random_id . ",",
			'gf_global["number_formats"][' . $form['id'] . ']'                  => 'gf_global["number_formats"][' . $random_id . ']',
			"gform_next_button_" . $form['id'] . "_"                            => "gform_next_button_" . $random_id . "_",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			$hidden_field                                                       => "<input type='hidden' name='gform_random_id' value='" . $random_id . "' />" . $hidden_field,
		);

		// allow addons & plugins to add additional find & replace strings
		$strings = apply_filters('gform_multiple_instances_strings', $strings);


		// replace all occurences with the new unique ID
		foreach ($strings as $find => $replace) {

			$form_string = str_replace($find, $replace, $form_string);

		}

		return $form_string;
	}

}

// initialize the plugin
global $gravity_forms_multiple_form_instances;
$gravity_forms_multiple_form_instances = new Gravity_Forms_Multiple_Form_Instances();

1		<?php
2		/**
3		* Plugin Name: Gravity Forms: Multiple Form Instances
4		* Description: Allows multiple instances of the same form to be run on a single page when using AJAX.
5		* Author: tyxla
6		* Author URI: http://marinatanasov.com/
7		* Plugin URI: https://github.com/tyxla/Gravity-Forms-Multiple-Form-Instances
8		* Version: 1.0.15
9		* License: GPL2
10		* Requires at least: 3.0.1
11		* Tested up to: 4.4.1
12		*/
13
14		/**
15		* The main plugin class.
16		*/
17		class Gravity_Forms_Multiple_Form_Instances {
18
19		/**
20		* Constructor.
21		*
22		* Used to initialize the plugin and hook the related functionality.
23		*
24		* @access public
25		*/
26	1	function __construct() {
		0 ignored issues – show Best Practice introduced 2016-02-01 22:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
27		// hook the HTML ID string find & replace functionality
28	1	add_filter('gform_get_form_filter', array($this, 'gform_get_form_filter'), 10, 2);
		0 ignored issues – show Coding Style introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 spaces before closing bracket; 0 found Loading history... introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this No space after opening parenthesis of array is bad style Loading history... introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this No space before closing parenthesis of array is bad style Loading history...
29	1	}
30
31		/**
32		* Replaces all occurences of the form ID with a new, unique ID.
33		*
34		* This is where the magic happens.
35		*
36		* @access public
37		*
38		* @param string $form_string The form HTML string.
39		* @param array $form Array with the form settings.
40		* @return string $form_string The modified form HTML string.
41		*/
42		function gform_get_form_filter($form_string, $form) {
		0 ignored issues – show Best Practice introduced 2016-02-01 22:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
43		// if form has been submitted, use the submitted ID, otherwise generate a new unique ID
44		if (isset($_POST['gform_random_id'])) {
		0 ignored issues – show introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this No space after opening parenthesis is prohibited Loading history... introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this No space before closing parenthesis is prohibited Loading history...
45		$random_id = absint( $_POST['gform_random_id'] );
		0 ignored issues – show introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected access of super global var $_POST, probably need manual inspection. Loading history...
46		} else {
47		$random_id = mt_rand();
48		}
49
50		// this is where we keep our unique ID
51		$hidden_field = "<input type='hidden' name='gform_field_values'";
52
53		// define all occurences of the original form ID that wont hurt the form input
54		$strings = array(
55		"for='choice_" => "for='choice_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
56		"id='choice_" => "id='choice_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
57		"id='label_" => "id='label_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
58		"'gform_wrapper_" . $form['id'] . "'" => "'gform_wrapper_" . $random_id . "'",
59		"'gf_" . $form['id'] . "'" => "'gf_" . $random_id . "'",
60		"'gform_" . $form['id'] . "'" => "'gform_" . $random_id . "'",
61		"'gform_ajax_frame_" . $form['id'] . "'" => "'gform_ajax_frame_" . $random_id . "'",
62		"#gf_" . $form['id'] . "'" => "#gf_" . $random_id . "'",
63		"'gform_fields_" . $form['id'] . "'" => "'gform_fields_" . $random_id . "'",
64		"id='field_" . $form['id'] . "_" => "id='field_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
65		"for='input_" . $form['id'] . "_" => "for='input_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
66		"id='input_" . $form['id'] . "_" => "id='input_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
67		"'gform_submit_button_" . $form['id'] . "'" => "'gform_submit_button_" . $random_id . "'",
68		'"gf_submitting_' . $form['id'] . '"' => '"gf_submitting_' . $random_id . '"',
69		"'gf_submitting_" . $form['id'] . "'" => "'gf_submitting_" . $random_id . "'",
70		"#gform_ajax_frame_" . $form['id'] => "#gform_ajax_frame_" . $random_id,
71		"#gform_wrapper_" . $form['id'] => "#gform_wrapper_" . $random_id,
72		"#gform_" . $form['id'] => "#gform_" . $random_id,
73		"trigger('gform_post_render', [" . $form['id'] => "trigger('gform_post_render', [" . $random_id,
74		"gformInitSpinner( " . $form['id'] . "," => "gformInitSpinner( " . $random_id . ",",
75		"trigger('gform_page_loaded', [" . $form['id'] => "trigger('gform_page_loaded', [" . $random_id,
76		"'gform_confirmation_loaded', [" . $form['id'] . "]" => "'gform_confirmation_loaded', [" . $random_id . "]",
77		'gf_apply_rules(' . $form['id'] . ',' => 'gf_apply_rules(' . $random_id . ',',
78		'gform_confirmation_wrapper_' . $form['id'] => 'gform_confirmation_wrapper_' . $random_id,
79		'gforms_confirmation_message_' . $form['id'] => 'gform_confirmation_wrapper_' . $random_id,
80		'gform_confirmation_message_' . $form['id'] => 'gform_confirmation_message_' . $random_id,
81		'if(formId == ' . $form['id'] . ')' => 'if(formId == ' . $random_id . ')',
82		"window['gf_form_conditional_logic'][" . $form['id'] . "]" => "window['gf_form_conditional_logic'][" . $random_id . "]",
83		"trigger('gform_post_conditional_logic', [" . $form['id'] . "," => "trigger('gform_post_conditional_logic', [" . $random_id . ",",
84		'gformShowPasswordStrength("input_' . $form['id'] . '_' => 'gformShowPasswordStrength("input_' . $random_id . '_',
85		"gformInitChosenFields('#input_" . $form['id'] . "_" => "gformInitChosenFields('#input_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
86		"jQuery('#input_" . $form['id'] . "_" => "jQuery('#input_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
87		'gforms_calendar_icon_input_' . $form['id'] . '_' => 'gforms_calendar_icon_input_' . $random_id . '_',
88		"id='ginput_base_price_" . $form['id'] . "_" => "id='ginput_base_price_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
89		"id='ginput_quantity_" . $form['id'] . "_" => "id='ginput_quantity_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
90		"gfield_price_" . $form['id'] . "_" => "gfield_price_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
91		"gfield_quantity_" . $form['id'] . "_" => "gfield_quantity_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
92		"gfield_product_" . $form['id'] . "_" => "gfield_product_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
93		"ginput_total_" . $form['id'] => "ginput_total_" . $random_id,
94		"GFCalc(" . $form['id'] . "," => "GFCalc(" . $random_id . ",",
95		'gf_global["number_formats"][' . $form['id'] . ']' => 'gf_global["number_formats"][' . $random_id . ']',
96		"gform_next_button_" . $form['id'] . "_" => "gform_next_button_" . $random_id . "_",
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `_` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
97		$hidden_field => "<input type='hidden' name='gform_random_id' value='" . $random_id . "' />" . $hidden_field,
98		);
99
100		// allow addons & plugins to add additional find & replace strings
101		$strings = apply_filters('gform_multiple_instances_strings', $strings);
		0 ignored issues – show Coding Style introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 spaces before closing bracket; 0 found Loading history...
102
103		// replace all occurences with the new unique ID
104		foreach ($strings as $find => $replace) {
		0 ignored issues – show introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this No space after opening parenthesis is prohibited Loading history... introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this No space before closing parenthesis is prohibited Loading history...
105		$form_string = str_replace($find, $replace, $form_string);
		0 ignored issues – show Coding Style introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 spaces after opening bracket; 0 found Loading history... Coding Style introduced 2016-02-01 22:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 spaces before closing bracket; 0 found Loading history...
106		}
107
108		return $form_string;
109		}
110
111		}
112
113		// initialize the plugin
114		global $gravity_forms_multiple_form_instances;
115		$gravity_forms_multiple_form_instances = new Gravity_Forms_Multiple_Form_Instances();

GitHub Access Token became invalid

Push — master ( 760316...4068c7 )

gravityforms-multiple-form-instances.php (29 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

tyxla / Gravity-Forms-Multiple-Form-Instances

GitHub Access Token became invalid

Push — master ( 760316...4068c7 )

gravityforms-multiple-form-instances.php (29 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like