View GitHub Repository 4grounds

Schedule Inspection
Subscribe
Passed
Pull Request — master (#20)
by
unknown
01:58
created
Status
Category
Toggle Patches
upload/chiptune.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -12,7 +12,7 @@
 
 block discarded – undo
12 12 
     <body>
13 13 
         <?php require(__DIR__ . "/../important/header.php");
14 14
15 
-        if(@$_POST['submit']) {
15 
+        if (@$_POST['submit']) {
16 16 
             $register = require(__DIR__ . "/../func/upload.php");
17 17 
             $register("chiptune", ["xm", "mod", "s3m", "it"], $conn);
18 18 
         }
Please login to merge, or discard this patch.
upload/song.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -12,7 +12,7 @@
 
 block discarded – undo
12 12 
     <body>
13 13 
         <?php require(__DIR__ . "/../important/header.php");
14 14
15 
-        if(@$_POST['submit']) {
15 
+        if (@$_POST['submit']) {
16 16 
             $register = require(__DIR__ . "/../func/upload.php");
17 17 
             $register("song", ["ogg", "mp3"], $conn);
18 18 
         }
Please login to merge, or discard this patch.
upload/image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -12,7 +12,7 @@
 
 block discarded – undo
12 12 
     <body>
13 13 
         <?php require(__DIR__ . "/../important/header.php");
14 14
15 
-        if(@$_POST['submit']) {
15 
+        if (@$_POST['submit']) {
16 16 
             $register = require(__DIR__ . "/../func/upload.php");
17 17 
             $register("image", ["gif", "png", "jpg", "jpeg"], $conn);
18 18 
         }
Please login to merge, or discard this patch.
index.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch 
@@ -8,13 +8,13 @@  discard block
 
 block discarded – undo
8 8 
             require(__DIR__ . "/func/func.php");
9 9 
             require(__DIR__ . "/func/conn.php");
10 10
11 
-            if(isset($_GET['id'])) {
11 
+            if (isset($_GET['id'])) {
12 12 
                 $stmt = $conn->prepare("SELECT * FROM users WHERE id = ?");
13 13 
                 $stmt->bind_param("i", $_GET['id']);
14 14 
                 $stmt->execute();
15 15 
                 $result = $stmt->get_result();
16 
-                if($result->num_rows !== 0){ // echo('There are no users.'); // please just refuse to give a user if this is the case
17 
-                    while($row = $result->fetch_assoc()) { // you dont need to use a loop if its only ever gonna return 1 or 0
16 
+                if ($result->num_rows !== 0) { // echo('There are no users.'); // please just refuse to give a user if this is the case
17 
+                    while ($row = $result->fetch_assoc()) { // you dont need to use a loop if its only ever gonna return 1 or 0
18 18 
                         $username = $row['username']; // you dont actually need all of these variables oh my god just use an array
19 19 
                         $id = $row['id'];
20 20 
                         $date = $row['date'];
 
@@ -38,11 +38,11 @@  discard block
 
 block discarded – undo
38 38 
                 $stmt->bind_param("i", $currentgroup);
39 39 
                 $stmt->execute();
40 40 
                 $result = $stmt->get_result();
41 
-                if($result->num_rows !== 0){ //echo('There are no users.'); // why again
42 
-                    while($row = $result->fetch_assoc()) {
41 
+                if ($result->num_rows !== 0) { //echo('There are no users.'); // why again
42 
+                    while ($row = $result->fetch_assoc()) {
43 43 
                         $grouptitle = $row['title'];
44 44 
                     }
45 
-                }else{
45 
+                } else {
46 46 
                     $grouptitle = "none";
47 47 
                 }
48 48 
                 $stmt->close();
 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
                 $result = $stmt->get_result();
54 54
55 55 
                 $comments = 0;
56 
-                while($row = $result->fetch_assoc()) {
56 
+                while ($row = $result->fetch_assoc()) {
57 57 
                     $comments++;
58 58 
                 }
59 59 
                 $stmt->close();
 
@@ -64,7 +64,7 @@  discard block
 
 block discarded – undo
64 64 
                 $result = $stmt->get_result();
65 65
66 66 
                 $profilecomments = 0;
67 
-                while($row = $result->fetch_assoc()) {
67 
+                while ($row = $result->fetch_assoc()) {
68 68 
                     $profilecomments++;
69 69 
                 }
70 70 
                 $stmt->close();
 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
                 $result = $stmt->get_result();
76 76
77 77 
                 $filesuploaded = 0;
78 
-                while($row = $result->fetch_assoc()) {
78 
+                while ($row = $result->fetch_assoc()) {
79 79 
                     $filesuploaded++;
80 80 
                 }
81 81 
                 $stmt->close();
 
@@ -95,11 +95,11 @@  discard block
 
 block discarded – undo
95 95 
         <div class="container">
96 96 
             <br>
97 97 
             <?php
98 
-            if($_SERVER['REQUEST_METHOD'] == 'POST')
98 
+            if ($_SERVER['REQUEST_METHOD'] == 'POST')
99 99 
             {
100 
-                if(!isset($_SESSION['user'])){ $error = "you are not logged in"; goto skipcomment; }
101 
-                if(!$_POST['comment']){ $error = "your comment cannot be blank"; goto skipcomment; }
102 
-                if(strlen($_POST['comment']) > 500){ $error = "your comment must be shorter than 500 characters"; goto skipcomment; }
100 
+                if (!isset($_SESSION['user'])) { $error = "you are not logged in"; goto skipcomment; }
101 
+                if (!$_POST['comment']) { $error = "your comment cannot be blank"; goto skipcomment; }
102 
+                if (strlen($_POST['comment']) > 500) { $error = "your comment must be shorter than 500 characters"; goto skipcomment; }
103 103
104 104 
                 $stmt = $conn->prepare("INSERT INTO `comments` (toid, author, text) VALUES (?, ?, ?)");
105 105 
                 $stmt->bind_param("sss", $_GET['id'], $_SESSION['user'], $text);
 
@@ -111,7 +111,7 @@  discard block
 
 block discarded – undo
111 111 
             }
112 112 
             skipcomment:
113 113
114 
-            if(isset($id)) {?>
114 
+            if (isset($id)) {?>
115 115 
                 <div id="groundtext"><center><h1><?php echo $username; ?>'s Ground</h1></center></div>
116 116 
                 <div class="leftHalf">
117 117 
                     <div class="notegray">
 
@@ -121,12 +121,12 @@  discard block
 
 block discarded – undo
121 121 
                         </center>
122 122 
                         <hr style="border-top: 1px dashed gray;">
123 123 
                         <div id="userinfo" style="padding-left: 20px;">
124 
-                            <span style="color: gold;">Rank:</span> <?php echo $rank;?><br>
125 
-                            <span style="color: gold;">ID:</span> <?php echo $id;?><br>
126 
-                            <span style="color: gold;">Other Comments:</span> <?php echo $comments;?><br>
127 
-                            <span style="color: gold;">Profile Comments:</span> <?php echo $profilecomments;?><br>
128 
-                            <span style="color: gold;">Current Group:</span> <?php echo $grouptitle;?><br>
129 
-                            <span style="color: gold;">Files Uploaded:</span> <?php echo $filesuploaded;?>
124 
+                            <span style="color: gold;">Rank:</span> <?php echo $rank; ?><br>
125 
+                            <span style="color: gold;">ID:</span> <?php echo $id; ?><br>
126 
+                            <span style="color: gold;">Other Comments:</span> <?php echo $comments; ?><br>
127 
+                            <span style="color: gold;">Profile Comments:</span> <?php echo $profilecomments; ?><br>
128 
+                            <span style="color: gold;">Current Group:</span> <?php echo $grouptitle; ?><br>
129 
+                            <span style="color: gold;">Files Uploaded:</span> <?php echo $filesuploaded; ?>
130 130 
                         </div><br>
131 131 
                         <?php if (!isset($_GET["ed"])) { ?>
132 132 
                             <audio autoplay controls>
 
@@ -136,7 +136,7 @@  discard block
 
 block discarded – undo
136 136 
                     </div>
137 137 
                     <br>
138 138 
                     <div class="notegray">
139 
-                    <?php if(isset($error)) { echo "<small style='color:red'>".$error."</small>"; } ?>
139 
+                    <?php if (isset($error)) { echo "<small style='color:red'>" . $error . "</small>"; } ?>
140 140 
                     <h2>Comment</h2>
141 141 
                     <form method="post" enctype="multipart/form-data">
142 142 
                         <textarea required cols="33" placeholder="Comment" name="comment"></textarea><br>
 
@@ -155,8 +155,8 @@  discard block
 
 block discarded – undo
155 155 
                     <div id="badges" class="notegray">
156 156 
                         <h1>Badges</h1>
157 157 
                         <?php
158 
-                            foreach($badges as $badge) {
159 
-                                if($badge == "good") {
158 
+                            foreach ($badges as $badge) {
159 
+                                if ($badge == "good") {
160 160 
                                     echo "<img width='70px;' height='70px;' src='https://cdn.discordapp.com/attachments/740680780740821105/740776214523936808/340juojg3h.png'>";
161 161 
                                 }
162 162 
                             }
 
@@ -168,10 +168,10 @@  discard block
 
 block discarded – undo
168 168 
                         $stmt->bind_param("s", $username);
169 169 
                         $stmt->execute();
170 170 
                         $result = $stmt->get_result();
171 
-                        if($result->num_rows > 0) echo('<h1>Files</h1>');
171 
+                        if ($result->num_rows > 0) echo('<h1>Files</h1>');
172 172
173 
-                        while($row = $result->fetch_assoc()) {
174 
-                            echo '<a href="/view?id=' . $row['id'] . '">' . $row['title'] . ' [' , $row['type'] . ']</a><br>';
173 
+                        while ($row = $result->fetch_assoc()) {
174 
+                            echo '<a href="/view?id=' . $row['id'] . '">' . $row['title'] . ' [', $row['type'] . ']</a><br>';
175 175 
                         }?>
176 176 
                     </div><br>
177 177 
                     <div id="bio" class="notegray">
 
@@ -185,7 +185,7 @@  discard block
 
 block discarded – undo
185 185 
                             $stmt->execute();
186 186 
                             $result = $stmt->get_result();
187 187
188 
-                            while($row = $result->fetch_assoc()) { ?>
188 
+                            while ($row = $result->fetch_assoc()) { ?>
189 189 
                                 <div class='commentRight' style='display: grid; grid-template-columns: 75% auto; padding:5px;'>
190 190 
                                     <div style="word-wrap: break-word;">
191 191 
                                         <small><?php echo $row['date']; ?></small>
 
@@ -219,7 +219,7 @@  discard block
 
 block discarded – undo
219 219
220 220 
                     <a href="/media">Featured</a><br>
221 221 
                     <?php
222 
-                    if(isset($_SESSION['user'])) { echo "<a href='/home'>Manage</a><br><a href='/files'>Files<a>"; }
222 
+                    if (isset($_SESSION['user'])) { echo "<a href='/home'>Manage</a><br><a href='/files'>Files<a>"; }
223 223 
                     ?>
224 224 
                 </div>
225 225 
                 <br>
 
@@ -229,7 +229,7 @@  discard block
 
 block discarded – undo
229 229 
                         $stmt = $conn->prepare("SELECT * FROM files WHERE type='review' AND status='y' ORDER BY RAND() LIMIT 1");
230 230 
                         $stmt->execute();
231 231 
                         $result = $stmt->get_result();
232 
-                        while($row = $result->fetch_assoc()) {
232 
+                        while ($row = $result->fetch_assoc()) {
233 233 
                             echo "<br><img style='height: 5em;position: absolute;border: 1px solid white; width: 5em;' src='/pfp/" . getPFP($row['author'], $conn) . "'>
234 234 
                             <small>
235 235 
                             <a href='/view?id=" . $row['id'] . "'><span style='float:right;color: gold;'><i>[" . $row['agerating'] . "] " . $row['title'] . "</a></i></span><br>
 
@@ -245,7 +245,7 @@  discard block
 
 block discarded – undo
245 245 
                         $stmt = $conn->prepare("SELECT * FROM files WHERE type='news' AND status='y' ORDER BY RAND() LIMIT 1");
246 246 
                         $stmt->execute();
247 247 
                         $result = $stmt->get_result();
248 
-                        while($row = $result->fetch_assoc()) {
248 
+                        while ($row = $result->fetch_assoc()) {
249 249 
                             echo "<br><img style='height: 5em;position: absolute;border: 1px solid white; width: 5em;' src='/pfp/" . getPFP($row['author'], $conn) . "'>
250 250 
                             <small>
251 251 
                             <a href='/view?id=" . $row['id'] . "'><span style='float:right;color: gold;'>[" . $row['agerating'] . "] <i>" . $row['title'] . "</a></i></span><br>
 
@@ -261,8 +261,8 @@  discard block
 
 block discarded – undo
261 261 
                             $stmt = $conn->prepare("SELECT * FROM users ORDER BY id DESC");
262 262 
                             $stmt->execute();
263 263 
                             $result = $stmt->get_result();
264 
-                            if($result->num_rows === 0) echo('There are no users.');
265 
-                            while($row = $result->fetch_assoc()) {
264 
+                            if ($result->num_rows === 0) echo('There are no users.');
265 
+                            while ($row = $result->fetch_assoc()) {
266 266 
                                 $id = 1;
267 267 
                                 echo "<div class='item" . $id . "'><img style='height: 8em;width: 8em;' src='/pfp/" . getPFP($row['username'], $conn) . "'><br><a href='/?id=" . $row['id'] . "'>" . $row['username'] . "</a></div>";
268 268 
                                 $id = $id + 1;
 
@@ -279,7 +279,7 @@  discard block
 
 block discarded – undo
279 279 
                     $stmt = $conn->prepare("SELECT * FROM files WHERE type='image' AND status='y' ORDER BY RAND() LIMIT 6");
280 280 
                     $stmt->execute();
281 281 
                     $result = $stmt->get_result();
282 
-                    while($row = $result->fetch_assoc()) {
282 
+                    while ($row = $result->fetch_assoc()) {
283 283 
                         echo "<div style='display: inline-block;' class='notegray'>
284 284 
                             <a href='/view?id=" . $row['id'] . "'><img style='width: 7.5em;height: 7.5em;' src='/dynamic/image/" . $row['filename'] . "'>
285 285 
                             <br><center><b>" . htmlspecialchars($row['title']) . "</b><br><span style='color: gray;'>By " . $row['author'] . "</span></center>
Please login to merge, or discard this patch.