Passed
Pull Request — master (#20)
by
unknown
01:53
created
view/group.php 2 patches
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,9 @@  discard block
 block discarded – undo
50 50
                     $stmt->bind_param("i", $_GET['id']);
51 51
                     $stmt->execute();
52 52
                     $result = $stmt->get_result();
53
-                    if($result->num_rows === 0) echo('Group doesnt exist.');
53
+                    if($result->num_rows === 0) {
54
+                        echo('Group doesnt exist.');
55
+                    }
54 56
                     while($row = $result->fetch_assoc()) {
55 57
                         $id = $row['id'];
56 58
                         ?>
@@ -80,7 +82,9 @@  discard block
 block discarded – undo
80 82
                     $stmt->bind_param("i", $id);
81 83
                     $stmt->execute();
82 84
                     $result = $stmt->get_result();
83
-                    if($result->num_rows === 0) echo('There are no users.');
85
+                    if($result->num_rows === 0) {
86
+                        echo('There are no users.');
87
+                    }
84 88
                     $members = 0;
85 89
                     while($row = $result->fetch_assoc()) {
86 90
                         $members++;
Please login to merge, or discard this patch.
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -21,16 +21,16 @@  discard block
 block discarded – undo
21 21
         
22 22
         <div class="container">
23 23
             <?php
24
-                if($_SERVER['REQUEST_METHOD'] == 'POST')  {
25
-                    if(!isset($_SESSION['user'])) {
24
+                if ($_SERVER['REQUEST_METHOD'] == 'POST') {
25
+                    if (!isset($_SESSION['user'])) {
26 26
                         $error = "you are not logged in";
27 27
                         goto skipcomment;
28 28
                     }
29
-                    if(!$_POST['comment']) {
29
+                    if (!$_POST['comment']) {
30 30
                         $error = "your comment cannot be blank";
31 31
                         goto skipcomment;
32 32
                     }
33
-                    if(strlen($_POST['comment']) > 500) {
33
+                    if (strlen($_POST['comment']) > 500) {
34 34
                         $error = "your comment must be shorter than 500 characters";
35 35
                         goto skipcomment;
36 36
                     }
@@ -43,26 +43,26 @@  discard block
 block discarded – undo
43 43
                 }
44 44
                 skipcomment:
45 45
 
46
-                if(isset($_GET['id'])) {
46
+                if (isset($_GET['id'])) {
47 47
                     $stmt = $conn->prepare("SELECT * FROM `groups` WHERE id = ?");
48 48
                     $stmt->bind_param("i", $_GET['id']);
49 49
                     $stmt->execute();
50 50
                     $result = $stmt->get_result();
51
-                    if($result->num_rows === 0) echo('Group doesnt exist.');
52
-                    while($row = $result->fetch_assoc()) {
51
+                    if ($result->num_rows === 0) echo('Group doesnt exist.');
52
+                    while ($row = $result->fetch_assoc()) {
53 53
                         $id = $row['id'];
54 54
                         ?>
55 55
                         <img style='border: 1px solid white; width: 5em;'
56
-                             src='/pfp/<?php echo getPFP($row["author"], $conn);?>'>
56
+                             src='/pfp/<?php echo getPFP($row["author"], $conn); ?>'>
57 57
                         <span style='float: right;text-align: right;'>
58
-                            <a href='/view/group?id=<?php echo $row["id"];?>' style='color: gold;font-size:1.5em'>
59
-                                <?php echo $row['title'];?>
58
+                            <a href='/view/group?id=<?php echo $row["id"]; ?>' style='color: gold;font-size:1.5em'>
59
+                                <?php echo $row['title']; ?>
60 60
                             </a><br>
61 61
                             <small>
62 62
                                 <i>
63 63
                                     Created by
64
-                                    <a href='/view/profile?id=<?php echo getID($row["author"], $conn);?>'>
65
-                                        <?php echo $row['author'];?>
64
+                                    <a href='/view/profile?id=<?php echo getID($row["author"], $conn); ?>'>
65
+                                        <?php echo $row['author']; ?>
66 66
                                     </a>
67 67
                                 </i><br>
68 68
                                 <?php echo $row['date']?>
@@ -78,12 +78,12 @@  discard block
 block discarded – undo
78 78
                     $stmt->bind_param("i", $id);
79 79
                     $stmt->execute();
80 80
                     $result = $stmt->get_result();
81
-                    if($result->num_rows === 0) echo('There are no users.');
81
+                    if ($result->num_rows === 0) echo('There are no users.');
82 82
                     $members = 0;
83
-                    while($row = $result->fetch_assoc()) {
83
+                    while ($row = $result->fetch_assoc()) {
84 84
                         $members++;
85 85
                     }
86
-                    echo "<span style='float:right;'><a href='/joingroup?id=" . $id. "'><button>Join</button></a></span>";
86
+                    echo "<span style='float:right;'><a href='/joingroup?id=" . $id . "'><button>Join</button></a></span>";
87 87
                 } else {
88 88
                     header("Location: view/groups.php");
89 89
                 }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
             <hr>
93 93
             <div>
94 94
                 <div class="left">
95
-                    <?php if(isset($error)) {echo "<small style='color:red'>" . $error . "</small>";}?>
95
+                    <?php if (isset($error)) {echo "<small style='color:red'>" . $error . "</small>"; }?>
96 96
                     <h2>Comments</h2>
97 97
                     <?php if (isset($_SESSION['user'])) { ?>
98 98
                         <form method="post" enctype="multipart/form-data">
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
                             $stmt->execute();
110 110
                             $result = $stmt->get_result();
111 111
                 
112
-                            while($row = $result->fetch_assoc()) { ?>
112
+                            while ($row = $result->fetch_assoc()) { ?>
113 113
                                 <div class='commentRight' style='display: grid; grid-template-columns: 75% auto; padding:5px;'>
114 114
                                     <div style="word-wrap: break-word;">
115 115
                                         <small><?php echo $row['date']; ?></small>
116
-                                        <?php echo validateMarkdown($row['text']);?>
116
+                                        <?php echo validateMarkdown($row['text']); ?>
117 117
                                     </div>
118 118
                                     <div>
119 119
                                         <a style='float: right;' href='/view/profile?id=<?php echo getID($row['author'], $conn); ?>'><?php echo $row['author']; ?></a>
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                     </div>
126 126
                 </div>
127 127
                 <div class="right">
128
-                    <h2>Members (<?php echo $members;?>)</h2>
128
+                    <h2>Members (<?php echo $members; ?>)</h2>
129 129
                     <?php
130 130
                         $stmt = $conn->prepare("SELECT `username`, `id` FROM `users` WHERE `currentgroup` = ?");
131 131
                         $stmt->bind_param("i", $id);
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 
135 135
                         echo "<ul>";
136 136
                         while ($row = $result->fetch_assoc()) {
137
-                            echo "<li><a href='/view/profile?id=" . $row['id'] . "'>". $row['username'] . "</a></li>";
137
+                            echo "<li><a href='/view/profile?id=" . $row['id'] . "'>" . $row['username'] . "</a></li>";
138 138
                         }
139 139
                         echo "</ul>";
140 140
                     ?>
Please login to merge, or discard this patch.
view/items.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
             require(__DIR__ . "/../func/func.php");
9 9
             require(__DIR__ . "/../func/conn.php"); 
10 10
             $featured = array(1, 3, 12);
11
-            $newlines = array("<br>", " <br>", "<br>" , " <br> ");
11
+            $newlines = array("<br>", " <br>", "<br>", " <br> ");
12 12
         ?>
13 13
         <title>4Grounds - Hub</title>
14 14
     </head>
@@ -17,27 +17,27 @@  discard block
 block discarded – undo
17 17
         <div class="container"><br>
18 18
             <h1>Search results for type '<?php echo htmlspecialchars($_GET['type']); ?>'</h1>
19 19
             <?php
20
-            if(isset($_GET['type'])) {
20
+            if (isset($_GET['type'])) {
21 21
                 $stmt = $conn->prepare("SELECT * FROM `files` WHERE type = ? AND status = 'y' ORDER BY id DESC");
22 22
                 $stmt->bind_param("s", $_GET['type']);
23 23
                 $stmt->execute();
24 24
                 $result = $stmt->get_result();
25 25
 
26
-                while($row = $result->fetch_assoc()) { 
27
-                    if($row['type'] == "song") {
26
+                while ($row = $result->fetch_assoc()) { 
27
+                    if ($row['type'] == "song") {
28 28
                         echo '<b><a href="/view?id=' . $row['id'] . '">' . htmlspecialchars($row['title']) . '</b></a> <span style="float:right;"><small>Uploader: <b>' . $row['author'] . '</b></small></span><br>
29 29
                         ' . $row['extrainfo'] . '<br>
30 30
                         <audio controls>
31 31
                         <source src="/dynamic/song/' . $row['filename'] . '">
32 32
                         </audio><hr>';
33
-                    } else if($row['type'] == "image") {
33
+                    } else if ($row['type'] == "image") {
34 34
                         //im sorry for this abomination
35 35
                         echo "<div style='display: inline-block;' class='notegray'>
36 36
                             <a href='/view?id=" . $row['id'] . "'><img style='width: 10em;height: 10em;' src='images/" . $row['filename'] . "'>
37 37
                             <br><center><b>" . htmlspecialchars($row['title']) . "</b><br><span style='color: gray;'>By " . $row['author'] . "</span></center>
38 38
                             </a>
39 39
                         </div> ";  
40
-                    } else if($row['type'] == "news" || $row['type'] == "review") {
40
+                    } else if ($row['type'] == "news" || $row['type'] == "review") {
41 41
                         echo "<small>
42 42
                         <img style='position: absolute;border: 1px solid white; width: 5em;' src='/pfp/" . getPFP($row['author'], $conn) . "'>
43 43
                         <a href='/view?id=" . $row['id'] . "'><span style='float:right;color: gold;'>[" . $row['agerating'] . "] <i>" . $row['title'] . "</a></i></span><br>
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
                     } else {
48 48
                         echo "<b><a href='/view?id=" . $row['id'] . "'>" . htmlspecialchars($row['title']) . " by " . $row['author'] . "
49 49
                         </a><small><span style='float:right;'>[" . $row['date'] . "]</small></span>";
50
-                        if(in_array($row['id'], $featured)) {
50
+                        if (in_array($row['id'], $featured)) {
51 51
                             echo "<span style='float:right; color: gold;margin-right: 10px;'>Featured!</span> &nbsp;";
52 52
                         }
53 53
                         echo "</b><br>" . $row['extrainfo'] . "<br><hr>";
Please login to merge, or discard this patch.
func/upload.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 return function($type, $allowedFileTypes, $conn) {
3
-    if(isset($_SESSION['user'])) {
3
+    if (isset($_SESSION['user'])) {
4 4
         $fileType = strtolower(pathinfo($_FILES["fileToUpload"]["name"], PATHINFO_EXTENSION));
5 5
         $target_dir = __DIR__ . "/../dynamic/" . $type . "/";
6 6
         $target_name = md5_file($_FILES["fileToUpload"]["tmp_name"]) . "." . $fileType;
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
             $movedFile = move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], $target_file);
16 16
         }
17 17
 
18
-        if(!in_array($fileType, $allowedFileTypes)) {
18
+        if (!in_array($fileType, $allowedFileTypes)) {
19 19
             echo 'unsupported file type. must be one of ' . join(", ", $allowedFileTypes) . '<hr>';
20 20
             $uploadOk = 0;
21 21
         }
Please login to merge, or discard this patch.
upload/game.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     <body> 
13 13
         <?php require(__DIR__ . "/../important/header.php"); 
14 14
         
15
-        if(@$_POST['submit']) {
15
+        if (@$_POST['submit']) {
16 16
             $register = require(__DIR__ . "/../func/upload.php");
17 17
             $register("game", ["swf"], $conn);
18 18
         }
Please login to merge, or discard this patch.
upload/midi.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     <body> 
13 13
         <?php require(__DIR__ . "/../important/header.php"); 
14 14
         
15
-        if(@$_POST['submit']) {
15
+        if (@$_POST['submit']) {
16 16
             $register = require(__DIR__ . "/../func/upload.php");
17 17
             $register("midi", ["mid"], $conn);
18 18
         }
Please login to merge, or discard this patch.
upload/video.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     <body> 
13 13
         <?php require(__DIR__ . "/../important/header.php"); 
14 14
         
15
-        if(@$_POST['submit']) {
15
+        if (@$_POST['submit']) {
16 16
             $register = require(__DIR__ . "/../func/upload.php");
17 17
             $register("video", ["mp4"], $conn);
18 18
         }
Please login to merge, or discard this patch.
upload/chiptune.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     <body> 
13 13
         <?php require(__DIR__ . "/../important/header.php"); 
14 14
         
15
-        if(@$_POST['submit']) {
15
+        if (@$_POST['submit']) {
16 16
             $register = require(__DIR__ . "/../func/upload.php");
17 17
             $register("chiptune", ["xm", "mod", "s3m", "it"], $conn);
18 18
         }
Please login to merge, or discard this patch.
upload/song.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     <body> 
13 13
         <?php require(__DIR__ . "/../important/header.php"); 
14 14
         
15
-        if(@$_POST['submit']) {
15
+        if (@$_POST['submit']) {
16 16
             $register = require(__DIR__ . "/../func/upload.php");
17 17
             $register("song", ["ogg", "mp3"], $conn);
18 18
         }
Please login to merge, or discard this patch.
upload/image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     <body> 
13 13
         <?php require(__DIR__ . "/../important/header.php"); 
14 14
         
15
-        if(@$_POST['submit']) {
15
+        if (@$_POST['submit']) {
16 16
             $register = require(__DIR__ . "/../func/upload.php");
17 17
             $register("image", ["gif", "png", "jpg", "jpeg"], $conn);
18 18
         }
Please login to merge, or discard this patch.